June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: core: support space within source directory
by Alon Bar-Lev 29 Jun '13

29 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support space within source directory ...................................................................... core: support space within source directory Change-Id: I94358b10306a3bf9b2f996e68cd5bcce9a3243c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/bin/ovirt-host-deploy.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94358b10306a3bf9b2f996e68cd5bcce9a3243c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: support space within installation directory
by Alon Bar-Lev 29 Jun '13

29 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support space within installation directory ...................................................................... core: support space within installation directory Change-Id: Ic168c3a169acba28bd02a68432b3d21f23897ae7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/bin/otopi 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic168c3a169acba28bd02a68432b3d21f23897ae7 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: PluginResourceServlet: remove unneeded code
by vszocs＠redhat.com 28 Jun '13

28 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: PluginResourceServlet: remove unneeded code ...................................................................... webadmin: PluginResourceServlet: remove unneeded code Change-Id: I13e2cdd8daae9f40c447819424614e528ec5d682 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginResourceServlet.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e2cdd8daae9f40c447819424614e528ec5d682 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Improve UI Plugin tab API
by vszocs＠redhat.com 28 Jun '13

28 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Improve UI Plugin tab API ...................................................................... webadmin: Improve UI Plugin tab API GWTP/infrastructure changes --------------------------- 1. Introduced AbstractTabPresenter as the parent presenter for AbstractMainTabPresenter and AbstractSubTabPresenter. 2. Adding custom action buttons to existing main/sub tabs is now done via AddTabActionButtonEvent handled by AbstractTabPresenter via @ProxyEvent. EventBus provides loose coupling between caller (PluginUiFunctions) and handler (AbstractTabPresenter). 3. Minor improvements in ActionButtonDefinition interface: - isAccessible() now accepts selected items for consistency with ActionButtonInterface.isAccessible() - getUniqueId() can now return null (no ID available) - getToolTip() renamed to getButtonToolTip() - getCustomToolTip() renamed to getMenuItemToolTip() 4. Updated AbstractActionPanel according to changes in ActionButtonDefinition interface. 5. Introduced AbstractButtonDefinition as base implementation of ActionButtonDefinition interface. This class is used for both existing buttons (UiCommandButtonDefinition) and custom buttons (extend AbstractButtonDefinition directly). UI Plugin API changes --------------------- 6. Revamped EntityType enum, added missing entity types: - Network - Pool - GlusterVolume - Provider - User - Quota - Event 7. addSubTab and addMainTabActionButton API now support all entity types. 8. Introduced addSubTabActionButton API with following signature: addSubTabActionButton( mainTabEntityTypeName, // Which main tab? subTabEntityTypeName, // Which sub tab? label, actionButtonInterface) For now, subTabEntityTypeName supports only 'Event' value. 9. Updated EntityObject with basic property mappings for new entity types. 10. Added <EntityType>SelectionChange event handler functions for new entity types Change-Id: I2f3e33844693a08352cc54b60b05b3f6ac5eb816 Bug-Url: https://bugzilla.redhat.com/953989 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AddTabActionButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabFormView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTreeWidgetView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/ActionButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/HasActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityType.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterPolicyPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/ReportActionsHelper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminButtonDefinition.java 28 files changed, 759 insertions(+), 486 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f3e33844693a08352cc54b60b05b3f6ac5eb816 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: handle multiple files in exclude of recurs...
by oschreib＠redhat.com 28 Jun '13

28 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: handle multiple files in exclude of recursive copy ...................................................................... packaging: build: handle multiple files in exclude of recursive copy the output of find... contained mixed newline and space delimited file list, workout find to return space delimited to avoid issues within the target. Change-Id: I4711908f398ff8f848b87017e47f37caecec5b2f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reported-By: Martin Perina <mperina(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4711908f398ff8f848b87017e47f37caecec5b2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.9-1
by mpastern＠redhat.com 28 Jun '13

28 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.9-1 ...................................................................... sdk: release 1.0.0.9-1 Change-Id: Ia48786af9b04b1f54dc75f9d4c4813f13a1d81af Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia48786af9b04b1f54dc75f9d4c4813f13a1d81af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in otopi[master]: services: systemd: fix typo
by Alon Bar-Lev 28 Jun '13

28 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: services: systemd: fix typo ...................................................................... services: systemd: fix typo Change-Id: Icb17696f2dcf70c96e58d1c4f5eedf1be49e5b81 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/services/systemd.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb17696f2dcf70c96e58d1c4f5eedf1be49e5b81 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: fix python compatibility issue and network man...
by Alon Bar-Lev 27 Jun '13

27 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: fix python compatibility issue and network manager ...................................................................... vdsm: bridge: fix python compatibility issue and network manager Change-Id: I1b5a9596afce140158e66608f442128c7584779b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b5a9596afce140158e66608f442128c7584779b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: vdsm: bridge: fix python compatibility issue and network man...
by Alon Bar-Lev 27 Jun '13

27 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: fix python compatibility issue and network manager ...................................................................... vdsm: bridge: fix python compatibility issue and network manager Change-Id: I5e042506358ff48f8d06b1cfbf9b6ccf517b45ec Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e042506358ff48f8d06b1cfbf9b6ccf517b45ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: Adding useDefaultKeyPair implementation to EngineSSHDialog
by yzaslavs＠redhat.com 27 Jun '13

27 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Adding useDefaultKeyPair implementation to EngineSSHDialog ...................................................................... Adding useDefaultKeyPair implementation to EngineSSHDialog Instead of using internal client object, set the keyPair for sshdialog internally. It fixes NPE when calling to useDefaultKeyPair without initialize the client object. Change-Id: I02edaee6bc6e804bb36d3ab4dabaa21faa926fa0 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02edaee6bc6e804bb36d3ab4dabaa21faa926fa0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0