July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: State that spice-html5 is tech preview
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: State that spice-html5 is tech preview ...................................................................... frontend: State that spice-html5 is tech preview This patch adds "Tech preview" text to spice-html5 radio button caption. Change-Id: Ibd94b7f2951a459c9b7571e55372653bbad83a5d Bug-Url: https://bugzilla.redhat.com/988374 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd94b7f2951a459c9b7571e55372653bbad83a5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Make adding (virtio-)console to virtual machines op...
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Make adding (virtio-)console to virtual machines optional ...................................................................... restapi: Make adding (virtio-)console to virtual machines optional This is rest part of a feature that allows users to control attaching virtio console to vm/pools/templates. Change-Id: I733e4c4a9c7d8f5dbe68b6b26a49502b8a40ec9d Bug-Url: https://bugzilla.redhat.com/878459 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java 16 files changed, 314 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733e4c4a9c7d8f5dbe68b6b26a49502b8a40ec9d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: services: ovirt-engine: support space within java...
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: support space within java properties ...................................................................... packaging: services: ovirt-engine: support space within java properties Change-Id: I0dfb09391ae5d3c92de4ce97e29b60a73135cbcd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dfb09391ae5d3c92de4ce97e29b60a73135cbcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: avoid use xrange
by oschreib＠redhat.com 31 Jul '13

31 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: avoid use xrange ...................................................................... packaging: setup: avoid use xrange not supported in python-3 Change-Id: I3676ac13b3547c011dc39dc2b1ea34bf2476417d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3676ac13b3547c011dc39dc2b1ea34bf2476417d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove duplicate server call
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: remove duplicate server call ...................................................................... webadmin: remove duplicate server call This call is already there - it has been introduced again as a consequence of a merging mistake. Change-Id: I511614ab06ea79e118094b9962a6fc90e05fbbb9 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 1 insertion(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511614ab06ea79e118094b9962a6fc90e05fbbb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: added singular form of nics assignment ...
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: added singular form of nics assignment message ...................................................................... webadmin,userportal: added singular form of nics assignment message If there is only one nic, the message should be in singular Change-Id: I312f8b9fb4808edf90492461b69541038af30393 Bug-Url: https://bugzilla.redhat.com/987858 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/network/LogicalNetworksEditor.java 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312f8b9fb4808edf90492461b69541038af30393 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: if SpiceReleaseCursorKeys is set SPICE is not open...
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: if SpiceReleaseCursorKeys is set SPICE is not opened ...................................................................... frontend: if SpiceReleaseCursorKeys is set SPICE is not opened If the SpiceReleaseCursorKeys changes to for example "shift+a" than after clicking the console button the AsyncDataProvider.getComplexValueFromSpiceRedKeysResource throws an exception. The problem was that the getComplexValueFromSpiceRedKeysResource expects to have all parts of the release cursor keys in the SpiceRedKeys. In case of "shift+a" it finds "shift" but does not find "a" and fails. Fixed by first tying to localize the key (look up in SpiceRedKeys) but if it does not succeed than returning the key itself. It is safe to do because the result of getComplexValueFromSpiceRedKeysResource is used only to show up in the title of the SPICE window and the SpiceRedKeys contains only the localized parts of it. Change-Id: Iacbaadf7d6d91c04ec4ec79edc73514bad031714 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 2 files changed, 14 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacbaadf7d6d91c04ec4ec79edc73514bad031714 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: Revert "packaging: Fixed building RPMs on non-x86_64 archite...
by Alon Bar-Lev 30 Jul '13

30 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: Revert "packaging: Fixed building RPMs on non-x86_64 architectures" ...................................................................... Revert "packaging: Fixed building RPMs on non-x86_64 architectures" This reverts commit 35a5b5f5e6d6c240ef1d20904bc06498b0ed81e1 Change-Id: I3525c76f7b501836a0b1a1e507ac4d8b91a637df --- M ovirt-host-deploy.spec.in 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3525c76f7b501836a0b1a1e507ac4d8b91a637df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add external identifier to DbUser
by juan.hernandez＠redhat.com 30 Jul '13

30 Jul '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add external identifier to DbUser ...................................................................... core: Add external identifier to DbUser We currently store users and groups in the database using the DbUser entity, and this entity uses the identifier provided by the LDAP server as its primary key. This assumes that the identifiers provided by LDAP servers are unique, even those provided by different LDAP servers, which isn't correct. This change adds a new "ExternalId" attribute to DbUser intended to store the identifier used by the LDAP server, so in the future we will be able to use an unique identifier generated by the engine. Change-Id: Iaf81ba87a178f3d275ed172e82b0036635f1a28f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0620_add_external_id_to_users.sql M packaging/dbscripts/user_sp.sql 8 files changed, 153 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf81ba87a178f3d275ed172e82b0036635f1a28f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fixing backendHostResourceTests expectation results
by mpastern＠redhat.com 30 Jul '13

30 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: Fixing backendHostResourceTests expectation results ...................................................................... Fixing backendHostResourceTests expectation results After adding http://gerrit.ovirt.org/17194 that fixes the host mapping in update() function, the tests were needed to be modify to expect for the set value. Checking for rootPassword, should be the rootPassword that set for the action. Change-Id: I00c710edac936f9d850740199824bd28a295fc87 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java 2 files changed, 9 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c710edac936f9d850740199824bd28a295fc87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0