July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove object_column_white_list from fixtures.xml
by yzaslavs＠redhat.com 15 Jul '13

15 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remove object_column_white_list from fixtures.xml ...................................................................... core: Remove object_column_white_list from fixtures.xml This fixture is not needed. This is a metadata table and is not changing within tests. It should be created by create_schema.sh and be left as is. A fix was also inserted to the whitelist sql, to change sshkeyfingerpint to be lowercase so VdsDAOTest will not break. The breakage of VdsDAOTest exposed that a non privileged user could get the ssh key fingerprint. Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql 2 files changed, 1 insertion(+), 350 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0429c322f923f0b3c725270aa51c121ca27129 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Added postgres listening external network
by ydary＠redhat.com 15 Jul '13

15 Jul '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added postgres listening external network ...................................................................... packaging: Added postgres listening external network This patch adds the interaction for the user allowing to setup the local postgres to listen on external connections. The patch will check if it is able to create database, and will only offer to configure postgres in local installation. It will also create a read-only role with user-provided credentials and open the required firewall ports if necessary. It also creates a self-signed certificate if user choses to use secure connections. Change-Id: Ibdd133a392fb3dba6088a9fb12ce4ca828f24073 Bug-Url: https://bugzilla.redhat.com/737598 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 283 insertions(+), 91 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdd133a392fb3dba6088a9fb12ce4ca828f24073 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: allowing to create DB without superuser
by ydary＠redhat.com 15 Jul '13

15 Jul '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: allowing to create DB without superuser ...................................................................... packaging: allowing to create DB without superuser Current implementation works with legacy DB creation. This new implementation adds working with DB environment created with otopi-based engine setup utility. Related-To: https://bugzilla.redhat.com/737598 Change-Id: I390d53b3768f08b2c62f31aeb32c1992f11b6999 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh M data-warehouse/historydbscripts_postgres/ovirt-engine-history-db-install.sh M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 4 files changed, 259 insertions(+), 96 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I390d53b3768f08b2c62f31aeb32c1992f11b6999 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix not able to update non guid ids
by mpastern＠redhat.com 15 Jul '13

15 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Fix not able to update non guid ids ...................................................................... restapi: Fix not able to update non guid ids Fixed the REST infrastructure to be able to accept non guid ids in "update" action of entities - use generic T instead of Guid. This change aligns the "update" behavior with the "add" action that already works this way and allows non guid ids. Change-Id: I4dbdca3fc820e7480d0bcffcec35568ee96b887d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendSubResource.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dbdca3fc820e7480d0bcffcec35568ee96b887d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: API: Fix for VmMapperTests
by yzaslavs＠redhat.com 15 Jul '13

15 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: API: Fix for VmMapperTests ...................................................................... API: Fix for VmMapperTests Adding mock for OsRepository. The sequence of the tests is not constant, and the mock wasn't set before the test for some runs that testMapHostId ran before the other vmMapperTests. Change-Id: I80a76b5fea41e3a9b914bed2034f14b20fde4117 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80a76b5fea41e3a9b914bed2034f14b20fde4117 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix double checking
by amureini＠redhat.com 15 Jul '13

15 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix double checking ...................................................................... core: Fix double checking VdsLoadBalancer.getInstance() implements a double-checking scheme to initialize the instance static member. In order for this mechanism to operate correctly, the instance member should be defined as volatile (see, e.g., http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove System.out from UpdateVmCommandTest
by amureini＠redhat.com 15 Jul '13

15 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove System.out from UpdateVmCommandTest ...................................................................... core: Remove System.out from UpdateVmCommandTest Change-Id: I4feee40449ed23e05b03da71ba35acf63e5c7c6c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4feee40449ed23e05b03da71ba35acf63e5c7c6c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in gerrit-admin[master]: Added hook that sets the bug to MODIFIED
by dcaroest＠redhat.com 15 Jul '13

15 Jul '13

David Caro has submitted this change and it was merged. Change subject: Added hook that sets the bug to MODIFIED ...................................................................... Added hook that sets the bug to MODIFIED - Only if * product = oVirt * all externals are closed Change-Id: Ifedcf594e962ab9d495bc32c48763a01890bd2a4 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/bz/change-merged.bz.set_MODIFIED 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifedcf594e962ab9d495bc32c48763a01890bd2a4 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added hook to pass bug to POST status
by dcaroest＠redhat.com 15 Jul '13

15 Jul '13

David Caro has submitted this change and it was merged. Change subject: Added hook to pass bug to POST status ...................................................................... Added hook to pass bug to POST status Change-Id: I03a2e42dd8f6d1062ef0bcaf2ec1ace36967c2c0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/bz/patchset-created.bz.2.set_POST 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: Moran Goldboim: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03a2e42dd8f6d1062ef0bcaf2ec1ace36967c2c0 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added hook to add the external tracker
by dcaroest＠redhat.com 15 Jul '13

15 Jul '13

David Caro has submitted this change and it was merged. Change subject: Added hook to add the external tracker ...................................................................... Added hook to add the external tracker Change-Id: Idd5ba49d8a253a1fbd1ec6cd0073f53b47f81342 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/bz/patchset-created.bz.2.add_tracker 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Moran Goldboim: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd5ba49d8a253a1fbd1ec6cd0073f53b47f81342 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0