July 2013 - Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Hook to check that the Bug-Url was specified
by dcaroest＠redhat.com 15 Jul '13

15 Jul '13

David Caro has submitted this change and it was merged. Change subject: Hook to check that the Bug-Url was specified ...................................................................... Hook to check that the Bug-Url was specified - Also added the hook that writes the review, as the functionality is not complete without it Change-Id: Ia127c6a3d1400fb7c1646990d844b607604d3e60 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/bz/patchset-created.bz.1.bug_url A hooks/bz/patchset-created.bz.99.review_ok 2 files changed, 71 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, but someone else must approve David Caro: Verified Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia127c6a3d1400fb7c1646990d844b607604d3e60 Gerrit-PatchSet: 5 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added the common libraries for the hooks to use
by dcaroest＠redhat.com 15 Jul '13

15 Jul '13

David Caro has submitted this change and it was merged. Change subject: Added the common libraries for the hooks to use ...................................................................... Added the common libraries for the hooks to use - bz.sh: functions to query bugzilla - conf.sh: configuration amangement functions - gerrit.sh: gerrit related functions - tools.sh: generic helper functions Change-Id: I7a10060cff5c25e8bd8e2f73654208a90cec70d8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/lib/bz.sh A hooks/lib/conf.sh A hooks/lib/gerrit.sh A hooks/lib/tools.sh 4 files changed, 834 insertions(+), 0 deletions(-) Approvals: David Caro: Verified Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a10060cff5c25e8bd8e2f73654208a90cec70d8 Gerrit-PatchSet: 5 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Edit USB policy only on down status
by rgolan＠redhat.com 15 Jul '13

15 Jul '13

Roy Golan has submitted this change and it was merged. Change subject: core: Edit USB policy only on down status ...................................................................... core: Edit USB policy only on down status restrict editing the UsbPolicy field only when the vm is down. this is because devices are reported from the VM after some period of time which is not long but unpredicted which could lead to adding new devices without detaching the old one. Change-Id: Idb0698112b914b81599d87bbf45351c17c568602 Bug-Url: https://bugzilla.redhat.com/950768 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb0698112b914b81599d87bbf45351c17c568602 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: improve logging in gluster sync job
by kmayilsa＠redhat.com 15 Jul '13

15 Jul '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: improve logging in gluster sync job ...................................................................... engine: improve logging in gluster sync job Added more information to logging while refreshing the servers list in a gluster cluster. Change-Id: Ie07ba4447366915e0a9d487d241ea1ae9927a196 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerInfo.java 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie07ba4447366915e0a9d487d241ea1ae9927a196 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use Collections#EMPTY_MAP instead of new map
by ofrenkel＠redhat.com 15 Jul '13

15 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: use Collections#EMPTY_MAP instead of new map ...................................................................... core: use Collections#EMPTY_MAP instead of new map In VmHandler#findStorageDomainForMemory(Guid, long) we create everytime a new map and pass it on. This new map is empty map and no one adds anything to it, so we can use the singleton map Collections#EMPTY_MAP instead. Change-Id: I4053e06f17827d8afbdc48ad006897c029426384 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4053e06f17827d8afbdc48ad006897c029426384 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Correct SWIFT status if no hosts in cluster
by kmayilsa＠redhat.com 15 Jul '13

15 Jul '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Correct SWIFT status if no hosts in cluster ...................................................................... gluster: Correct SWIFT status if no hosts in cluster If there are no hosts available under a cluster the SWIFT status was being displayed as Up. Corrected the same to show Unknown is no hosts available under a cluster or removed all the hosts from the cluster. Change-Id: I17080ac2d3eb5ec87b2efcc86bdca750995bce0e Bug-Url: https://bugzilla.redhat.com/974560 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17080ac2d3eb5ec87b2efcc86bdca750995bce0e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing NPE on ExecutionHandler
by yzaslavs＠redhat.com 15 Jul '13

15 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing NPE on ExecutionHandler ...................................................................... core: fixing NPE on ExecutionHandler Fix a NPE issue found by FindBugs http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4646/findbugsResult/mod… Change-Id: I35034cd331476b6c42a266504979be848ae63c93 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35034cd331476b6c42a266504979be848ae63c93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: RFE-Adding External Tasks Support
by emesika＠redhat.com 14 Jul '13

14 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: restapi: RFE-Adding External Tasks Support ...................................................................... restapi: RFE-Adding External Tasks Support Enable plug-in to inject tasks to the engine application using the REST API, change their statuses and track them from the UI. A task may have other nesting sub-tasks under it. more info : http://www.ovirt.org/Features/ExternalTasks http://www.ovirt.org/Features/Design/DetailedExternalTasks Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91601952 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872719 --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/JobResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/JobsResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StepResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StepsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendJobResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendJobsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendJobResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendJobsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/JobMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StepMapperTest.java 30 files changed, 1,425 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91601952 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding GetAllStepsQuery
by emesika＠redhat.com 14 Jul '13

14 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Adding GetAllStepsQuery ...................................................................... core: Adding GetAllStepsQuery Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91609841 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872719 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllStepsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91609841 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding GetStepsByJobIdQuery
by emesika＠redhat.com 14 Jul '13

14 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Adding GetStepsByJobIdQuery ...................................................................... core: Adding GetStepsByJobIdQuery Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91608739 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872719 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepsByJobIdQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 40 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91608739 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0