Change in ovirt-engine[master]: gluster: Corrected conflict in LocalizedEnums
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Corrected conflict in LocalizedEnums
......................................................................
gluster: Corrected conflict in LocalizedEnums
There was a conflict in LocalizedEnums.properties. Corrected the same.
Change-Id: I82f0dc0351e58b951a5e56db0b73aaa1acaa81bd
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82f0dc0351e58b951a5e56db0b73aaa1acaa81bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
11 years, 5 months
Change in otopi[master]: network: firewalld: fixed firewall-cmd support
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: network: firewalld: fixed firewall-cmd support
......................................................................
network: firewalld: fixed firewall-cmd support
in firewall-cmd 0.3.3 shipped with Fedora 19
firewall-cmd --get-active-zone has changed the output from:
<zone1>: <interface1> <interface2>
to:
<zone1>
interfaces: <interface1> <interface2>
Dropped _isPermanentSupported: using the version
for detecting --permanent option support
Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/otopi/network/firewalld.py
1 file changed, 55 insertions(+), 19 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, approved
Sandro Bonazzola: Verified
--
To view, visit http://gerrit.ovirt.org/16094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Gerrit-PatchSet: 6
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: frontend: show templates according to selected cluster
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: show templates according to selected cluster
......................................................................
frontend: show templates according to selected cluster
This patch fix a regression which caused the templates not to get
updated when changing the cluster in the 'New VM' dialog
Change-Id: Idba84e6458c88d1857d6c9274a178c31a3034869
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/16249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idba84e6458c88d1857d6c9274a178c31a3034869
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: avoid NPE on RemoveDiskCommand (floating disk)
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: avoid NPE on RemoveDiskCommand (floating disk)
......................................................................
core: avoid NPE on RemoveDiskCommand (floating disk)
When attempting to remove floating disk the use of switch case on NULL
causes to NPE.
Change-Id: Ibcce291f0e410d5d603c45cb9f9cf21c740de2f1
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Ar: Verified
--
To view, visit http://gerrit.ovirt.org/16326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcce291f0e410d5d603c45cb9f9cf21c740de2f1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: gluster:Use uid check while sync from CLI
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster:Use uid check while sync from CLI
......................................................................
gluster:Use uid check while sync from CLI
While syncing gluster servers from gluster CLI
use the gluster host UUID to compare if the
server is present in the engine database or
not.
Change-Id: Id74b47bde915bb0736bce3826e371d8583e1cc6b
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
3 files changed, 69 insertions(+), 17 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id74b47bde915bb0736bce3826e371d8583e1cc6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: Adds SSH Soft Fencing capability
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adds SSH Soft Fencing capability
......................................................................
core: Adds SSH Soft Fencing capability
Adds SshSoftFencingCommand which provides ability to restart VDSM
on the host using SSH connection. SshSoftFencingCommand is executed
prior to standard fencing process. If the VDSM restart doesn't help,
standard fencing process will be executed. SshSoftFencingCommand is also
executed for host without power management configured (on these hosts
standard fencing cannot be executed).
Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Bug-Url: https://bugzilla.redhat.com/967328
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
5 files changed, 166 insertions(+), 9 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8002b6ac00a1e2e543b5cc8d1affdd42b994d5f7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Introducing VdsValidator class
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Introducing VdsValidator class
......................................................................
core: Introducing VdsValidator class
Created VdsValidator class that should contain methods used to validate
VDS status before executing some actions on it.
Change-Id: I6f8d22a148513bdbfa46b195e92bc90d66a962ba
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java
2 files changed, 60 insertions(+), 23 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f8d22a148513bdbfa46b195e92bc90d66a962ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 5 months
Change in ovirt-engine-sdk-java[master]: deploy: require apache-commons-logging
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: deploy: require apache-commons-logging
......................................................................
deploy: require apache-commons-logging
Change-Id: Ie372b237bcd23a9f0edd1a0d90071f07d31f92f8
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
M ovirt-engine-sdk-java/pom.xml
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie372b237bcd23a9f0edd1a0d90071f07d31f92f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 5 months
Change in ovirt-engine-sdk-java[master]: deploy: require log4j
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: deploy: require log4j
......................................................................
deploy: require log4j
Change-Id: I2e4f2ad6737bbeff153f6ddc6c611a9cd7cead5b
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e4f2ad6737bbeff153f6ddc6c611a9cd7cead5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: avoid having LOCKED domain on a failed reconstruct.
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: avoid having LOCKED domain on a failed reconstruct.
......................................................................
core: avoid having LOCKED domain on a failed reconstruct.
When the reconstruct command is being executed during its CDA phase
the pool's domains statuses are loaded and are checked for being different
then LOCKED.
getStorageDomain() is being called prior to the CDA check from
getJobMessageProperties(), which means that possibly the loaded domain
would be in status LOCKED.
In case of using compensation through reconstruct, the domain status
might be reverted to LOCKED instead of to it's actual status.
This patch only verifies that the loaded domain within
getStorageDomain() isn't LOCKED, a further behaviour change might be
needed generally.
Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months