July 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Remove null check from Guid.equals(Object)

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove null check from Guid.equals(Object) ...................................................................... core: Remove null check from Guid.equals(Object) Since (null instanceof anyObject) always returns false anyway, it's redundant to explicitly check for nulls. Change-Id: Ia8a5a0ba443a7a0d1c8769ff73a723fb3be0f801 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8a5a0ba443a7a0d1c8769ff73a723fb3be0f801 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Append chars instead of Strings in Guid

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Append chars instead of Strings in Guid ...................................................................... core: Append chars instead of Strings in Guid Append '-' instead of "-" as StringBuilder.append(char) has slightly better performance than StringBuilder.append(String). Change-Id: Ib9dacce56a06d92307763c7f9ad5f59723e82e04 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9dacce56a06d92307763c7f9ad5f59723e82e04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: subscribe GetHostsForStorageOperation

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: subscribe GetHostsForStorageOperation ...................................................................... webadmin: subscribe GetHostsForStorageOperation GetHostsForStorageOperationQuery has been introduced in: in Ifd2b1e7882c8527a80c8f340c4b0c363ba0b0f32 StorageModel -> subscribe queries: updated accordingly. Change-Id: Idec8d9c8163a1c393ac729dd4f12d98b1f41acfa Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec8d9c8163a1c393ac729dd4f12d98b1f41acfa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: remove redundant null check in importFileSD

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove redundant null check in importFileSD ...................................................................... webadmin: remove redundant null check in importFileSD importFileStorageAddDomain -> 'sdToAdd' variable can't be null; it's verified in the calling method (importFileStorageConnect). Hence, removing null check since findbugs suspect it as a possible NPE (null shouldn't be passed to StorageDomainManagementParameter ctr). Change-Id: I62eaff9b2ebffccb938f9db646548d61c4169af8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62eaff9b2ebffccb938f9db646548d61c4169af8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: Expose the info about HBA devices in frontend

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: Expose the info about HBA devices in frontend ...................................................................... Expose the info about HBA devices in frontend This patch adds more information to the Host's Hardware Information tab. It shows the list of HBA devices with all associated WWNN and WWPNs. Change-Id: I44efcf1feabb3491aa46bd9294b14424483872c1 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHardwareView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHardwareView.ui.xml 4 files changed, 119 insertions(+), 7 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44efcf1feabb3491aa46bd9294b14424483872c1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Make EngineLock AutoClosable

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Make EngineLock AutoClosable ...................................................................... engine: Make EngineLock AutoClosable Added AutoClosable capability to the EngineLock class, making it work with Java 7 syntax of "try with resources". Change-Id: Ib2f25925481d87a9ea8c73b333eefc0def5eb18a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java 4 files changed, 16 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2f25925481d87a9ea8c73b333eefc0def5eb18a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: backend: Make adding (virtio-)console to virtual machines op...

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Make adding (virtio-)console to virtual machines optional ...................................................................... backend: Make adding (virtio-)console to virtual machines optional This patch makes it possible to control attaching virtio-console for VMs/templates/VMs in pool. The console is a managed device, therefore corresponding device type was added. Also a command for querying DB for console devices was added. Change-Id: I5d913b1fca9d064424aab58d4c34ec3e4b246373 Bug-Url: https://bugzilla.redhat.com/878459 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConsoleDevicesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 20 files changed, 195 insertions(+), 17 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d913b1fca9d064424aab58d4c34ec3e4b246373 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: tools: Fixes password prompt for admin user

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixes password prompt for admin user ...................................................................... tools: Fixes password prompt for admin user Removes misplaced 2nd colon when prompting for admin's password. Change-Id: I35b8e179da5a1689866aa40e9e031c395bbf9873 Bug-Url: https://bugzilla.redhat.com/924603 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35b8e179da5a1689866aa40e9e031c395bbf9873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine-sdk-java[master]: codegen: change password to the default

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: change password to the default ...................................................................... codegen: change password to the default Change-Id: I8a00e93b87fc332afb584729000224636f41f20e Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a00e93b87fc332afb584729000224636f41f20e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years, 5 months

1
0
0 / 0

Change in ovirt-engine-sdk-java[master]: sdk: allow nullifying headers via passing NULL as header val...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: allow nullifying headers via passing NULL as header value ...................................................................... sdk: allow nullifying headers via passing NULL as header value Change-Id: I848b909a57345dcbccceaabed06cc946e1c47e57 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java 1 file changed, 24 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I848b909a57345dcbccceaabed06cc946e1c47e57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2013