Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: engine-check-upgrade: fix quite mode
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: engine-check-upgrade: fix quite mode
......................................................................
packaging: setup: engine-check-upgrade: fix quite mode
pass None as sink to allow default sink handling except of explicit.
Change-Id: Ib7e4cf08e27e5cdd8e545bd672cf930ae1f37444
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/bin/ovirt-engine-upgrade-check
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7e4cf08e27e5cdd8e545bd672cf930ae1f37444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: cleanup util.escape()
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: cleanup util.escape()
......................................................................
packaging: setup: cleanup util.escape()
Change-Id: Ib3ab7f2bd37c1b22235e623ed4dab506fc5d5a57
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/util.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3ab7f2bd37c1b22235e623ed4dab506fc5d5a57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: pki: support '/' in subject name component
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: pki: support '/' in subject name component
......................................................................
pki: support '/' in subject name component
Change-Id: I62ffc2a9209719bc4f7936e2f0dd93a79230cacc
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java
M packaging/setup/plugins/ovirt-engine-rename/core/pki.py
M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py
3 files changed, 44 insertions(+), 12 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62ffc2a9209719bc4f7936e2f0dd93a79230cacc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: rename ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: rename ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY
......................................................................
packaging: setup: rename ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY
all is values... no need to specify that within variable name.
Change-Id: Iadb7696422583545a627aa8756773225a12904c0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadb7696422583545a627aa8756773225a12904c0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: do not use private key when constructing s...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: do not use private key when constructing ssh public
......................................................................
packaging: setup: do not use private key when constructing ssh public
configuration can have ssh-askpass which is in conflict to us.
ssh-keygen of rhel does not have -m PKCS8 so we must construct the
public key format our-selves.
Change-Id: Ia79ea31d259003a880f0a01b6f888fd3e7bc993f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py
1 file changed, 21 insertions(+), 21 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia79ea31d259003a880f0a01b6f888fd3e7bc993f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: print termination message
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: print termination message
......................................................................
packaging: setup: print termination message
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999964
Change-Id: Ia2f27ba721f79606de38b83c04ce33095cf32b0b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/core/misc.py
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2f27ba721f79606de38b83c04ce33095cf32b0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: Fixing restore.sh
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: Fixing restore.sh
......................................................................
Fixing restore.sh
* Fixed return values logic
* Changed if statements to modern bash style
* Added quotes on all variables
* Using tab for indentation
* Using mktemp to create a tpm directory instead of
hardcoded name
Change-Id: I5df0eaf0c18d5d009b1e11c86b35beafecb1b6f0
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M packaging/dbscripts/restore.sh
1 file changed, 98 insertions(+), 96 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5df0eaf0c18d5d009b1e11c86b35beafecb1b6f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: rename stoarge to storage
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: core: rename stoarge to storage
......................................................................
core: rename stoarge to storage
Rename error message name from stoarge to storage.
Renamed in all java and properties files where used.
Change-Id: I61f9a867d4bade3f756a9933dd6f665406c946a0
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18505
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61f9a867d4bade3f756a9933dd6f665406c946a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in error message name
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: core: fix typo in error message name
......................................................................
core: fix typo in error message name
Add missing "t" to "hostname" in error message name.
Change-Id: I2a13b60f0033afbd448b1893956572a27dcf3eda
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a13b60f0033afbd448b1893956572a27dcf3eda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: packaging: spec: add spice-html5 dependency
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: spec: add spice-html5 dependency
......................................................................
packaging: spec: add spice-html5 dependency
Reference-Url: http://www.ovirt.org/Features/SpiceHTML5
Change-Id: Ifa0cbf812c151103267bb6c656b94049b75841ba
Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa0cbf812c151103267bb6c656b94049b75841ba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 4 months