Change in ovirt-engine-sdk-java[master]: sdk: implement AutoCloseable
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: implement AutoCloseable
......................................................................
sdk: implement AutoCloseable
close() method is invoked automatically when API proxy is
managed by the try-with-resources statement
try (Api api = new Api(URL, ...)) {
...
} catch (Exception e) {
...
}
Change-Id: I15786f0f1857c54983602de1f312b234de99bca4
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
2 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Mike Kolesnik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/18538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15786f0f1857c54983602de1f312b234de99bca4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: core: Validate vm nic name has no special characters
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Validate vm nic name has no special characters
......................................................................
core: Validate vm nic name has no special characters
The patch validates the vm nic name is consisted of
a-zA-Z0-9-_. only. This is verified on the UI but
should be enforced when adding nics via the API.
Change-Id: I596f546473b1e4c8832aa56dd56320df514977ae
Bug-Url: https://bugzilla.redhat.com/973971
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNameWithDot.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 43 insertions(+), 6 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/18487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I596f546473b1e4c8832aa56dd56320df514977ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.1.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.1.0
......................................................................
packaging: post ovirt-host-deploy-1.1.0
Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.1.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.1.0
......................................................................
packaging: ovirt-host-deploy-1.1.0
Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
M ovirt-host-deploy.spec.in
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in otopi[master]: packaging: post otopi-1.1.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post otopi-1.1.0
......................................................................
packaging: post otopi-1.1.0
Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in otopi[master]: packaging: otopi-1.1.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: otopi-1.1.0
......................................................................
packaging: otopi-1.1.0
Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
M otopi.spec.in
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in ovirt-host-deploy[master]: java: update package name in pom
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: java: update package name in pom
......................................................................
java: update package name in pom
Change-Id: Ib3d6f09abb670015a9855bea9ff4738cc89d5b36
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/java/pom.xml.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3d6f09abb670015a9855bea9ff4738cc89d5b36
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
10 years, 8 months
Change in ovirt-engine-sdk[master]: sdk: implement support for with-resources statement
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: implement support for with-resources statement
......................................................................
sdk: implement support for with-resources statement
with API(url='', ...) as api:
api...
Change-Id: I7e6f70355e8379cdddefa31d9e77452aa719fe0d
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/codegen/templates/entrypointmethodstemplate
M src/ovirtsdk/api.py
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e6f70355e8379cdddefa31d9e77452aa719fe0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: userportal, webadmin: missing icon error popup
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: userportal,webadmin: missing icon error popup
......................................................................
userportal,webadmin: missing icon error popup
- Fixed missing icon on error popup.
Change-Id: I9e2433ddd498bd08baf1002543098138f66f68a0
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M packaging/branding/ovirt.brand/common.css
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e2433ddd498bd08baf1002543098138f66f68a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: firewalld services cleanup
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: firewalld services cleanup
......................................................................
packaging: setup: firewalld services cleanup
Change-Id: I5c36ee32302a93edabb06f90c12c3caedc9d4129
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-remove/files/simple.py
A packaging/setup/plugins/ovirt-engine-remove/network/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/network/firewalld.py
M packaging/setup/plugins/ovirt-engine-setup/legacy/firewalld.py
5 files changed, 127 insertions(+), 14 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c36ee32302a93edabb06f90c12c3caedc9d4129
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 8 months
