Change in ovirt-engine[master]: core: cleanup in MoveOrCopyDiskCommand
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup in MoveOrCopyDiskCommand
......................................................................
core: cleanup in MoveOrCopyDiskCommand
- simplify canDoAction checks by calling CommandBase#failCanDoAction
- replace if-else statement with ternary if
- rename fields that are used for caching to being with 'cache' prefix
- remove the canDoActionMessages parameter from checkImageConfiguration
method, the messages list is fetched inside the method instead
Change-Id: Id28853bca622bf19ef66c983fa2d7ea38b943fa7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
2 files changed, 35 insertions(+), 50 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id28853bca622bf19ef66c983fa2d7ea38b943fa7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: core: remove addCanDoActionMessage calls to set variable rep...
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove addCanDoActionMessage calls to set variable replacements
......................................................................
core: remove addCanDoActionMessage calls to set variable replacements
Replace calls to addCanDoActionMessage which set variable replacements
in the message with calls to CommandBase#failCanDoAction method that
also gets variable replacements - it makes the code shorter and easier
to read.
Change-Id: Icd48fff9200efab6a2a30c7f03f4aa6b4404ad2f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
2 files changed, 8 insertions(+), 12 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd48fff9200efab6a2a30c7f03f4aa6b4404ad2f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: core: failCanDoAction method with variable replacements
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: failCanDoAction method with variable replacements
......................................................................
core: failCanDoAction method with variable replacements
CommandBase#failCanDoAction can now get additional variable
replacements. That way we don't need to call AddCanDoActionMessage
only to set the variable replacements.
Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: core: Installation fails with message of...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Installation fails with message of...
......................................................................
core: Installation fails with message of...
core: Installation fails with message of "Failed to execute stage
'Misc configuration': Command
'/usr/share/ovirt-engine/dbscripts/create_schema.sh' failed to execute"
In case that clean install is performed on a database that already has
the old uuid implementation , we should remove the old uuid
implementation before attempting to create the new uuid implementation
Change-Id: I4a2d406ff71f312805c8e55c1fe58886c591e1f6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=997370
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/create_schema.sh
M packaging/dbscripts/dbfunctions.sh
2 files changed, 15 insertions(+), 10 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a2d406ff71f312805c8e55c1fe58886c591e1f6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: packaging: setup: process fw templates at validation
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: process fw templates at validation
......................................................................
packaging: setup: process fw templates at validation
Change the event _process_templates of firewall_manager to be run
during validation instead of during customization. Generally
customization is intended for human interaction.
Change-Id: Ib4b1e89c4a263add052f3963929944554e865b71
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/network/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
4 files changed, 8 insertions(+), 16 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4b1e89c4a263add052f3963929944554e865b71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: packaging: setup: firewall-manager - check status
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: firewall-manager - check status
......................................................................
packaging: setup: firewall-manager - check status
During setup, ask only about firewall managers that are both enabled
and active.
Currently this means that if both firewalld and iptables are enabled,
but iptables is active and firewalld isn't, first we ask about firewalld,
and if users accepts, we do not even ask about iptables. With this
change, at this state, we only ask about iptables.
Change-Id: Ice741b9738c822d48ab3719dd34cbe989b359afe
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice741b9738c822d48ab3719dd34cbe989b359afe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: webadmin: add status image column to bricks tab
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: add status image column to bricks tab
......................................................................
webadmin: add status image column to bricks tab
Added a status image colume to bricks subtab. Removed the
existing status text column from the table.
Change-Id: Ibbf48deb409f7dee046b9844b545f8355d5c042b
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusCell.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusColumn.java
3 files changed, 78 insertions(+), 12 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbf48deb409f7dee046b9844b545f8355d5c042b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: engine : Null Pointer Exception for action CreateAllSnapshot...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................
engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot
After a failure in create snapshot, engine enters into
a loop with NullPointerException. This patch fixes the
case where the vdsm was restarted after submission of the
command and the entry in snapshots table was cleared by engine
leading to NPE in CreateAllSnapshotsFromVmCommand.
Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Bug-Url: https://bugzilla.redhat.com/982003
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: packaging: setup: Do not skip over fedora files
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: Do not skip over fedora files
......................................................................
packaging: setup: Do not skip over fedora files
Now that http://gerrit.ovirt.org/17204 was merged, no need to not
check fedora files...
Change-Id: I4e558c0f05d7c220670062306ae0bfcca5eb9e0f
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/check.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e558c0f05d7c220670062306ae0bfcca5eb9e0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Prevent implicit usage of port mirroring
......................................................................
engine: Prevent implicit usage of port mirroring
The patch denies attempt of an imported vm to use
a vnic profile by the imported vnic if the vm or
template haven't explicitly stated that the exact
vnic profile to be used.
Change-Id: I4f47627642d38fd537dbeed8f1b41a0849566063
Bug-Url: https://bugzilla.redhat.com/1001068
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f47627642d38fd537dbeed8f1b41a0849566063
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months