August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: remove migration domain filter
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: remove migration domain filter ...................................................................... core: scheduling: remove migration domain filter Currently there is on way to migrate a vm between clusters, therefore migration domain filter is causing a problem when it's not enabled. This patch removes the filter, and added it's logic (up state and same cluster) to the initial host list provided to the filters. This patch also includes that balancing initial hosts list to be hosts without migrating vms to allow backward compatability. Change-Id: I5aea1d3d1e5e63f03ab0d012d4d3fe9356f26e48 Bug-Url: https://bugzilla.redhat.com/988306 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MigrationDomainPolicyUnit.java A packaging/dbscripts/upgrade/03_03_0680_remove_migration_domain_filter.sql 5 files changed, 17 insertions(+), 55 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aea1d3d1e5e63f03ab0d012d4d3fe9356f26e48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: show notification of disabled policy unit
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: show notification of disabled policy unit ...................................................................... webadmin: show notification of disabled policy unit When the external scheduler doesn't load an already loaded plugin, the ui will show notification foreach one, with disabled caption and graying it out. Change-Id: Ia9f33eb9305ca639d15717362f0590cb8445d13a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/FunctionPolicyUnitPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java 4 files changed, 29 insertions(+), 9 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f33eb9305ca639d15717362f0590cb8445d13a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: handle external scheduler failure
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: handle external scheduler failure ...................................................................... core: scheduling: handle external scheduler failure in case the external scheduler fails, continue with scheduling process, 'skipping' external scheduler (no) results Change-Id: I11cc70260e99cee7c563cb727274608e325da354 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java 2 files changed, 8 insertions(+), 18 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11cc70260e99cee7c563cb727274608e325da354 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: don't run externl scheduler on !empty data
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: don't run externl scheduler on !empty data ...................................................................... core: scheduling: don't run externl scheduler on !empty data * Cluster policy contains external filters or weight modules. * All hosts filtered out in internal filtering. Change-Id: Ib77bb37590153802939bc1e2d2a9a5ee198fbce6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib77bb37590153802939bc1e2d2a9a5ee198fbce6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: scheduling: indication for external plugin
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: scheduling: indication for external plugin ...................................................................... webadmin: scheduling: indication for external plugin the text '(EXT)' will be added next to each module that is loaded by the external proxy. Change-Id: Ica7522ed5a46012c3c1205044c57723d4067aa11 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/FunctionPolicyUnitPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java 5 files changed, 42 insertions(+), 7 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica7522ed5a46012c3c1205044c57723d4067aa11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: searchbackend: search host by id
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: searchbackend: search host by id ...................................................................... engine: searchbackend: search host by id 'id' isn't propmpt in the ui search bar, but is acceptable. Change-Id: I070a9eb4dece9973456f0233bf4dde2dbf7846ac Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070a9eb4dece9973456f0233bf4dde2dbf7846ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: cluster policy: adding description and info icons
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: cluster policy: adding description and info icons ...................................................................... engine: cluster policy: adding description and info icons * A description field is added to each pre-defined policy unit. * A description will be shown in a tool-tip foreach policy unit in cluster policy dialog, as well as info icon explaining the various section in the dialog. Change-Id: Ib51cf7f15b7d73c87e0c728953171584216e1d00 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PolicyUnitDaoTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java M packaging/dbscripts/policy_unit_sp.sql A packaging/dbscripts/upgrade/03_03_0670_add_description_to_policy_unit.sql 11 files changed, 169 insertions(+), 7 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib51cf7f15b7d73c87e0c728953171584216e1d00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: separate policy unit per class
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduler: separate policy unit per class ...................................................................... core: scheduler: separate policy unit per class Each policy unit should implement a single file so None, EvenDistribution and PowerSaving policy units will be divided into two policy units, weight and balance. Change-Id: Id25cd653246e14a109b08d91adfb12ceccc505b4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnit.java 7 files changed, 158 insertions(+), 79 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25cd653246e14a109b08d91adfb12ceccc505b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: pre-defined weight modules
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: pre-defined weight modules ...................................................................... core: pre-defined weight modules To be compatible with former scheduler. * none -> should use evenly distributed * even distribution -> weight will be calculated according to cpuLoad, is_spm (config), avg vm consumtions (config), vm's cpu count and host core count. * power saving -> host with no vm will be less likely to be selected, other hosts will be sorted (desc) by even distribution logic. Change-Id: I55cf5014bc472bf1e126a9737829e7fcf7e21853 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NonePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 8 files changed, 61 insertions(+), 12 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55cf5014bc472bf1e126a9737829e7fcf7e21853 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: add response timeout
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: add response timeout ...................................................................... engine: add response timeout Make response timeout configurable for the external scheduler Change-Id: Ia16e36f6a964a406750bff4a738f4c6d9a1655fa Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 9 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia16e36f6a964a406750bff4a738f4c6d9a1655fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0