Change in ovirt-engine[master]: core: fix attacch to attach
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix attacch to attach
......................................................................
core: fix attacch to attach
Fixed typo in 2 error message names.
Change-Id: Id8b58c03262196b90611a9bd56bede0e15afd8a5
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8b58c03262196b90611a9bd56bede0e15afd8a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-engine[master]: engine: Ties more consistently between vm nic device and vm ...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Ties more consistently between vm nic device and vm nic entities.
......................................................................
engine: Ties more consistently between vm nic device and vm nic entities.
Fixes copy of vm nic devices in the same way the
http://gerrit.ovirt.org/#/c/17854/ fixes the copy of disk devices.
Change-Id: Iee9267ade386ab83a6c353b4206f4dfe003f24bc
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
4 files changed, 30 insertions(+), 34 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18362
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee9267ade386ab83a6c353b4206f4dfe003f24bc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 4 months
Change in ovirt-host-deploy[master]: packages: vdsm: vdsm-tool was introduced later than oldest s...
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packages: vdsm: vdsm-tool was introduced later than oldest supported vdsm
......................................................................
packages: vdsm: vdsm-tool was introduced later than oldest supported vdsm
Change-Id: If9c402382292300cda586792669233c95f4f9ec3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vdsm/packages.py
1 file changed, 17 insertions(+), 7 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9c402382292300cda586792669233c95f4f9ec3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[ovirt-engine-3.3]: userportal: Fix nasty issue in MenuPanelPopup
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Fix nasty issue in MenuPanelPopup
......................................................................
userportal: Fix nasty issue in MenuPanelPopup
When running UserPortal in web (compiled) mode, a very
nasty issue occurs in MenuPanelPopup constructor. This
issue occurs *only* in web mode and causes UserPortal
login screen to hang after successful authentication.
JS stacktrace points to MenuPanelPopup using UiBinder:
- UiBinder-generated code does SimplePanel.add(widget)
as per <g:SimplePanel> in MenuPanelPopup.ui.xml
- for some reason, 'widget' is an instance of
DecoratedPopupPanel, instead of expected PopupPanel
- JS TypeError occurs with following message:
DecoratedPopupPanel.decPanel field is not initialized
This patch fixes this issue by removing UiBinder usage
from MenuPanelPopup. This isn't a big deal, since
MenuPanelPopup uses UiBinder *only* to apply CSS styles,
its widgets are declared using @UiField(provided=true).
Change-Id: Ic3f9c3318234bb5315f950c0cba44e6eaa8cb24f
Bug-Url: https://bugzilla.redhat.com/992960
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/MenuPanelPopup.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/MenuPanelPopup.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/MenuPanelPopup.css
3 files changed, 52 insertions(+), 50 deletions(-)
Approvals:
Alexander Wels: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3f9c3318234bb5315f950c0cba44e6eaa8cb24f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years, 5 months
Change in ovirt-engine[master]: restapi: add ReadOnlyResource
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: add ReadOnlyResource
......................................................................
restapi: add ReadOnlyResource
Change-Id: Ic77b92b0e696e8ad0a0095006772320ac2f0600a
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ReadOnlyResources.java
2 files changed, 77 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic77b92b0e696e8ad0a0095006772320ac2f0600a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: add GetImageByIdQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: add GetImageByIdQuery
......................................................................
core: add GetImageByIdQuery
Change-Id: I53f05023301df81fc66d4ff36bc98369ae15a3f7
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImageByIdQuery.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
4 files changed, 70 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53f05023301df81fc66d4ff36bc98369ae15a3f7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: restapi: image entity and import from glance
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: image entity and import from glance
......................................................................
restapi: image entity and import from glance
This patch adds an initial implementation for the REST API commands to
import and export images from and to image storage domains (as OpenStack
Glance).
The API at the moment has to be intended as Technology Preview and it
might be subject to changes in the future.
Glance integration feature page:
http://www.ovirt.org/Features/Glance_Integration
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990962
Change-Id: Ief9104ff0eba175c90b42bc5651ada0f688eeb00
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ImageResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ImagesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ImageMapper.java
15 files changed, 525 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief9104ff0eba175c90b42bc5651ada0f688eeb00
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: Suggest bond name when creating new bond
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Suggest bond name when creating new bond
......................................................................
webadmin: Suggest bond name when creating new bond
Ever since the user has been able to create new bonds from the engine,
the default suggest bond name was "bond" to show all existing bond
names upon focus. Now a valid bond name is suggested instead.
Change-Id: I059a02cca35c91bdf4c44ffbdfa88326fe20ee2f
Bug-Url: https://bugzilla.redhat.com/988425
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java
2 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I059a02cca35c91bdf4c44ffbdfa88326fe20ee2f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: Changed "Assign/Unassign" to "Manage"
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Changed "Assign/Unassign" to "Manage"
......................................................................
webadmin: Changed "Assign/Unassign" to "Manage"
The dialog lets the user do more than just assign/unassign, so changed
the wording as well.
Change-Id: Id5b8380c72c4c225260f838a4e7e23228adcf542
Bug-Url: https://bugzilla.redhat.com/980066
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5b8380c72c4c225260f838a4e7e23228adcf542
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: enforce authentication when using foreman provider
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: enforce authentication when using foreman provider
......................................................................
webadmin: enforce authentication when using foreman provider
Change-Id: Ibdef39198da0842dc55afebe96e09097bf2f9390
Bug-Url: https://bugzilla.redhat.com/987993
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdef39198da0842dc55afebe96e09097bf2f9390
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months