August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Created EntityModelWidgetWithInfo widget
by masayag＠redhat.com 21 Aug '13

21 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Created EntityModelWidgetWithInfo widget ...................................................................... webadmin: Created EntityModelWidgetWithInfo widget Refactored some code implemented for NeutronAgentWidget into the reusable EntityModelWidgetWithInfo widget, which comprises a label, info icon and text box, whose layout I've been able to arrange reasonably well. Change-Id: I5cc54996bcd25062cb929d59b257688adf431126 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/NeutronAgentWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/NeutronAgentWidget.ui.xml 4 files changed, 82 insertions(+), 33 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc54996bcd25062cb929d59b257688adf431126 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: support non-standard SSH port
by sbonazzo＠redhat.com 21 Aug '13

21 Aug '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: support non-standard SSH port ...................................................................... packaging: setup: support non-standard SSH port Automatically detect the port used by SSH daemon supporting non-standard SSH port. The detected port can be manually overridden setting OVEHOSTED_NETWORK/sshdPort. Change-Id: Ic3b1264290d7e98d1d84ac2546a078f8941ecf47 Related-To: http://gerrit.ovirt.org/18174 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/system/sshd.py 3 files changed, 45 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3b1264290d7e98d1d84ac2546a078f8941ecf47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: use public key for ssh authentication
by sbonazzo＠redhat.com 21 Aug '13

21 Aug '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: use public key for ssh authentication ...................................................................... packaging: setup: use public key for ssh authentication Use public key for ssh authentication instead of root password wich is now a deprecated authentication method. Require sdk >= 3.3.0.4 for having API support. Related-To: http://gerrit.ovirt.org/18002 Change-Id: I4ba78d92d961fe763208f10a725876a4c081a70f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/system/Makefile.am M src/plugins/ovirt-hosted-engine-setup/system/__init__.py D src/plugins/ovirt-hosted-engine-setup/system/super_user.py 6 files changed, 48 insertions(+), 132 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba78d92d961fe763208f10a725876a4c081a70f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: doc: adding man pages
by sbonazzo＠redhat.com 21 Aug '13

21 Aug '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: doc: adding man pages ...................................................................... doc: adding man pages Adding minimal man pages. Change-Id: I58f3e0420cbb9cc93821f65c0935b83a6c12f8bf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M README M configure.ac A man/Makefile.am A man/hosted-engine.8 A man/ovirt-hosted-engine-setup.8 M ovirt-hosted-engine-setup.spec.in 7 files changed, 109 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58f3e0420cbb9cc93821f65c0935b83a6c12f8bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Timothy Hildred <thildred(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: UX: add --console to --help output
by sbonazzo＠redhat.com 21 Aug '13

21 Aug '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: add --console to --help output ...................................................................... UX: add --console to --help output Added missing --console option description to --help output. Change-Id: I997870caddf2cf12e9caf6185c4d6c924abe02ed Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I997870caddf2cf12e9caf6185c4d6c924abe02ed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix typo in error message name
by amureini＠redhat.com 21 Aug '13

21 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix typo in error message name ...................................................................... core: fix typo in error message name Add missing "t" to "hostname" in error message name. Change-Id: I2a13b60f0033afbd448b1893956572a27dcf3eda Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a13b60f0033afbd448b1893956572a27dcf3eda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename stoarge to storage
by amureini＠redhat.com 21 Aug '13

21 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename stoarge to storage ...................................................................... core: rename stoarge to storage Rename error message name from stoarge to storage. Renamed in all java and properties files where used. Change-Id: I61f9a867d4bade3f756a9933dd6f665406c946a0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61f9a867d4bade3f756a9933dd6f665406c946a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixing validation of Auth Ssh Port
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fixing validation of Auth Ssh Port ...................................................................... webadmin: Fixing validation of Auth Ssh Port The field's validation was set but without using the getIsValid as part of the general tab validation. Clicking OK forwarded the user to PM page instead of failing the operation. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987910 Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Limit usage of Local ISO SD to Local DC
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: engine,webadmin: Limit usage of Local ISO SD to Local DC ...................................................................... engine,webadmin: Limit usage of Local ISO SD to Local DC Using ISO Storage Domain which is local to one host in the multihost environment can create issues because this SD is not visible by other hosts, therefore there is a decision to limit its usage to single host environment. Change-Id: I4cfc3bb68581664fa6729e5cb8a163324e7fbc29 Bug-Url: https://bugzilla.redhat.com/993111 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 4 files changed, 84 insertions(+), 35 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/18229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cfc3bb68581664fa6729e5cb8a163324e7fbc29 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: identify user roles using enum values
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: frontend: identify user roles using enum values ...................................................................... frontend: identify user roles using enum values Additional ActionGroups now returned by getUserActionGroups: CONSUME_QUOTA ActionGroups that now are no longer returned by getUserActionGroups: CHANGE_VM_CUSTOM_PROPERTIES EDIT_ADMIN_VM_PROPERTIES EDIT_ADMIN_TEMPLATE_PROPERTIES Change-Id: I2de0478fc80952c9a5816bd58a1d000df77a6681 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 3 insertions(+), 53 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2de0478fc80952c9a5816bd58a1d000df77a6681 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0