August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: filtering hosts on remove storage dialog
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: filtering hosts on remove storage dialog ...................................................................... webadmin: filtering hosts on remove storage dialog Using GetHostsForStorageOperation query (introduced in [1]) for filtering hosts on remove storage domain dialog. [1] http://gerrit.ovirt.org/15397 Change-Id: I5ef16a5972450ebf5f1659524535aaa7f26ee502 Bug-Url: https://bugzilla.redhat.com/991081 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef16a5972450ebf5f1659524535aaa7f26ee502 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: configure local storage - fixed path style
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: configure local storage - fixed path style ...................................................................... webadmin: configure local storage - fixed path style Fixed path style in configure local storage dialog: the label and the editor are now aligned (instead of a separate label, used the one inside EntityModelTextBoxEditor). Change-Id: I13a52112cbc7b80eb56617412af2f1364f38b1cc Bug-Url: https://bugzilla.redhat.com/996931 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13a52112cbc7b80eb56617412af2f1364f38b1cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Blocking port field in edit host popup and refacto...
by derez＠redhat.com 21 Aug '13

21 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Blocking port field in edit host popup and refactor its name ...................................................................... webadmin: Blocking port field in edit host popup and refactor its name Was a bug, before we locked the vdsm port (54321) field, instead of the auth port. To avoid such confusions this patch also modifies the name of the field from hostPort to authSshPort. Change-Id: Ic2af8e3168d7ac9688079f6a32edc71d79f997b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=997542 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 8 files changed, 24 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2af8e3168d7ac9688079f6a32edc71d79f997b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove disk when force remove domain
by mlipchuk＠redhat.com 21 Aug '13

21 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove disk when force remove domain ...................................................................... core: Remove disk when force remove domain When force remove domain or storage pool, the disks and the permissions are left in the DB tables. the proposed fix deletes those disks and permissions from the DB as part of the force remove stored procedure. Change-Id: Ic848c26771822a0c3283d6184a54ed9ea229a9cd Bug-Url: https://bugzilla.redhat.com/982527 Bug-Url: https://bugzilla.redhat.com/892642 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java M packaging/dbscripts/storages_sp.sql 2 files changed, 18 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic848c26771822a0c3283d6184a54ed9ea229a9cd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix fixtures tests
by mlipchuk＠redhat.com 21 Aug '13

21 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix fixtures tests ...................................................................... core: Fix fixtures tests disk id 1b26a52b-b60f-44cb-9f46-3ef333b04a35 has rows in images table therefore it could not be also in disk_lun_map. Adding a new id for new lun disk instead of the old one Change-Id: I58b8bbad985ffe236a3b1a58a465a260477b84a8 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 6 files changed, 42 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58b8bbad985ffe236a3b1a58a465a260477b84a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Force remove storage leaves VM permissions.
by mlipchuk＠redhat.com 21 Aug '13

21 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Force remove storage leaves VM permissions. ...................................................................... core: Force remove storage leaves VM permissions. Remove of VM will not remove its permissions, since before the remove of the permissions we remove the image from image_storage_domain_map which vm_images_view is based on, and therefore it will not fetch this image. The proposed fix is to create a temporary table which will contains the vm ids and will not influenced by former operations. Change-Id: I7445f9ba7c08936e66cab0b043f4dbaaa483e482 Bug-Url: https://bugzilla.redhat.com/999048 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/storages_sp.sql 1 file changed, 24 insertions(+), 18 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7445f9ba7c08936e66cab0b043f4dbaaa483e482 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin : changed create volume to new volume
by kmayilsa＠redhat.com 21 Aug '13

21 Aug '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : changed create volume to new volume ...................................................................... webadmin : changed create volume to new volume Renamed action, create volume as new and its popup title to new volume Change-Id: Ib32adbb4c0c59c5e30bc1d22c3c42d40c47cca0b Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 5 files changed, 18 insertions(+), 18 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib32adbb4c0c59c5e30bc1d22c3c42d40c47cca0b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engien: test for ClusterPolicyCRUDCommandTest
by lhornyak＠redhat.com 21 Aug '13

21 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engien: test for ClusterPolicyCRUDCommandTest ...................................................................... engien: test for ClusterPolicyCRUDCommandTest test for ClusterPolicyCRUDCommandTest Change-Id: I9b370e4cc0a43645961b7693310695110f7f8281 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommandTest.java 1 file changed, 55 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b370e4cc0a43645961b7693310695110f7f8281 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: EditClusterPolicyCommand simplification
by lhornyak＠redhat.com 21 Aug '13

21 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: EditClusterPolicyCommand simplification ...................................................................... engine: EditClusterPolicyCommand simplification EditClusterPolicyCommand canDoAction simplification Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: AddClusterPolicyCommand canDoAction simplification
by lhornyak＠redhat.com 21 Aug '13

21 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: AddClusterPolicyCommand canDoAction simplification ...................................................................... engine: AddClusterPolicyCommand canDoAction simplification AddClusterPolicyCommand canDoAction simplification Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0