August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-scheduler-proxy[master]: packaging fix
by lhornyak＠redhat.com 14 Aug '13

14 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: packaging fix ...................................................................... packaging fix executor test case is broken after packaging Change-Id: Ia2c9b42c6c15736bc9cbf45cc204fbd427a54cc5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M src/ovirtscheduler/request_handler_test.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c9b42c6c15736bc9cbf45cc204fbd427a54cc5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Ties more consistently between vm disk device and di...
by amureini＠redhat.com 14 Aug '13

14 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Ties more consistently between vm disk device and disk entities. ...................................................................... engine: Ties more consistently between vm disk device and disk entities. VmDevice is the model entity on the Engine that ties between VM and the disk attached to this VM. Disk is not the only entity which tied to VM by VmDevice, but the only to be affected by this patch. VmDevice keeps a few very important characteristics of the underlying disk, for example address which ties the disk to specific slot of the controller. Without that information or if this information is not consistent disk may become useless after being introduced to the VM. During creating VM from a template with Disks A and B. Disk A => Disk A' Disk B => Disk B' So, if VMDevice A ties between Disk A and Template then VmDevice A' should tie between newly created VM and Disk A'. This patch make this process more consistent as till now, Engine was up to the order of disks in the Map or List as they were retrieved from UI or Database. Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1 Bug-Url: https://bugzilla.redhat.com/993776 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 6 files changed, 49 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: fix: fix filter results aggregation
by lhornyak＠redhat.com 14 Aug '13

14 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: fix: fix filter results aggregation ...................................................................... fix: fix filter results aggregation In some cases the filter runner returns None, this should be tolerated by the aggregator Change-Id: If573af7c244056ddc6bd15eb1cc8adede4849b9f Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M Makefile M src/ovirtscheduler/request_handler.py M src/ovirtscheduler/request_handler_test.py 3 files changed, 42 insertions(+), 12 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If573af7c244056ddc6bd15eb1cc8adede4849b9f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: sanlock lockspace init
by sbonazzo＠redhat.com 14 Aug '13

14 Aug '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: sanlock lockspace init ...................................................................... packaging: setup: sanlock lockspace init Added sanlock lockspace initialization. Code adapted from http://gerrit.ovirt.org/#/c/17609/1/ovirt_hosted_engine_ha/agent/hosted_eng… Requiring sanlock >= 2.8 Change-Id: Ife56590bf3e6c17368a24ef8e9af6d42adc5ea42 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/Makefile.am A src/plugins/ovirt-hosted-engine-setup/sanlock/Makefile.am A src/plugins/ovirt-hosted-engine-setup/sanlock/__init__.py A src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py 8 files changed, 263 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife56590bf3e6c17368a24ef8e9af6d42adc5ea42 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: pre processing for search-generated ldap filters
by yzaslavs＠redhat.com 14 Aug '13

14 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: pre processing for search-generated ldap filters ...................................................................... core: pre processing for search-generated ldap filters The search generates a uniform ldap uery in format that contains upper case keys with $ sign before them - for example ($PRINCIPAL_NAME=a(a)ovirt.org) In case of open ldap and RHDS, principal name (i.e - user@domain) should not be passed to the ldap server as the ldap query that is being generated uses the "uid" attribute which is based on user name and not UPN. Furthermore, at least some of the versions of RHDS, and open ldap do not contain support for UPN upon out of the box installation. Instead of passing the UPN to the query, it should be split, and the ldap query should be run with a filter that contains only the user part. Change-Id: I35744eb423ca7f553bf7e9b20c72179bca4e6827 Bug-Url: https://bugzilla.redhat.com/991800 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapFilterSearchEnginePreProcessor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/NoOpLdapFilterSearchEnginePreProcessor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SearchQueryFotmatter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UpnSplitterLdapFilterSearchEnginePreProcessor.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/LdapFilterSearchEnginePreProcessorTest.java 6 files changed, 92 insertions(+), 11 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35744eb423ca7f553bf7e9b20c72179bca4e6827 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Set gateway for any network
by masayag＠redhat.com 14 Aug '13

14 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Set gateway for any network ...................................................................... engine: Set gateway for any network If a cluster supports multiple gateways, any network should have its gateway set according to the capabilities reported by VDSM. Change-Id: Ie6af773b35276371826104df3a8bb2115d39f383 Bug-Url: https://bugzilla.redhat.com/995011 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6af773b35276371826104df3a8bb2115d39f383 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Unable to search on domain for users with some search ...
by yzaslavs＠redhat.com 14 Aug '13

14 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Unable to search on domain for users with some search options. ...................................................................... core: Unable to search on domain for users with some search options. Search failed, when try to search user on domain with special keyword. This happens when user search by lastname, department and title. Fix for IPA, OpenLDAP and RHDS Change-Id: I351a8c0e3341a6f975efec210398267aa828c3e0 Bug-Url: https://bugzilla.redhat.com/975380 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I351a8c0e3341a6f975efec210398267aa828c3e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: search fix for storage pool
by dfediuck＠redhat.com 14 Aug '13

14 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: search fix for storage pool ...................................................................... engine: search fix for storage pool The database field is called 'free_text_comment', not 'comment' Change-Id: I7a8e17380c4e4079c22260af2202daf1db97aa24 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8e17380c4e4079c22260af2202daf1db97aa24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixes logging in SshSoftFencingCommand
by yzaslavs＠redhat.com 14 Aug '13

14 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixes logging in SshSoftFencingCommand ...................................................................... core: Fixes logging in SshSoftFencingCommand 1) Reverts logging command output in SshSoftFencingCommand erroneously committed in 52716e7498675d71654787eec21956fd30d38edf. 2) Adds logging of command error output Change-Id: I6ea12003bd44f6500e3878176e98debd102da056 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ea12003bd44f6500e3878176e98debd102da056 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: typo fix
by lhornyak＠redhat.com 14 Aug '13

14 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: typo fix ...................................................................... typo fix Lesson for vim users Change-Id: I37034f1a0d47a365136b7187f4329d023ea78f8e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M src/ovirtscheduler/oschedproxyd.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37034f1a0d47a365136b7187f4329d023ea78f8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0