August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Always use IPv4 for AJP
by oschreib＠redhat.com 15 Aug '13

15 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: core: Always use IPv4 for AJP ...................................................................... core: Always use IPv4 for AJP Currently in the Apache configuration that we use for the connection to the application server we use "localhost" as the address of the AJP connector. This host name is usually translated to both the IPv6 ::1 address and the IPv4 127.0.0.1 address, and it looks like Apache always tries first with the IPv6 address. But the application server doesn't listen in the IPv6 address, only in the IPv4 address. This means that the first attempt to connect is always rejected. Not a big issue, as the web server retries inmediatelly with the IPv4 address, but this generates an unnecessary roundtrip. This patch replaces "localhost" with "127.0.0.1" so that the web server will always use IPv4. Change-Id: I36ef2de20236f509b16b5bb7112d0f849e8e96e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ef2de20236f509b16b5bb7112d0f849e8e96e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix class cast exception
by oourfali＠redhat.com 15 Aug '13

15 Aug '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix class cast exception ...................................................................... core: fix class cast exception This patch checks whether the mem size and CPU cores are integers or strings, as it was changed recently in VDSM. Change-Id: Ie35ada2685d71c6b295e3f39811d3f592d690fb3 Bug-Url: https://bugzilla.redhat.com/997401 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie35ada2685d71c6b295e3f39811d3f592d690fb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: replace engine-config man
by oschreib＠redhat.com 15 Aug '13

15 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: replace engine-config man ...................................................................... packaging: spec: replace engine-config man it is possible to do so as we move out of setup into newer package that is optionally versionlocked. Change-Id: I92d4358790ee9d461bf1a8eeab9ae385965a86ac Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92d4358790ee9d461bf1a8eeab9ae385965a86ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-scheduler-proxy[master]: Improve logging
by lhornyak＠redhat.com 15 Aug '13

15 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: Improve logging ...................................................................... Improve logging Added logging at key workflow points Improved exception handling regarding logging Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Change-Id: I1e5fb885acdfb6f99e10c7fc97032e65878b0dd7 --- M plugins/dummy.py M src/ovirtscheduler/loader.py M src/ovirtscheduler/request_handler.py M src/ovirtscheduler/request_handler_test.py M src/ovirtscheduler/runner.py M src/ovirtscheduler/utils.py M tests/java/src/test/java/org/ovirt/schedulerproxy/SchedulerProxyTest.java 7 files changed, 72 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e5fb885acdfb6f99e10c7fc97032e65878b0dd7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log set VM ticket event
by ofrenkel＠redhat.com 15 Aug '13

15 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: log set VM ticket event ...................................................................... core: log set VM ticket event Log the set VM ticket event. Change-Id: I61308fdd59d0d11b045a8e1ed72648c85f039701 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/886788 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61308fdd59d0d11b045a8e1ed72648c85f039701 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix serialization issue with vmTemplate
by ofrenkel＠redhat.com 15 Aug '13

15 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix serialization issue with vmTemplate ...................................................................... core: fix serialization issue with vmTemplate also sanitize the method names Change-Id: I7689acb65594994a553e79c2c18558f98824f285 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/TemplatesTree.java 16 files changed, 27 insertions(+), 27 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7689acb65594994a553e79c2c18558f98824f285 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: fix tests and pep8 errors
by dfediuck＠redhat.com 15 Aug '13

15 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: fix tests and pep8 errors ...................................................................... fix tests and pep8 errors Fixes pep8 violations and test errors Change-Id: I381b3fd8ab4c5db55cd4a1c5ae00e21511c41269 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M src/ovirtscheduler/loader.py M src/ovirtscheduler/request_handler.py M src/ovirtscheduler/request_handler_test.py M src/ovirtscheduler/runner.py M tests/java/src/test/java/org/ovirt/schedulerproxy/SchedulerProxyTest.java 5 files changed, 22 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified Doron Fediuck: Looks good to me, approved Noam Slomianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I381b3fd8ab4c5db55cd4a1c5ae00e21511c41269 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: make VdcQueryReturnValue#getReturnValue generic
by ofrenkel＠redhat.com 15 Aug '13

15 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: make VdcQueryReturnValue#getReturnValue generic ...................................................................... core: make VdcQueryReturnValue#getReturnValue generic VdcQueryReturnValue#getReturnValue method wasn't generic, so we needed to have explicit casting which required @SuppressWarnings("unchecked") annotation which makes the code dirty or add unchecked warning if the annotation is missing. This patch changes this method to be generic, and the returned object is casted to the returned type of the method - this way the annotation appears only within this method and the rest of the code is cleaner. In this patch I changed the classes within org.ovirt.engine.core.bll package to take advantage of this change. Latter patches should change the rest of the classes, and do the same change in VDSReturnValue#getReturnValue. This patch also contains minor refactoring in VdcQueryReturnValue: 1. remove '_' prefix from class fields 2. move the constructor to be before the other class methods Change-Id: I57b6ce5fc4b5d6bab1481f9bfb9d7861ba09a615 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue.java 14 files changed, 29 insertions(+), 34 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57b6ce5fc4b5d6bab1481f9bfb9d7861ba09a615 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: resatpi: Partial Cluster Version Causes NPE
by mpastern＠redhat.com 15 Aug '13

15 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: resatpi: Partial Cluster Version Causes NPE ...................................................................... resatpi: Partial Cluster Version Causes NPE When creating a new cluster, providing only major or minor fields of the version (not both) will cause crash Change-Id: Iabc59e204a9f5bd37d6e2b41e5377aeb10d6e184 Bug-Url: https://bugzilla.redhat.com/988067 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabc59e204a9f5bd37d6e2b41e5377aeb10d6e184 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPE in VdsUpdateRunTimeInfo
by oourfali＠redhat.com 15 Aug '13

15 Aug '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix NPE in VdsUpdateRunTimeInfo ...................................................................... core: fix NPE in VdsUpdateRunTimeInfo When a disk reported by VDSM doesn't exist in the engine, it causes NPE when updating the disk statistics. Fixing it to check first if the returned DB disk is null. Change-Id: I9a3a02485766253fa63eb3260f60b83899bfd317 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a3a02485766253fa63eb3260f60b83899bfd317 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0