Change in otopi[master]: core: config: fix [environment:default] handling
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: config: fix [environment:default] handling
......................................................................
core: config: fix [environment:default] handling
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990518
Change-Id: Iab14facc70580c246b34448e42aa62fbd8e1273d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/core/config.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab14facc70580c246b34448e42aa62fbd8e1273d
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 5 months
Change in ovirt-engine-sdk[master]: codegen: remove leading and trailing spaces in collectionlis...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: remove leading and trailing spaces in collectionlist template
......................................................................
codegen: remove leading and trailing spaces in collectionlist template
Change-Id: I49abdb41c2f8e5995fefb28455a8dea38e271ffc
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/codegen/templates/collectionlistnotsearchabletemplate
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49abdb41c2f8e5995fefb28455a8dea38e271ffc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: restapi: prevent NPE in rsdl gen when missing body params
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: prevent NPE in rsdl gen when missing body params
......................................................................
restapi: prevent NPE in rsdl gen when missing body params
Change-Id: Id3fff227bb3dc21da16953f1aa1dfaeed5cd4709
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3fff227bb3dc21da16953f1aa1dfaeed5cd4709
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: restapi: add missing fields in the storageconnections.delete...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add missing fields in the storageconnections.delete() sig.
......................................................................
restapi: add missing fields in the storageconnections.delete() sig.
Change-Id: I79caba8610bfa2e33e5e171a00515de7ce889f1f
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79caba8610bfa2e33e5e171a00515de7ce889f1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: services: ovirt-engine: dump memory on OutOfMemor...
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: services: ovirt-engine: dump memory on OutOfMemoryError is now default
......................................................................
packaging: services: ovirt-engine: dump memory on OutOfMemoryError is now default
Change the default param of JBoss so that if the engine crash on OutOfMemory,
a dump file will be created, under the LOG/dump directory.
Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/sys-etc/logrotate.d/ovirt-engine.in
4 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2690bd371847561717a38410b4431f5e0edb185
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core, restapi: Introducing ImportVmFromConfigurationCommand
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core, restapi: Introducing ImportVmFromConfigurationCommand
......................................................................
core, restapi: Introducing ImportVmFromConfigurationCommand
ImportVmFromConfigurationCommand is used for adding a vm to the engine
with a configuration specified in an ovf file.
The command adds the vm and related devices as specified in the given
configuration and then attempts to attach to the vm the related disks.
*The user can override the vm parameters set in the ovf by explicitly
including overriding value in the REST call (take a look in the example
below).
Usage example:
POST to:
http://server:port/api/vms/
(include Content-Type:application/xml header)
<vm>
<cluster><name>cluster_name</name></cluster>
<initialization><configuration><type>ovf</type>
<data><![CDATA[
]]>
</data></configuration></initialization>
<name>OVERRIDING_NAME</name>
</vm>
*The OVF configuration should be passed within CDATA block or after
escaping to prevent error in the parsing of the request.
Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ConfigurationType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ConfigurationType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ConfigurationValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
26 files changed, 538 insertions(+), 44 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: A Burden <aburden(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-hosted-engine-setup[master]: pki: fix spice pki certificate parsing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pki: fix spice pki certificate parsing
......................................................................
pki: fix spice pki certificate parsing
fixed spice pki certificate parsing and moved it
to validation stage for having the correct certificate
subject in the answer file.
Change-Id: I0188e3f27008c989f6c0ff7de7fa47215fc32466
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0188e3f27008c989f6c0ff7de7fa47215fc32466
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: frontend: mouse selection of ListModelTypeAheadListBox
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: mouse selection of ListModelTypeAheadListBox
......................................................................
frontend: mouse selection of ListModelTypeAheadListBox
If you are not using the ui binder and select the value
on the ListModelTypeAheadListBox using mouse, the
ListModelTypeAheadListBox.asEditor().getSubEditor().getValue();
does not return the selected value.
The problem was that the mouse selection fired the ValueChangeEvent
but no one was listening on it.
It worked with the editor driver because UiCommonEditorVisitor
listens to this event.
Fixed by listening to this event also in the ListModelTypeAheadListBox.
Change-Id: I5edee9d0b0e64dc4f7e8609aa5fde4c69e133924
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5edee9d0b0e64dc4f7e8609aa5fde4c69e133924
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: fix duplicate values in non operational reasons
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix duplicate values in non operational reasons
......................................................................
core: fix duplicate values in non operational reasons
As a result of recent changes, NonOperationalReasom enum contains two
entries with duplicated int values, this patch changes them to have
unique values.
Change-Id: I80ecc00898c05ef80d346fe171bbe08993b148cc
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80ecc00898c05ef80d346fe171bbe08993b148cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: minor refactorings in StopVmCommandBase
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: minor refactorings in StopVmCommandBase
......................................................................
core: minor refactorings in StopVmCommandBase
- rearrange stopSuspendedVm method to be more readable
- rename Destroy method to destroyVm
- remove usages of DbFacade class
Change-Id: Ie347eb6b9df6284038dd5b9028f3d39d81e04f64
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
2 files changed, 17 insertions(+), 18 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie347eb6b9df6284038dd5b9028f3d39d81e04f64
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
