Change in ovirt-engine[master]: packaging: setup: cleanup: pep8 of host rename
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: cleanup: pep8 of host rename
......................................................................
packaging: setup: cleanup: pep8 of host rename
Change-Id: Ibf3992e5bd3161589cfe4bc65367b234e63d7809
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-rename/core/pki.py
M packaging/setup/plugins/ovirt-engine-rename/core/postinstall.py
M packaging/setup/plugins/ovirt-engine-rename/core/protocols.py
M packaging/setup/plugins/ovirt-engine-rename/core/tools.py
4 files changed, 14 insertions(+), 10 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17777
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf3992e5bd3161589cfe4bc65367b234e63d7809
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: packaging: setup: handle special characters in password
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: handle special characters in password
......................................................................
packaging: setup: handle special characters in password
escape chars based on usage, reuse escape.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=811234
Change-Id: Ide021a99d30b616e6396a7412ec17cf3a3e0ed02
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/util.py
M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-setup/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
4 files changed, 27 insertions(+), 9 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide021a99d30b616e6396a7412ec17cf3a3e0ed02
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years, 5 months
Change in ovirt-engine[master]: userportal : Fix DiskForVmGuid high CPU
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: userportal : Fix DiskForVmGuid high CPU
......................................................................
userportal : Fix DiskForVmGuid high CPU
In this patch we remove the need to load all disk data and just load the
required information for the user portal.
Bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=971237
Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c
Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksPartialDataByVmIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmBasicDiskListModel.java
M packaging/dbscripts/all_disks_sp.sql
7 files changed, 104 insertions(+), 11 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core, rest, frontend: removed PoweredDown VM status
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core, rest, frontend: removed PoweredDown VM status
......................................................................
core, rest, frontend: removed PoweredDown VM status
This status is not returned since 2.2 from VDSM
and it has only been forgotten in engine - removed.
Change-Id: I4eda2787dfe3056cb90ca0501e5af3e7a920c397
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VmStatus.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemMessagesTranslator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java
13 files changed, 4 insertions(+), 32 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4eda2787dfe3056cb90ca0501e5af3e7a920c397
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: webadmin: Fix NumberFormatException in VM popup view
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fix NumberFormatException in VM popup view
......................................................................
webadmin: Fix NumberFormatException in VM popup view
Fixed a NumberFormatException when the CpuSharesAmount is 'Disable' (string is "").
Change-Id: I4a7b5de45e14af96e3cc8fe2a597138205a7da92
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a7b5de45e14af96e3cc8fe2a597138205a7da92
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: added is_run_once flag to vm_dynamic
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: added is_run_once flag to vm_dynamic
......................................................................
core: added is_run_once flag to vm_dynamic
Adds the is_run_once to vm_dynamic to be able to
find out about a VM if it is in run_once or not.
Change-Id: I25acdbcc84d326c694d7ae5ff1facaf13e5d683e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987985
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0700_add_is_run_once_to_vm_dynamic.sql
M packaging/dbscripts/vms_sp.sql
11 files changed, 33 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25acdbcc84d326c694d7ae5ff1facaf13e5d683e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in mom[master]: KSM: Only tune when there are changes to make
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: KSM: Only tune when there are changes to make
......................................................................
KSM: Only tune when there are changes to make
The KSM Controller tries to figure out if the policy has indicated any
changes to the ksm configuration. When none are found, the Controller
should finish quietly with no call to the hypervisor interface. Due to
an indentation error, it is calling the KSM tuning function
unconditionally. Fix.
Change-Id: I2b082e35eae9d3a790da8c6e11e2c17fc70a056d
Signed-off-by: Adam Litke <agl(a)linux.vnet.ibm.com>
Reviewed-on: http://gerrit.ovirt.org/17711
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Doron Fediuck <dfediuck(a)redhat.com>
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/Controllers/KSM.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adam Litke: Looks good to me, approved
Doron Fediuck: Verified
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b082e35eae9d3a790da8c6e11e2c17fc70a056d
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: webadmin: Change CPU shares default value in UI
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Change CPU shares default value in UI
......................................................................
webadmin: Change CPU shares default value in UI
Added The 'Disabled' option to the CPU shares selection in the VM popup
view. This value will be the default and will set shares to 0.
Change-Id: I7528724ea20cea3c20b706047991ca193275f990
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7528724ea20cea3c20b706047991ca193275f990
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: Fix CPU shares in VmInfoBuilder
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix CPU shares in VmInfoBuilder
......................................................................
core: Fix CPU shares in VmInfoBuilder
When CPU shares are 0, the info builder should not include the cpuShares
node in the info (so that in vdsm the CPU shares capability will just be disabled)
Change-Id: I45e75b2c91049f5e7e74e208adcdcf0ee7c3a8d6
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45e75b2c91049f5e7e74e208adcdcf0ee7c3a8d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: engine: add enabled column to policy_units
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: add enabled column to policy_units
......................................................................
engine: add enabled column to policy_units
As part of the External scheduler integration:
- Added "enabled" field to policy unit object, dao, and db
This patch is meant to decrease the size and simplify
the External Scheduler integration patch
Change-Id: I6be407297c259aedf17283d2f674021cf0e4a135
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java
M packaging/dbscripts/policy_unit_sp.sql
A packaging/dbscripts/upgrade/03_03_0690_add_enabled_column_to_policy_unit.sql
5 files changed, 40 insertions(+), 7 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6be407297c259aedf17283d2f674021cf0e4a135
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months