Change in ovirt-engine[master]: webadmin: cluster policy dialog - minor fixes
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: cluster policy dialog - minor fixes
......................................................................
webadmin: cluster policy dialog - minor fixes
* Adding abillity to filter to have no position.
* Fixing dnd not disabled while cluster policy is locked.
Change-Id: I4698753320fecf24cc0fbf4e95af2c0ea8c57b31
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java
4 files changed, 21 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4698753320fecf24cc0fbf4e95af2c0ea8c57b31
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: backup.sh return code always 0 even on error
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: backup.sh return code always 0 even on error
......................................................................
core: backup.sh return code always 0 even on error
Removing the usage call in case of error since the usage method exists
with 0 value
Change-Id: Iff32ce8ca0ab8763ee5bbe93a977397df548d4ea
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=966980
---
M packaging/dbscripts/backup.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff32ce8ca0ab8763ee5bbe93a977397df548d4ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: [ExternalTasks] Step cannot be ended as...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: [ExternalTasks] Step cannot be ended as...
......................................................................
core: [ExternalTasks] Step cannot be ended as...
[ExternalTasks] Step cannot be ended as not successful
Changing the ExecutionHandler:;endStep code to update the step status
and its job status as well in a case of failure.
Change-Id: I7da6e75cf48c9639ee4562885cfc2ab38da7f278
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988088
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
1 file changed, 20 insertions(+), 20 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7da6e75cf48c9639ee4562885cfc2ab38da7f278
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: [db] moving matrialilized views function...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: [db] moving matrialilized views function...
......................................................................
core: [db] moving matrialilized views function...
core: [db] moving materialized views function to dbscustom.sh
Since materialized views functionality is not common to all databases,
moving this functionality to dbcustomfunctions.sh such that it can be
overridden by empty functions with the same names
Change-Id: I696b50dc98988f91912930b5d3777add0a2ae56d
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbcustomfunctions.sh
M packaging/dbscripts/dbfunctions.sh
2 files changed, 19 insertions(+), 16 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I696b50dc98988f91912930b5d3777add0a2ae56d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: core: QueryData2 generates slow SQL for...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: QueryData2 generates slow SQL for...
......................................................................
core: QueryData2 generates slow SQL for...
QueryData2 generates slow SQL for AuditLog with no parameters
This patch fixes two issues
When the inner query condition of getting the events is empty it omits
the inner query.
i.e.
Instead of
SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and
audit_log_id IN (SELECT audit_log.audit_log_id FROM audit_log ) and
not deleted) ORDER BY audit_log_id DESC ,audit_log_id DESC ) as T1
OFFSET (1 -1) LIMIT 100
Perform:
SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and not
deleted) ORDER BY audit_log_id DESC ,audit_log_id DESC ) as T1 OFFSET
(1 -1) LIMIT 100;
In addition, this patch fixes the redundancy in the SORT , so final
query is :
SELECT * FROM (SELECT * FROM audit_log WHERE ( audit_log_id > 0 and not
deleted) ORDER BY audit_log_id DESC) as T1 OFFSET
(1 -1) LIMIT 100;
Change-Id: Id148adcc734c5742548c74ea754fb70252155e34
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960831
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 22 insertions(+), 13 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id148adcc734c5742548c74ea754fb70252155e34
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: restapi: use storageconnection instead of storage
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: use storageconnection instead of storage
......................................................................
restapi: use storageconnection instead of storage
Change the code to use StorageConnection object instead of Storage
in storage connections REST resource.
Fix tests,rsdl,api.xsd accordingly.
Change-Id: Icb401cef8e08e62c57c0ef8afd4677c764d065a9
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StorageConnectionValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java
12 files changed, 101 insertions(+), 79 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb401cef8e08e62c57c0ef8afd4677c764d065a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Fix runUpdateMomPolicy in InitVdsOnUpCommand
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix runUpdateMomPolicy in InitVdsOnUpCommand
......................................................................
core: Fix runUpdateMomPolicy in InitVdsOnUpCommand
The method used the wrong kind of return value.
Change-Id: I5fc671994013e7bd5ac5706316f2a64ba25c1015
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 12 insertions(+), 9 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fc671994013e7bd5ac5706316f2a64ba25c1015
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 5 months
Change in ovirt-engine[master]: userportal: adding user message of the day
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal: adding user message of the day
......................................................................
userportal: adding user message of the day
This patch adds the user message of the day functionality in the user
portal login page
Change-Id: I020c4772388ac5ebc2b6391ad3b0e1eef0081309
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=983120
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationTemplates.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml
4 files changed, 130 insertions(+), 2 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I020c4772388ac5ebc2b6391ad3b0e1eef0081309
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: adding user message of the day
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding user message of the day
......................................................................
core: adding user message of the day
This patch adds the UserMessageOfTheDay config entry, also allowing to:
1. Set it using engine-config
2. Fetch it in public query, as it will be used in the login page
Change-Id: Ifb207a2505fb2456c21ab48ffc4afefce068e2e2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=983120
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
5 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb207a2505fb2456c21ab48ffc4afefce068e2e2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core:[ExternalTasks] When adding new step, type..
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:[ExternalTasks] When adding new step, type..
......................................................................
core:[ExternalTasks] When adding new step, type..
[ExternalTasks] When adding new step, type is always EXECUTING
Changing AddExternalStepCommand::execute to get the step type from the
parameters object instead of using a constant EXECUTING value
Change-Id: I04134ffa8e937e623aa7107ca501fb7e79a3ab5c
BUG-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988086
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04134ffa8e937e623aa7107ca501fb7e79a3ab5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months