September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Split update of 'isPlugged' and 'bootOrder' properti...
by iheim＠redhat.com 24 Sep '13

24 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Split update of 'isPlugged' and 'bootOrder' properties... ...................................................................... engine: Split update of 'isPlugged' and 'bootOrder' properties... HotPlugDiskToVmCommand updates 'isPlugged' and 'bootOrder' of all devices attached to any particular VM. It should only update 'isPlugged' for the device that was plugged by this command, otherwise it can cause a race with another thread which handles the hot plug of another disk for the same VM. Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Bug-Url: https://bugzilla.redhat.com/1003649 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M packaging/dbscripts/vm_device_sp.sql 6 files changed, 89 insertions(+), 31 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: bridge name in hosted-engine.conf
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: bridge name in hosted-engine.conf ...................................................................... packaging: setup: bridge name in hosted-engine.conf Added bridge key in hosted-engine.conf allowing the HA agent to parse it in an easy way. The value is now assigned from environment variable instead of being hardcoded in the template Bug-Url: https://bugzilla.redhat.com/1010866 Change-Id: I698d6e7609ef20dff0426b07028ca3391e82a0d7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M templates/hosted-engine.conf.in M templates/vm.conf.in 4 files changed, 8 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I698d6e7609ef20dff0426b07028ca3391e82a0d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: unlock imported glance image on create errors
by iheim＠redhat.com 24 Sep '13

24 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: backend: unlock imported glance image on create errors ...................................................................... backend: unlock imported glance image on create errors When the serial execution of tasks for ImportRepoImageCommand fails in the first handler we should make sure to remove the disk as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006400 Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: prevent destroy command on glance domains
by iheim＠redhat.com 24 Sep '13

24 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: backend: prevent destroy command on glance domains ...................................................................... backend: prevent destroy command on glance domains Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006878 Change-Id: Idfb6f61d63d2bff7a3131eab82d24a9f7c4645c3 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfb6f61d63d2bff7a3131eab82d24a9f7c4645c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.0]: engine: Clearing address of vm disk device if it's interface...
by oschreib＠redhat.com 24 Sep '13

24 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engine: Clearing address of vm disk device if it's interface was changed. ...................................................................... engine: Clearing address of vm disk device if it's interface was changed. Updating disk interface its like detach and attach disk again, therefore address of the vm device representing this disk must be cleared. Change-Id: I62605c490da909447f77513e7691d76ddd24ff26 Bug-Url: https://bugzilla.redhat.com/994247 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 53 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Ofer Schreiber: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/19465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62605c490da909447f77513e7691d76ddd24ff26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add vnic profile action groups to roles tree
by masayag＠redhat.com 24 Sep '13

24 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Add vnic profile action groups to roles tree ...................................................................... webadmin: Add vnic profile action groups to roles tree The vnic profiles action groups were added to the roles tree in order to better describe the actions supported by an existing roles or to enable creation of a custom role which includes any of these action groups. Change-Id: I56ba098f8b0b8e1f94aa7ec82b3612a6a81365d6 Bug-Url: https://bugzilla.redhat.com/1002483 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 36 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56ba098f8b0b8e1f94aa7ec82b3612a6a81365d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactor RoleTreeView
by masayag＠redhat.com 24 Sep '13

24 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Refactor RoleTreeView ...................................................................... webadmin: Refactor RoleTreeView RoleTreeView had too long and complicated method with too many indentation levels. The patch reduces the complexity and allows new entities to be added more easily to the Action Groups tree. Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Related-To: https://bugzilla.redhat.com/1002483 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 207 insertions(+), 341 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: prevent destroy command on glance domains
by tnisan＠redhat.com 24 Sep '13

24 Sep '13

Tal Nisan has submitted this change and it was merged. Change subject: backend: prevent destroy command on glance domains ...................................................................... backend: prevent destroy command on glance domains Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006878 Change-Id: Idfb6f61d63d2bff7a3131eab82d24a9f7c4645c3 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfb6f61d63d2bff7a3131eab82d24a9f7c4645c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: unlock imported glance image on create errors
by tnisan＠redhat.com 24 Sep '13

24 Sep '13

Tal Nisan has submitted this change and it was merged. Change subject: backend: unlock imported glance image on create errors ...................................................................... backend: unlock imported glance image on create errors When the serial execution of tasks for ImportRepoImageCommand fails in the first handler we should make sure to remove the disk as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006400 Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49054d36eef780d0902f7dcd448ca44797f42916 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: enable start/stop rebalance based on status
by kmayilsa＠redhat.com 24 Sep '13

24 Sep '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: enable start/stop rebalance based on status ...................................................................... webadmin: enable start/stop rebalance based on status 'Start' rebalance action will be enabled if the task status of the selected volume(s) is not 'STARTED'. 'Stop' rebalance action will be enabled if only one volume is selected and the task is REBALANCE and the status is 'STARTED'. Change-Id: Id01a605cfd3a59f3e3b584144f8f7589f0922f1e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 21 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id01a605cfd3a59f3e3b584144f8f7589f0922f1e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0