September 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Fix NPE in UpdateVdsGroupCommand

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: engine: Fix NPE in UpdateVdsGroupCommand ...................................................................... engine: Fix NPE in UpdateVdsGroupCommand Fixed an NPE when updating a cluster Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Bug-Url: https://bugzilla.redhat.com/1011435 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: set multi monitor only when compatible on import

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: engine: set multi monitor only when compatible on import ...................................................................... engine: set multi monitor only when compatible on import Set true only for windows on 3.3 and higher, Also fix tests Change-Id: I8a5ae4a6367fd5e4184f42b514f9be6e42879c26 Bug-Url: https://bugzilla.redhat.com/1007784 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5ae4a6367fd5e4184f42b514f9be6e42879c26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: add missing disk.export() descriptors

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add missing disk.export() descriptors ...................................................................... restapi: add missing disk.export() descriptors Change-Id: I61136522a018d3633182a00f1a70e70ec00f6480 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 24 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61136522a018d3633182a00f1a70e70ec00f6480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin : volume rebalance status bug corrected

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : volume rebalance status bug corrected ...................................................................... webadmin : volume rebalance status bug corrected In volume rebalance status pop up window,rebalance status query was getting executed every 10s even after closing the pop up. Now,it has been corrected. Change-Id: Ibc9f37cc55ee540250b434da3ad06de90a502591 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9f37cc55ee540250b434da3ad06de90a502591 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Disable Gluster Swift services feature

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Disable Gluster Swift services feature ...................................................................... engine: Disable Gluster Swift services feature Disabling the Gluster services management feature as the services are currently managed per server and this is not needed for managing Gluster for Swift services This feature is going to change in the next release and so disabling to avoid confusion Change-Id: Icc5b5795a13b3d3c1e9b574c445e63a844669d5b Bug-Url: https://bugzilla.redhat.com/1006708 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5b5795a13b3d3c1e9b574c445e63a844669d5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: backend, frontend: add more specific glance errors

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: backend,frontend: add more specific glance errors ...................................................................... backend,frontend: add more specific glance errors Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003902 Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 85 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Split update of 'isPlugged' and 'bootOrder' properti...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: Split update of 'isPlugged' and 'bootOrder' properties... ...................................................................... engine: Split update of 'isPlugged' and 'bootOrder' properties... HotPlugDiskToVmCommand updates 'isPlugged' and 'bootOrder' of all devices attached to any particular VM. It should only update 'isPlugged' for the device that was plugged by this command, otherwise it can cause a race with another thread which handles the hot plug of another disk for the same VM. Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Bug-Url: https://bugzilla.redhat.com/1003649 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M packaging/dbscripts/vm_device_sp.sql 6 files changed, 82 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1359a34a48a6261e22631ff1640d81d735e8c490 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "engine: import need to set single qxl for windows"

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: import need to set single qxl for windows" ...................................................................... Revert "engine: import need to set single qxl for windows" This reverts commit 78c135488743c6eb4f1f57fdf806a8b28b2fc09a. The OvfManagerTest unit tests was failing due to this change Change-Id: If88fc448ad87c4c9063c4c1fba6b40e5abf1b99c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If88fc448ad87c4c9063c4c1fba6b40e5abf1b99c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Clearing address of vm disk device if it's interface...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: engine: Clearing address of vm disk device if it's interface was changed. ...................................................................... engine: Clearing address of vm disk device if it's interface was changed. Updating disk interface its like detach and attach disk again, therefore address of the vm device representing this disk must be cleared. Change-Id: I62605c490da909447f77513e7691d76ddd24ff26 Bug-Url: https://bugzilla.redhat.com/994247 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62605c490da909447f77513e7691d76ddd24ff26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Moved provider list initialization to NetworkModel

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Moved provider list initialization to NetworkModel ...................................................................... webadmin: Moved provider list initialization to NetworkModel This to populate the list box correctly in all occurences of the dialog (not just in networks main tab). Change-Id: I0856a02c14eafe1fe9b1867df1a3e9ef4d7e20d4 Bug-Url: https://bugzilla.redhat.com/989898 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 5 files changed, 55 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/19464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0856a02c14eafe1fe9b1867df1a3e9ef4d7e20d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2013