September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Ignoring specParams when serialization
by rgolan＠redhat.com 09 Sep '13

09 Sep '13

Roy Golan has submitted this change and it was merged. Change subject: core: Ignoring specParams when serialization ...................................................................... core: Ignoring specParams when serialization SpecParams isn't needed in serialization and fails the desialization due to abstract type usage (java.util.Map) JsonIgnore on a getter method simply doesn't work at current Jackson impl unless used in a MixIn. Added a new Mixin for VmPayload Removed @JsonIgnore from VMPayload class Bug-Url: https://bugzilla.redhat.com/985008 Change-Id: I33a6e38a83a715aa359497e0089c16b610d1234a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmPayloadMixIn.java 3 files changed, 18 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33a6e38a83a715aa359497e0089c16b610d1234a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: compare to Boolean with equals
by mpastern＠redhat.com 09 Sep '13

09 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: compare to Boolean with equals ...................................................................... restapi: compare to Boolean with equals Fix findbug warning - compare to Boolean with equals instead of ==. Change-Id: If7f0738730552bb8d2b935551bf9fcf938971834 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7f0738730552bb8d2b935551bf9fcf938971834 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: solve InstantiationException - BigDecimal
by mpastern＠redhat.com 09 Sep '13

09 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: solve InstantiationException - BigDecimal ...................................................................... restapi: solve InstantiationException - BigDecimal Solve InstantiationException when creating a BigDecimal in *MapperTests. Change-Id: I81d064661f3bf0baeeae2e1c71323cdd719fc6ef Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 1 file changed, 24 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81d064661f3bf0baeeae2e1c71323cdd719fc6ef Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: change remove templates message
by tjelinek＠redhat.com 09 Sep '13

09 Sep '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: change remove templates message ...................................................................... frontend: change remove templates message When removing templates the confirmation dialog contained message: "Template(s)" Changed to: "Are you sure you want to remove the following items?" Done this by making use of the standard RemoveConfirmationPopupView Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001874 Change-Id: I1c6d0168a3be5f1aa0df7836167e4a78eddccf0e Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/UserPortalTemplateListProvider.java 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c6d0168a3be5f1aa0df7836167e4a78eddccf0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed redundant scroll bar in VM migration dialog
by tjelinek＠redhat.com 09 Sep '13

09 Sep '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: removed redundant scroll bar in VM migration dialog ...................................................................... webadmin: removed redundant scroll bar in VM migration dialog Removed simply by making the content widgets smaller Change-Id: Ibf2bdb78a8819be5e78badb61500e2dee8089f46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=923343 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.ui.xml 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf2bdb78a8819be5e78badb61500e2dee8089f46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Host.getRebootAfterInstallation() returns False (null w...
by mpastern＠redhat.com 08 Sep '13

08 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Host.getRebootAfterInstallation() returns False (null was expected) #985842 ...................................................................... sdk: Host.getRebootAfterInstallation() returns False (null was expected) #985842 Change-Id: I20be53c2b1f78efb92c4d849854d45632ce9879f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=985842 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/mapping/Mapper.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20be53c2b1f78efb92c4d849854d45632ce9879f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: make sdk exceptions serializable
by mpastern＠redhat.com 08 Sep '13

08 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: make sdk exceptions serializable ...................................................................... sdk: make sdk exceptions serializable Change-Id: I2a52839d398676132bb285b11bf2da9fe46276c8 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/MarshallingException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/OvirtSdkException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/OvirtSdkRuntimeException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/ProtocolException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/ServerException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/SocketFactoryException.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/exceptions/UnsecuredConnectionAttemptError.java 7 files changed, 49 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a52839d398676132bb285b11bf2da9fe46276c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: remote DB installation over otopi
by ydary＠redhat.com 08 Sep '13

08 Sep '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: remote DB installation over otopi ...................................................................... packaging: setup: remote DB installation over otopi Change-Id: Ib9b24feb5bf063fb47ab10efaa4f16e1762c8b2c Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 274 insertions(+), 127 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9b24feb5bf063fb47ab10efaa4f16e1762c8b2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Failed add a host via “Guide Me” on Local Data Center
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Failed add a host via “Guide Me” on Local Data Center ...................................................................... webadmin: Failed add a host via “Guide Me” on Local Data Center Failed add a host via “Guide Me” on Local Data Center Change-Id: Ie9bcb4c4824b58da345d30c70d0fe0c6ecc99a1a Bug-Url: https://bugzilla.redhat.com/998386 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/MoveHostPopupView.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9bcb4c4824b58da345d30c70d0fe0c6ecc99a1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fixes rollback handling in ChangeVDSClusterCommand
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fixes rollback handling in ChangeVDSClusterCommand ...................................................................... engine: Fixes rollback handling in ChangeVDSClusterCommand Fixes rollback handling in ChangeVDSClusterCommand, so when an execption is occured during command, there will not be created two rows for the host in Hosts list Change-Id: I1866901d73b1a3270d51b7b261ce5acf0ea67ce9 Bug-Url: https://bugzilla.redhat.com/984927 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1866901d73b1a3270d51b7b261ce5acf0ea67ce9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0