September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: avoid logging in ERROR on cancelled event. ...................................................................... core: avoid logging in ERROR on cancelled event. *When EventQueueMonitor cancels events, log it in DEBUG. *Submitted Events can have description to provide further info. Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df Bug-Url: https://bugzilla.redhat.com/921462 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 6 files changed, 22 insertions(+), 11 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing RoleDaoDbFacadeImpl
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing RoleDaoDbFacadeImpl ...................................................................... core: fixing RoleDaoDbFacadeImpl Coverity has discovered some uncessary boxing issue. Change-Id: I4a9ff7908155e05f96560976cbaea5c771b755d9 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a9ff7908155e05f96560976cbaea5c771b755d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : endAction run multiple times When RuntimeException ...
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : endAction run multiple times When RuntimeException occurs ...................................................................... engine : endAction run multiple times When RuntimeException occurs When RuntimeException occurs at endAction, the endAction part will be rerun over and over again Change-Id: I50d7688c9f06ae90bed3d80c286534311f5afb1c Bug-Url: https://bugzilla.redhat.com/999896 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java 2 files changed, 37 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50d7688c9f06ae90bed3d80c286534311f5afb1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: clear PGPASSWORD when interacting with dat...
by emesika＠redhat.com 08 Sep '13

08 Sep '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: clear PGPASSWORD when interacting with database ...................................................................... packaging: setup: clear PGPASSWORD when interacting with database when both PGPASSWORD and PGPASSFILE are specified the PGPASSWORD takes precedence, so we should unset/zero it to avoid errors when user has PGPASSWORD within environment and executes setup. Change-Id: I1c74518db882fe91955a69132e8fb5d4cd212329 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/dbutils/common.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c74518db882fe91955a69132e8fb5d4cd212329 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Take into account command transactivity scope when...
by yzaslavs＠redhat.com 08 Sep '13

08 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Take into account command transactivity scope when... ...................................................................... core: Take into account command transactivity scope when... Take into account command transactivity scope when creating new task duing persistence of place holder. If the command is transactive - create the place holder in a new transaction, so the record will be recognized when there will be association between VDSM task ID and DB task ID. This will solve the bug in which removal of template causes some records with empty VDSM task ID to be left after command ends. Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Bug-Url: https://bugzilla.redhat.com/1005527 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: allow nested tags more than 2 levels deep
by vszocs＠redhat.com 06 Sep '13

06 Sep '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: allow nested tags more than 2 levels deep ...................................................................... webadmin: allow nested tags more than 2 levels deep - Fixed code to allow for nested tags to be assigned more than 2 levels deep. Change-Id: I7dcb031aaf6cd279c9f439694184743db1b85eb8 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java 1 file changed, 20 insertions(+), 22 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dcb031aaf6cd279c9f439694184743db1b85eb8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Handler cleanup in ModelListTreeViewModel
by vszocs＠redhat.com 06 Sep '13

06 Sep '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Handler cleanup in ModelListTreeViewModel ...................................................................... webadmin: Handler cleanup in ModelListTreeViewModel Handlers registered in ModelListTreeViewModel are now properly removed upon detaching tree widget from the DOM. Change-Id: Ibcf5ee07191a94e4ca157cf6fe4230e0eaafc2f6 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcf5ee07191a94e4ca157cf6fe4230e0eaafc2f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: split messages in two file
by ecohen＠redhat.com 04 Sep '13

04 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: split messages in two file ...................................................................... userportal,webadmin: split messages in two file - Split messages.properties into messages and resources so they won't confuse the translation software. Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/branding/BrandingThemeTest.java M packaging/branding/ovirt.brand/branding.properties A packaging/branding/ovirt.brand/external_resources.properties M packaging/branding/ovirt.brand/messages.properties 6 files changed, 72 insertions(+), 29 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix broken message lookup
by vszocs＠redhat.com 04 Sep '13

04 Sep '13

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: fix broken message lookup ...................................................................... engine: fix broken message lookup - Fixed issue where certain combinations of message keys where not being included in the message map. Change-Id: Id4ef98170fede29fa97dd9d8c839cc96671e2839 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003775 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/404.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/404.jsp 4 files changed, 14 insertions(+), 15 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ef98170fede29fa97dd9d8c839cc96671e2839 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: leak property file resource
by vszocs＠redhat.com 04 Sep '13

04 Sep '13

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: leak property file resource ...................................................................... engine: leak property file resource - Fixed resource leak in loading themes. Change-Id: I7d66412b9b5242af8c471d4191d50a48d9eaa1e9 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d66412b9b5242af8c471d4191d50a48d9eaa1e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0