September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: remove postgresql port from iptable template
by oschreib＠redhat.com 02 Sep '13

02 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove postgresql port from iptable template ...................................................................... packaging: setup: remove postgresql port from iptable template the port is added using the firewalld->iptables mechanism. Change-Id: I86484bd8300f7073c238db48b78e71b8ba9f778b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/iptables.default.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86484bd8300f7073c238db48b78e71b8ba9f778b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: append lines once to hb_hba.conf
by oschreib＠redhat.com 02 Sep '13

02 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: append lines once to hb_hba.conf ...................................................................... packaging: setup: append lines once to hb_hba.conf Change-Id: I74d80fe6eed1f0eca431d83ba7128950862f8dc6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 1 file changed, 25 insertions(+), 22 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74d80fe6eed1f0eca431d83ba7128950862f8dc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Fixed roles DAO test failures
by emesika＠redhat.com 02 Sep '13

02 Sep '13

Eli Mesika has submitted this change and it was merged. Change subject: gluster: Fixed roles DAO test failures ...................................................................... gluster: Fixed roles DAO test failures Fixed roles DAO test failures Change-Id: I07547c18e5e4eea1522f9621a85c13d853c66975 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Shubhendu Tripathi: Verified -- To view, visit http://gerrit.ovirt.org/18758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07547c18e5e4eea1522f9621a85c13d853c66975 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove storage - gray out hosts list
by derez＠redhat.com 02 Sep '13

02 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: remove storage - gray out hosts list ...................................................................... webadmin: remove storage - gray out hosts list Host list is irrelevant for ISO/Export domains when 'format' is unchecked (since no operation is performed by the host). Hence, graying out the select-box. Change-Id: I27496ae060d0255d2e8237fde3a80737ac9ff6bd Bug-Url: https://bugzilla.redhat.com/1003241 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27496ae060d0255d2e8237fde3a80737ac9ff6bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Added app_mode field to roles table
by kmayilsa＠redhat.com 02 Sep '13

02 Sep '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Added app_mode field to roles table ...................................................................... gluster: Added app_mode field to roles table Added a field app_mode to roles table. The value of application modes for a role decides if that role is available in that application mode. This detail would be used for rendering the list of roles as per the application mode. This would avoid deletion of unwanted roles in case of gluster downstream. Change-Id: Id83b7a2c90100744487b276642158e7c3e93de85 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/multi_level_administration_sp.sql A packaging/dbscripts/upgrade/03_03_0810_add_app_mode_to_roles.sql 9 files changed, 128 insertions(+), 19 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id83b7a2c90100744487b276642158e7c3e93de85 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: filetransaction: Always add a newline
by Alon Bar-Lev 01 Sep '13

01 Sep '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: filetransaction: Always add a newline ...................................................................... core: filetransaction: Always add a newline Always add newline when the content is a non-empty list or tuple. Without this change, files that have an empty last line, and are edited by reading them with read().splitlines(), changing some lines, and then writing them with filetransaction, loose their empty last line. Change-Id: I97f0feef1c003250c9f7453245f68398c64051cd Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/filetransaction.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/18690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f0feef1c003250c9f7453245f68398c64051cd Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix findbugs errors
by ofrenkel＠redhat.com 01 Sep '13

01 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix findbugs errors ...................................................................... core: fix findbugs errors There were couple of errors related to the way we compute if post zero is needed when removing memory image from export domain. This patch changes the way we do it to be more standard. Change-Id: Ic66ba287b6048615b71cd0b2d876e7d75bcc4655 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic66ba287b6048615b71cd0b2d876e7d75bcc4655 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix possible NPE in internal migration
by ofrenkel＠redhat.com 01 Sep '13

01 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix possible NPE in internal migration ...................................................................... core: fix possible NPE in internal migration The check for migration support uses the VM and it was executed before the VM was validated (that it is not null). Thus, this patch changes the order of the checks, so that the migration support check will be executed after the checks in MigrateVmCommand are executed. Change-Id: I1c287d989e62daa43e834d9f9657dac9820764a3 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c287d989e62daa43e834d9f9657dac9820764a3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix possible NPE in migrate vm to server
by ofrenkel＠redhat.com 01 Sep '13

01 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix possible NPE in migrate vm to server ...................................................................... core: fix possible NPE in migrate vm to server Rearrange the order of the checks which are carried out in MigrationVmToServerCommand#canDoAction method, such that checks which are use the VM will be executed after the VM is validated in MigrateVmCommand#canDoAction. Change-Id: Icc96ecb14eb0350823dc7ea2fd95a2b56ca2ec41 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc96ecb14eb0350823dc7ea2fd95a2b56ca2ec41 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: lock VM for the whole VM migration process
by ofrenkel＠redhat.com 01 Sep '13

01 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: lock VM for the whole VM migration process ...................................................................... core: lock VM for the whole VM migration process Exclusive VM lock is now being taken for the whole execution of VM migration, thus preventing other operations that should not be run in parallel from being executed (as long as they take VM lock, which can be shared lock, as well of course). Change-Id: Iec678dfda4824e9ece18f0c876ffc94594591ff8 Bug-Url: https://bugzilla.redhat.com/952147 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 53 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec678dfda4824e9ece18f0c876ffc94594591ff8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0