Change in ovirt-engine[master]: core: assure migration jobs are completed
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: assure migration jobs are completed
......................................................................
core: assure migration jobs are completed
Add missing call to failedToRunVm method when VM migration fails because
the VM went down on the destination and source during the migration,
this call assures that the migration job is completed in this case as
well.
Change-Id: Iee82fc63b09d53e085fe32c710b43b5cc9b1498b
Bug-Url: https://bugzilla.redhat.com/952147
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee82fc63b09d53e085fe32c710b43b5cc9b1498b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: keep locks for whole offline disk migration process
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: keep locks for whole offline disk migration process
......................................................................
core: keep locks for whole offline disk migration process
The VM lock is now kept for the whole offline (not live) disk migration
process. This change prevents a race that can cause a VM to start
running in parallel to offline disk migration.
Change-Id: I89acf9f66bce647a7ecb2dd407e51a1ba03f4e17
Bug-Url: https://bugzilla.redhat.com/952147
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89acf9f66bce647a7ecb2dd407e51a1ba03f4e17
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: acquire locks in standard way in MoveOrCopyDiskCommand
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: acquire locks in standard way in MoveOrCopyDiskCommand
......................................................................
core: acquire locks in standard way in MoveOrCopyDiskCommand
In order to solve the race between VM migration and storage commands, we
need the storage commands to be able to acquire VM lock for their entire
execution process. That thing cannot be done when the locks are acquired
using explicit invocation of acquireLockInternal method, we need the
LockIdAndNameAttribute annotation.
Thus, this patch converts the way MoveOrCopyDiskCommand acquire its
locks such that it will be in the standard way.
Change-Id: Id4b5ef206581e5f9a1727c85b30f39802859583c
Bug-Url: https://bugzilla.redhat.com/952147
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
3 files changed, 51 insertions(+), 41 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b5ef206581e5f9a1727c85b30f39802859583c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-dwh[master]: packaging: setup: getting vdc options value by quering DB di...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: getting vdc options value by quering DB directly
......................................................................
packaging: setup: getting vdc options value by quering DB directly
This new implementation uses direct DB query for vdc options
instead of engine-config usage.
Change-Id: I77dbeaeececd3158d013ee01439ad89e7e46ab82
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/common_utils.py
M packaging/ovirt-engine-dwh-setup.py
2 files changed, 28 insertions(+), 16 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77dbeaeececd3158d013ee01439ad89e7e46ab82
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[master]: engine: Add instance ID to MAC pool manager
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add instance ID to MAC pool manager
......................................................................
engine: Add instance ID to MAC pool manager
When logging, it would be beneficial to know the instance ID of the
manager in order to identify on which objects the MAC addresses pool is
managed.
Change-Id: I46663116b60d083af7eb1334cc253834cb558a6c
Related-to: https://bugzilla.redhat.com/987825
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
1 file changed, 21 insertions(+), 9 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46663116b60d083af7eb1334cc253834cb558a6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: Use old method of network init on 3.2 hosts
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Use old method of network init on 3.2 hosts
......................................................................
engine: Use old method of network init on 3.2 hosts
When using setup networks to set the host's management network instead
of the host deploy, the operation can sometimes fail as super VDSM
service is not ready yet (although VDSM seems active).
We have considered a possibility to retry the operation, but there is no
good way to know what caused the first attempt to fail, or how many
attempts should be made.
Hence, the chosen solution was to have the old way for 3.2 hosts, and
for 3.3 hosts only the setup networks post-installation will occur.
Change-Id: Icd1f41ee037f46a7e9ca360f3d10d5d2a5bcc547
Bug-Url: https://bugzilla.redhat.com/999461
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1f41ee037f46a7e9ca360f3d10d5d2a5bcc547
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
10 years, 7 months
Change in ovirt-engine[master]: core: sync luns info after ConnectStorageServer
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: sync luns info after ConnectStorageServer
......................................................................
core: sync luns info after ConnectStorageServer
* Introducing SyncLunsInfoForIscsiStorageDomainCommand:
used for synchronizing the DB with the LUNs details
comprising the storage domain.
* The command is called after ConnectStorageServer
(which is invoked on activate storage domain).
Change-Id: I5867ad8d36f329e23c611079512be30a9c5f83a5
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 203 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5867ad8d36f329e23c611079512be30a9c5f83a5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core, restapi: attach detach storage connections
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core,restapi: attach detach storage connections
......................................................................
core,restapi: attach detach storage connections
Introduce capability for attaching/detaching connections
for storage domains.
Core - new commands:
* AttachStorageConnectionToStorageDomainCommand
(support existing/floating connections)
* DetachStorageConnectionFromStorageDomainCommand
REST:
* Attach:
POST /api/storagedomains/{storage_id}/storageconnections
<storage_connection id="{connection_id}">
</storage_connection>
* Detach:
DELETE /api/storagedomains/{storage_id}/storageconnections/{connection_id}
Feature page: http://www.ovirt.org/Features/Manage_Storage_Connections
Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Signed-off-by: Daniel Erez <derez(a)redhat.com>
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageConnectionToStorageDomainCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageConnectionFromStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageConnectionValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageServerConnectionToStorageDomainCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DetachStorageConnectionFromStorageDomainCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageConnectionValidatorTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDetachStorageConnectionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainServerConnectionsResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionsResourceTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
22 files changed, 943 insertions(+), 39 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: db: remove unused create_db_devel.sh config_devel.sql
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: remove unused create_db_devel.sh config_devel.sql
......................................................................
db: remove unused create_db_devel.sh config_devel.sql
these were used by developer to create database manually for development
mode before the packaging supported development mode.
Change-Id: I2a8c967b7f432e60648814565d04198e58dd9a2c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
D packaging/dbscripts/config_devel.sql
D packaging/dbscripts/create_db_devel.sh
2 files changed, 0 insertions(+), 65 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8c967b7f432e60648814565d04198e58dd9a2c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: fix wrong upgrade script name
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix wrong upgrade script name
......................................................................
core: fix wrong upgrade script name
This script is in the content of 3.3 and was introduced as 3.2
This patch moves this script to 3.3 and puts a dummy script in its place
to keep the numbering right.
Change-Id: Ibff8bbecd1da6e22261c01ef7c772c08c22fd0b6
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_02_0450_dummy.sql
R packaging/dbscripts/upgrade/03_03_0800_add_vm_vnc_keyboard_layout.sql
2 files changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibff8bbecd1da6e22261c01ef7c772c08c22fd0b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 7 months