January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: codegen: Allow connection to SSL servers
by juan.hernandez＠redhat.com 06 Jan '14

06 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Allow connection to SSL servers ...................................................................... codegen: Allow connection to SSL servers Currently the generator connects to a live engine using HTTP, without SSL. This isn't the default configuration for a freshly installed engine, so it makes generation a bit more complicated. This patch adds support for connecting to a SSL protected server without verification. Change-Id: I35ddfac416464876685b5e63b241db47e401626d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35ddfac416464876685b5e63b241db47e401626d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Make URL, user and password configurable
by juan.hernandez＠redhat.com 06 Jan '14

06 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Make URL, user and password configurable ...................................................................... codegen: Make URL, user and password configurable Currently the main class of the generator hardcodes the URL, the user name and the password used to connect to the engine in order to retrieve the XML schema of the entities and the RSDL. This patch makes them configurable, using the --url, --user and --password command line options. If these options aren't provided default values are used, so the class can be used exactly as before. Change-Id: I95c77cb8dfcdf4d1baeb186376c800d100e923e5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java 1 file changed, 33 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95c77cb8dfcdf4d1baeb186376c800d100e923e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Authentication method doesn't change when using ar...
by yzaslavs＠redhat.com 05 Jan '14

05 Jan '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Authentication method doesn't change when using arrow keys ...................................................................... webadmin: Authentication method doesn't change when using arrow keys UI doesn't refresh when adding a new host and user moves between password and ssh publickey using arrow keys, Change-Id: I4c84d5c98d66dc5785429570cfa36c3e17f760e9 Bug-Url: https://bugzilla.redhat.com/999636 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c84d5c98d66dc5785429570cfa36c3e17f760e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity warnings
by masayag＠redhat.com 05 Jan '14

05 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix coverity warnings ...................................................................... engine: Fix coverity warnings Fixed the following: 1. Inner class should be static 2. A private field should be accessed Change-Id: I998f955a42cf930fdec73ed44a0114fdbbcc4fe2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I998f955a42cf930fdec73ed44a0114fdbbcc4fe2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use java.util.Objects.equals(Object, Object)
by masayag＠redhat.com 05 Jan '14

05 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Use java.util.Objects.equals(Object, Object) ...................................................................... core: Use java.util.Objects.equals(Object, Object) This patch replaces usages of org.ovirt.engine.core.common.utils.ObjectUtils.equals(Object, Object) with the standard JDK7 java.util.Objects.equals(Object, Object) wherever possible (i.e., no GWT compilation is required). This patch helps standardize the code, makes it slightly more readable to novice oVirt developers and may even save a pico-second of performance. Change-Id: Ifbce02996fbba804aeabc54a13f2109656f4a2c6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UniquePermissionsSet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationValue.java 5 files changed, 16 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbce02996fbba804aeabc54a13f2109656f4a2c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: scheduling: handle cpu load duration
by gchaplik＠redhat.com 05 Jan '14

05 Jan '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: scheduling: handle cpu load duration ...................................................................... core: scheduling: handle cpu load duration Move the logic into SchedulerManager. Change-Id: I231aa54ccc0cadbd9456b090fe08ae85dd926957 Bug-Url: https://bugzilla.redhat.com/1031353 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 7 files changed, 44 insertions(+), 74 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I231aa54ccc0cadbd9456b090fe08ae85dd926957 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity warnings (NULL_RETURNS)
by mkolesni＠redhat.com 05 Jan '14

05 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix coverity warnings (NULL_RETURNS) ...................................................................... engine: Fix coverity warnings (NULL_RETURNS) Although the warned scenario is unlikely to occur, it would be advisable to terminate network configuration base on network labels if an external event (i.e. refresh host capabilities) will cause an existing labeled nic to disappear. This is a rare race, but can happen. Change-Id: Iea07be387e71f0dfb8d9a78d8e03c504095c2062 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 20 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea07be387e71f0dfb8d9a78d8e03c504095c2062 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract common builder methods to base class
by masayag＠redhat.com 05 Jan '14

05 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract common builder methods to base class ...................................................................... engine: Extract common builder methods to base class Couple of methods are moved to the base class so they can be reused by other builders. Change-Id: Ia67531b028ef698d3f1dd98657ccb93e00b30415 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java 3 files changed, 24 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia67531b028ef698d3f1dd98657ccb93e00b30415 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Retrieve networks by label for a cluster
by masayag＠redhat.com 05 Jan '14

05 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Retrieve networks by label for a cluster ...................................................................... engine: Retrieve networks by label for a cluster Adding the ability to fetch networks from the DB with a specific label, where the networks are all assigned to a specific cluster. This will allow to identify which labelled networks should be configured on the host when a nic is labeled. Change-Id: Ibffa2222669a42541cb2da80430d86c8aaddd471 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java 3 files changed, 40 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibffa2222669a42541cb2da80430d86c8aaddd471 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add test for ValidName annotation
by masayag＠redhat.com 05 Jan '14

05 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add test for ValidName annotation ...................................................................... engine: Add test for ValidName annotation Change-Id: Ica4ef1fd43a1c6144bb722b57a036a160d713c57 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica4ef1fd43a1c6144bb722b57a036a160d713c57 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0