Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: setup: set engine db credentials from config
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: set engine db credentials from config
......................................................................
packaging: setup: set engine db credentials from config
engine-setup writes the engine database credentials to the dwh db
config file, but did not read them from there on the next run, instead
asking for them again.
Change-Id: I1e07b41d2834f74d4babe6429c2ba3979a4b12ed
Bug-Url: https://bugzilla.redhat.com/1156039
Bug-Url: https://bugzilla.redhat.com/1128787
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit e5b9b2cde026493b6e2f7d324cb37a335ad49fdb)
---
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py
1 file changed, 74 insertions(+), 0 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e07b41d2834f74d4babe6429c2ba3979a4b12ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine-sdk[master]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Regenerate against the latest API
......................................................................
sdk: Regenerate against the latest API
This patch regenerates the SDK using the latest API obtained from
the engine built from commit 76da3d7.
Change-Id: I7f2dac29e6563c0380ed608ea64a24796541496b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M generator/src/main/resources/api.rsdl
M generator/src/main/resources/api.xsd
M ovirt-engine-sdk-python.spec.in
M src/ovirtsdk/api.py
M src/ovirtsdk/infrastructure/brokers.py
M src/ovirtsdk/xml/params.py
7 files changed, 744 insertions(+), 19 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f2dac29e6563c0380ed608ea64a24796541496b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-dwh[master]: packaging: setup: set engine db credentials from config
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: set engine db credentials from config
......................................................................
packaging: setup: set engine db credentials from config
engine-setup writes the engine database credentials to the dwh db
config file, but did not read them from there on the next run, instead
asking for them again.
Change-Id: I1e07b41d2834f74d4babe6429c2ba3979a4b12ed
Bug-Url: https://bugzilla.redhat.com/1156039
Bug-Url: https://bugzilla.redhat.com/1128787
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py
1 file changed, 74 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/34427
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e07b41d2834f74d4babe6429c2ba3979a4b12ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: keep and use dwh db credentials
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: keep and use dwh db credentials
......................................................................
packaging: setup: keep and use dwh db credentials
Change-Id: I37a5d82581403e8dbd39fc07f90bd3d7c2510222
Bug-Url: https://bugzilla.redhat.com/1156040
Bug-Url: https://bugzilla.redhat.com/1118322
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 8b1a7d6b2ac3fc8d9b517b7cddb5fab8a65c4bef)
---
M Makefile
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/database.py
5 files changed, 180 insertions(+), 1 deletion(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37a5d82581403e8dbd39fc07f90bd3d7c2510222
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-reports[master]: packaging: setup: keep and use dwh db credentials
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: keep and use dwh db credentials
......................................................................
packaging: setup: keep and use dwh db credentials
Change-Id: I37a5d82581403e8dbd39fc07f90bd3d7c2510222
Bug-Url: https://bugzilla.redhat.com/1156040
Bug-Url: https://bugzilla.redhat.com/1118322
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M Makefile
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/database.py
5 files changed, 180 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/34514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37a5d82581403e8dbd39fc07f90bd3d7c2510222
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Set cloud-init user name
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Set cloud-init user name
......................................................................
restapi: Set cloud-init user name
Before version 3.5 we used to add a "user: root" line to the generated
cloud-init file if the caller provided a password for the "root" user. For
example, if the caller sent something like this:
<action>
<vm>
<initialization>
<cloud_init>
<users>
<user>
<user_name>root</user_name>
<password>mypass</password>
</user>
</users>
</cloud_init>
</initialization>
</vm>
</action>
We used to generate this cloud-init file:
#cloud-config
ssh_pwauth: true
disable_root: 0
output:
all: '>> /var/log/cloud-init-output.log'
user: root
password: mypass
...
But starting with 3.5 we no longer generate the "user:root" line. This means
that cloud-init will assume that it has to change the password for its default
user, as defined in "/etc/cloud/cloud.cfg". For Fedora it is "fedora" and for
CentOS and RHEL it is "cloud-user".
The net result is that where we used to change the "root" password we now
change the "fedora" or "cloud-init" password.
To avoid this issue this patch restores the old behaviour.
Change-Id: Id18d614612c7143a81c3d14894c9fce88de41601
Bug-Url: https://bugzilla.redhat.com/1156155
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 76da3d76cf65b4f3a98f90fa1e65661409b93f3d)
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id18d614612c7143a81c3d14894c9fce88de41601
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine-cli[master]: cli: Allow identifiers that aren't UUIDs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Allow identifiers that aren't UUIDs
......................................................................
cli: Allow identifiers that aren't UUIDs
Currently we assume that the identifiers of objects are always UUIDs, but this
isn't true, as some objects like network labels use arbitrary strings as
identifiers, and the show commands doesn't work with them:
[oVirt shell (connected)]# list labels \
--network-identifier ovirtmgmt \
--datacenter-identifier mydc
id : mylabel
[oVirt shell (connected)]# show label \
--network-identifier ovirtmgmt \
--datacenter-identifier mydc \
mylabel
============ ERROR ============
label mylabel does not exist.
===============================
This patch removes that limitation so that the show command works correctly:
[oVirt shell (connected)]# show label \
--network-identifier ovirtmgmt \
--datacenter-identifier mydc \
mylabel
id : mylabel
network-id: 4e31cd25-501e-47e4-a8b2-96b57a96a7e3
Change-Id: I2f3da6c3fd307ce9933c9d11d9ada4c4ff772e88
Bug-Url: https://bugzilla.redhat.com/1148941
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 1 insertion(+), 21 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified
--
To view, visit http://gerrit.ovirt.org/34207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3da6c3fd307ce9933c9d11d9ada4c4ff772e88
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: restapi: Set cloud-init user name
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Set cloud-init user name
......................................................................
restapi: Set cloud-init user name
Before version 3.5 we used to add a "user: root" line to the generated
cloud-init file if the caller provided a password for the "root" user. For
example, if the caller sent something like this:
<action>
<vm>
<initialization>
<cloud_init>
<users>
<user>
<user_name>root</user_name>
<password>mypass</password>
</user>
</users>
</cloud_init>
</initialization>
</vm>
</action>
We used to generate this cloud-init file:
#cloud-config
ssh_pwauth: true
disable_root: 0
output:
all: '>> /var/log/cloud-init-output.log'
user: root
password: mypass
...
But starting with 3.5 we no longer generate the "user:root" line. This means
that cloud-init will assume that it has to change the password for its default
user, as defined in "/etc/cloud/cloud.cfg". For Fedora it is "fedora" and for
CentOS and RHEL it is "cloud-user".
The net result is that where we used to change the "root" password we now
change the "fedora" or "cloud-init" password.
To avoid this issue this patch restores the old behaviour.
Change-Id: Id18d614612c7143a81c3d14894c9fce88de41601
Bug-Url: https://bugzilla.redhat.com/1156155
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id18d614612c7143a81c3d14894c9fce88de41601
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core, engine: Fix balloon detection during VM import
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core, engine: Fix balloon detection during VM import
......................................................................
core, engine: Fix balloon detection during VM import
The canDoAction method of the ImportVmCommand was not properly checking
for the presence of ballooning devices and always blocked the importing
of ppc64 VMs. This patch fixes this issue.
Change-Id: If660e368d7ec31ff1f8251d483971ffbf0bd858a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152560
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
3 files changed, 37 insertions(+), 3 deletions(-)
Approvals:
Vitor de Lima: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34382
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If660e368d7ec31ff1f8251d483971ffbf0bd858a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix balloon while creating VMs from snapshots
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix balloon while creating VMs from snapshots
......................................................................
webadmin: Fix balloon while creating VMs from snapshots
During the creation of VMs from snapshots, the memory ballooning device
was always created even when the original VM had it disabled.
This patch fixes this by passing to the AddVmFromSnapshot command the
state of the ballooning device from the original VM.
Change-Id: I263abb8f3b170e6668e2e93b79700848bf056b57
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152659
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Vitor de Lima: Verified
Tomas Jelinek: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I263abb8f3b170e6668e2e93b79700848bf056b57
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months