Change in ovirt-engine[master]: doc: README.developer: add mime.types dependency
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: doc: README.developer: add mime.types dependency
......................................................................
doc: README.developer: add mime.types dependency
Change-Id: I049b8b6faa949508915d8a3d9e1a1d40bf213d06
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M README.developer
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I049b8b6faa949508915d8a3d9e1a1d40bf213d06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Allow reboot without Guest Agent
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Allow reboot without Guest Agent
......................................................................
webadmin: Allow reboot without Guest Agent
Added check to enable reboot command when acpi is enabled even when
guest agent is not present.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1153711
Change-Id: I7e546122d27786465f355c112b218b128b357d1a
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/34271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e546122d27786465f355c112b218b128b357d1a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: Engine: set device-id in payload constructor
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: set device-id in payload constructor
......................................................................
Engine: set device-id in payload constructor
When adding a new payload its device id need to set since it is inherit
from VmDevice now -
This is true for the default constructor.
Change-Id: I33bdc975070d71923ae21985a371b53d427b61d8
Bug-Url: https://bugzilla.redhat.com/1158010
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33bdc975070d71923ae21985a371b53d427b61d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Create default disk profiles for data domains
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Create default disk profiles for data domains
......................................................................
core: Create default disk profiles for data domains
All data domains should have default disk profiles with unlimited QoS
(currently implemented by null)
Otherwise all existing data domains needs manual intervention for
creating disks if the data center is upgraded to version 3.5
Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488
Bug-Url: https://bugzilla.redhat.com/1145421
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0490_create_default_disk_profiles.sql
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: adding retry for host start for PPC
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding retry for host start for PPC
......................................................................
core: adding retry for host start for PPC
Sometimes a restart operation started by engine is not completed because
the host PM failed to put the host on 'on' state
This occurred on PPC hosts only until now.
Some fencing scripts as the one used here (IPMI) have an option to se
retries for the 'on' operation by sending : retry_on=<number>
The patch adds "retry_on=2" for the relevant PPC fencing scripts such
that this will be sent by engine as a default when a PPC host has one of
those agents used
Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-guest-agent[master]: win: Enable policy for software SAS
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win: Enable policy for software SAS
......................................................................
win: Enable policy for software SAS
On some systems the policy for enabling the Secure Attention Sequence
might not have been set or has been set to a value which would not allow
the guest agent to perform SSO.
This patch introduces setting the policy before calling 'SendSAS' and
reverting the policy to the previous value (in case it was set before).
Change-Id: Ie2b5f58e461c92e06789d46fa9113441ea48e659
Bug-Url: https://bugzilla.redhat.com/1124263
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 35 insertions(+), 7 deletions(-)
Approvals:
Martin Betak: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b5f58e461c92e06789d46fa9113441ea48e659
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Template's empty string as a disk alias UI fix.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Template's empty string as a disk alias UI fix.
......................................................................
webadmin: Template's empty string as a disk alias UI fix.
While making a new template based on a VM, providing the template's
allocated disks's alias as an empty string is now disabled ALSO BY UI.
the user should not be able to create a template with disks that have
an empty aliases- this bug has already been fixed at the BACKEND, this
current patch prevents the user from giving an empty alias at UI level.
Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Bug-Url: https://bugzilla.redhat.com/1110304
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/34477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Maximum number of VMs per user in VM Pool dialog v...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Maximum number of VMs per user in VM Pool dialog validated
......................................................................
webadmin: Maximum number of VMs per user in VM Pool dialog validated
The problem was that validation of 'Maximum number of VMs per user'
field in both 'New pool' and 'Edit pool' dialog was simple interval
[1, 32767]. So it was possible to set Max num of VMs per user higher
than total number of available VMs in pool.
Now the upper bound of Max num of VMs per user is total number of VMs
in pool. Fixed in PoolModelBehaviorBase#validate(),
CommonApplicationMessages#maxAssignedVmsPerUserHelp()
Change-Id: Ic70d45b5e8d84965691777430f8f362a68bd4830
Bug-Url: https://bugzilla.redhat.com/1124360
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
--
To view, visit http://gerrit.ovirt.org/34581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70d45b5e8d84965691777430f8f362a68bd4830
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: bll: base class for geo-rep session commands
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: bll: base class for geo-rep session commands
......................................................................
bll: base class for geo-rep session commands
Base class to be used by geo-rep session
commands
Change-Id: Id9611320c93c48080bf7f908a61bbdeb2f899513
Bug-Url: https://bugzilla.redhat.com/1125845
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 222 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/33073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9611320c93c48080bf7f908a61bbdeb2f899513
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: engine: Geo-rep monitoring
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Geo-rep monitoring
......................................................................
engine: Geo-rep monitoring
Monitoring details of geo rep sessions - detects
new sessions and updates the database
Consolidates the session status based on individual
node status
Removes sessions from database if deleted from CLI
Corrected errors with wrong session id while retrieving
from VDS and status while saving to DB.
Change-Id: I3304addda17cf49eee93f311e043b0e15212cd91
Bug-Url: https://bugzilla.redhat.com/1138116
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
M packaging/dbscripts/gluster_georep_sp.sql
A packaging/dbscripts/upgrade/03_06_0480_add_idx_gluster_georep_slavevolname.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
15 files changed, 566 insertions(+), 9 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/31976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3304addda17cf49eee93f311e043b0e15212cd91
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months