October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Suppress compiler warnings for unchecked cast
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Suppress compiler warnings for unchecked cast ...................................................................... aaa: Suppress compiler warnings for unchecked cast Suppress two compiler warnings for unchecked casts There is no more targeted approach for suppressing it properly in NegotiationFilter, hence the "unchecked" warnings are suppressed for the complete doFilter method. Topic: AAA Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with JUL as backend for notifier
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with JUL as backend for notifier ...................................................................... tools: Replace log4j with JUL as backend for notifier Replaces log4j with java.util.logging as logging backend in notifier. Change-Id: I10216f8530e23c43942cdf28fe2cb306d7e6df71 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M .gitignore M Makefile D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log4jUtils.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M ovirt-engine.spec.in A packaging/conf/notifier-logging.properties.in D packaging/etc/notifier/log4j.xml.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py 11 files changed, 36 insertions(+), 128 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10216f8530e23c43942cdf28fe2cb306d7e6df71 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with slf4j as frontend in notifier
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with slf4j as frontend in notifier ...................................................................... tools: Replace log4j with slf4j as frontend in notifier Replaces log4j with slf4j as logging frontend in classes which are used in notifier. Change-Id: Ibc192c7f10d7f9a124d2899118f6c5c7126b7230 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/ShutdownHook.java 7 files changed, 54 insertions(+), 52 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc192c7f10d7f9a124d2899118f6c5c7126b7230 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with JUL as backend for engine-config
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with JUL as backend for engine-config ...................................................................... tools: Replace log4j with JUL as backend for engine-config 1) Replaces log4j with java.util.logging as logging backend in engine-config. 2) Removes --log4j-config param from engine-config. It's not needed anymore, because custom logging configuration can be specified using OVIRT_LOGGING_PROPERTIES environment variable. Change-Id: I2b340115f68cf88b6ebd3166044f974fed9e798b Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/OptionKey.java M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml D backend/manager/tools/src/main/resources/engine-config/log4j.xml M packaging/bin/engine-config.sh M packaging/man/man8/engine-config.8 8 files changed, 24 insertions(+), 62 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b340115f68cf88b6ebd3166044f974fed9e798b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace oVirt logger with slf4j as frontend in engine...
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace oVirt logger with slf4j as frontend in engine-config ...................................................................... tools: Replace oVirt logger with slf4j as frontend in engine-config Replaces oVirt logger with slf4j as logging frontend in classes which are used in engine-config tool. Change-Id: I1aeac803a58fc74919c88ac8c7ac4e3084747ce9 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java 2 files changed, 10 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aeac803a58fc74919c88ac8c7ac4e3084747ce9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with slf4j as frontend in engine-config
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with slf4j as frontend in engine-config ...................................................................... tools: Replace log4j with slf4j as frontend in engine-config Replaces log4j with slf4j as logging frontend in classes which are used in engine-config tool. Change-Id: Idc3d2a507f51c11b468c6af33a8f714545d3d695 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/GetValidator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/SetValidator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/ToolConsole.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigLogicTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java 9 files changed, 55 insertions(+), 44 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc3d2a507f51c11b468c6af33a8f714545d3d695 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with JUL as backend for manage-domains
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with JUL as backend for manage-domains ...................................................................... tools: Replace log4j with JUL as backend for manage-domains 1) Replaces log4j with java.util.logging as logging backend in engine-manage-domains. 2) Removes --log4j-config param from engine-manage-domains. It's not needed anymore, because custom logging configuration can be specified using OVIRT_LOGGING_PROPERTIES environment variable. Change-Id: I16afc336c26615978392f7d4ff911bf646c42df6 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml D backend/manager/modules/builtin-extensions/src/main/resources/engine-manage-domains/log4j.xml M backend/manager/modules/builtin-extensions/src/main/resources/manage-domains-help.properties M backend/manager/modules/utils/pom.xml D backend/manager/modules/utils/src/main/resources/engine-manage-domains/log4j.xml M packaging/bin/engine-manage-domains.sh M packaging/man/man8/engine-manage-domains.8 9 files changed, 21 insertions(+), 116 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16afc336c26615978392f7d4ff911bf646c42df6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Adds helpers to configure java logging in tools
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Adds helpers to configure java logging in tools ...................................................................... tools: Adds helpers to configure java logging in tools 1) Adds helper classes to configure java.util.logging in tools using command line parameters 2) Adds tools-logging.properties with default logging configuration for tools 3) Adds OVIRT_LOGGING_PROPERTIES environment variable which can be set by user to provide custom logging configuration Change-Id: Ie1c46ca552888b347a4ff810003e0fcc818f832f Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java M ovirt-engine.spec.in M packaging/bin/engine-prolog.sh.in A packaging/conf/tools-logging.properties 4 files changed, 79 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1c46ca552888b347a4ff810003e0fcc818f832f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace oVirt logger with slf4j as frontend in engine...
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace oVirt logger with slf4j as frontend in engine-manage-domains ...................................................................... tools: Replace oVirt logger with slf4j as frontend in engine-manage-domains Replaces oVirt logger with slf4j as logging frontend in classes which are used in engine-manage-domains tool. Change-Id: I82996f8f6ad3b7111b5bb36d46a395d94dd70e80 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82996f8f6ad3b7111b5bb36d46a395d94dd70e80 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Replace log4j with slf4j as frontend in engine-manage...
by yzaslavs＠redhat.com 12 Oct '14

12 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Replace log4j with slf4j as frontend in engine-manage-domains ...................................................................... tools: Replace log4j with slf4j as frontend in engine-manage-domains Replaces log4j with slf4j as logging frontend in classes which are used in engine-manage-domains tool. Change-Id: Ic271b2d29e31abcf7bc1ca7e8f5a7c7e95fdfcf8 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/JndiAction.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KerberosConfigCheck.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KrbConfCreator.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ConfigurationProvider.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsResult.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/StandaloneDataSource.java 9 files changed, 47 insertions(+), 39 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic271b2d29e31abcf7bc1ca7e8f5a7c7e95fdfcf8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0