December 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Filter import block storage domains by LUN id

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Filter import block storage domains by LUN id ...................................................................... core: Filter import block storage domains by LUN id Patch Id82e5e1d3df8ce265833efb3fc4b9050ca73b679 introduced filtering and blocking import of an existing block domain by its PV id. The hosted engine setup only populates the LUN id of the hosted engine disk thus the filtering was changed to be based on the LUN id Change-Id: Ic1082319e68e8c5a42f8f177e13d662829753f8c Bug-Url: https://bugzilla.redhat.com/1157243 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 3 files changed, 6 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1082319e68e8c5a42f8f177e13d662829753f8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Filter import block storage domains by LUN id

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Filter import block storage domains by LUN id ...................................................................... core: Filter import block storage domains by LUN id Patch Id82e5e1d3df8ce265833efb3fc4b9050ca73b679 introduced filtering and blocking import of an existing block domain by its PV id. The hosted engine setup only populates the LUN id of the hosted engine disk thus the filtering was changed to be based on the LUN id Change-Id: Ic1082319e68e8c5a42f8f177e13d662829753f8c Bug-Url: https://bugzilla.redhat.com/1157243 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 3 files changed, 6 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1082319e68e8c5a42f8f177e13d662829753f8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fix a bug in edit storage domain

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix a bug in edit storage domain ...................................................................... webadmin: Fix a bug in edit storage domain Patch I4e0d5a1c9158be1284ffe05d1bf1397c9113f6c0 introduced the wipe_after_delete column in storage_domain_static table with a NOT NULL constraint. The edit storage domain operation in webadmin clones the editted object and sends it to the engine for the entity updated, however, the clone storage domain method did not clone the item correctly and omitted the wipe after delete property from the clone thus sending null instead of the original value, causing the update to fail with a NOT NULL constraint Change-Id: Ia49b3460af6231356b7255d8b6322c98eef59406 Bug-url: https://bugzilla.redhat.com/1177931 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia49b3460af6231356b7255d8b6322c98eef59406 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Send net_ifacename to VDSM when connecting iSCSI server

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server ...................................................................... engine: Send net_ifacename to VDSM when connecting iSCSI server In order to properly configure iSCSI multipathing each iSCSI iface should be related to the real network interface. Software iSCSI knows how to relate iface to the network interface when all network interfaces on that host reside on different subnets see [1]. However if multiple NICs reside on the same subnet iSCSI iface configuration must contain a "iface.net_ifacename" representing a name of the network layer interface, in case this network is bridged then it should be a name of the bridge. [1] http://www.open-iscsi.org/docs/README section 5.1.1. Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Bug-Url: https://bugzilla.redhat.com/1112861 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 3 files changed, 24 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: make VdcReturnValueBase#getActionReturnValue generic

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: make VdcReturnValueBase#getActionReturnValue generic ...................................................................... core: make VdcReturnValueBase#getActionReturnValue generic Make the return type generic to reduce castings. Change-Id: I64fb1df69ea491ce587ef4844807ef8f44b34412 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64fb1df69ea491ce587ef4844807ef8f44b34412 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: fix engine conf for reports access for devenv

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix engine conf for reports access for devenv ...................................................................... packaging: setup: fix engine conf for reports access for devenv Write 10-setup-reports-access.conf relative to PREFIX and not hard coded to /etc. Fix https port. Change-Id: Ieb36563860828bd3d9309e7615380f43c588c674 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M Makefile M ovirt-engine-reports.spec.in M packaging/services/ovirt-engine-reportsd/config.py.in M packaging/setup/ovirt_engine_setup/reports/config.py.in M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 6 files changed, 11 insertions(+), 6 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb36563860828bd3d9309e7615380f43c588c674 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add missing constructor in GetDiskByDiskIdQuery

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: add missing constructor in GetDiskByDiskIdQuery ...................................................................... core: add missing constructor in GetDiskByDiskIdQuery Add constructor that receives EngineContext for internal execution. Change-Id: If7e07f61b7e7bfd133732049207f986996a0dced Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskByDiskIdQuery.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e07f61b7e7bfd133732049207f986996a0dced Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: preventing NPE on StorageServerConnectionCommandBase

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: preventing NPE on StorageServerConnectionCommandBase ...................................................................... core: preventing NPE on StorageServerConnectionCommandBase Currently we allow to added FCP connections although they aren't supported in oVirt - this has been changed by change 2f7c846 as was required because of how we store the connections password in the DB. After this change in case of added FCP connection, NPE will occur. This patch fixes that by restoring the previous state, we may block adding FCP connections regardless (as having them isn't supported/used by the engine). Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Bug-Url: https://bugzilla.redhat.com/1176578 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/36456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: preventing NPE on StorageServerConnectionCommandBase

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: core: preventing NPE on StorageServerConnectionCommandBase ...................................................................... core: preventing NPE on StorageServerConnectionCommandBase Currently we allow to added FCP connections although they aren't supported in oVirt - this has been changed by change 2f7c846 as was required because of how we store the connections password in the DB. After this change in case of added FCP connection, NPE will occur. This patch fixes that by restoring the previous state, we may block adding FCP connections regardless (as having them isn't supported/used by the engine). Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: Revert "core: supress findbugs warning in StorageServerConne...

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: Revert "core: supress findbugs warning in StorageServerConnectionCommandBase" ...................................................................... Revert "core: supress findbugs warning in StorageServerConnectionCommandBase" This reverts commit b9779fd9ede7950fe058efe29c706f8a150f7333. Change-Id: I6408c9dfe053a37c57011596364ae6cb6d825323 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6408c9dfe053a37c57011596364ae6cb6d825323 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2014