Change in ovirt-engine[master]: tools: notifier: Refactor model and DB mapping of eventNotif...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: tools: notifier: Refactor model and DB mapping of eventNotificationMethods.
......................................................................
tools: notifier: Refactor model and DB mapping of eventNotificationMethods.
Main change in this patch set is storing eventNotificationMethods
as enum in java objects and as an sql string in the event_subscribers
table(and not int). The mapping is easier and the db is human readable.
Another side effect of this change is there is no more need for
some mapping classes deleted in this patch. They are all replaced
by the simpler NotificationMethodsMapper. The table
event_notification_methods was dropped since it duplicates the enum
eventNotificationMethods and replaced by new an sql CHECK constraint.
Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethods.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventAuditLogSubscriber.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventNotificationMethod.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber_id.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/EventMethodFiller.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactory.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactoryEmailImpl.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodMapBuilder.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationMethodsMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/event_sp.sql
M packaging/dbscripts/insert_data.sql
A packaging/dbscripts/upgrade/03_05_0030_event_notification_methods.sql
23 files changed, 113 insertions(+), 559 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: tools: notifier: fix NotificationPropertiesTest.
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: tools: notifier: fix NotificationPropertiesTest.
......................................................................
tools: notifier: fix NotificationPropertiesTest.
Call NotificationProperties.release() so we do not
get a stale copy of Notification Properties.
(Set default and get instance are not enough
if the current class loader has a copy of
NotificationProperties with an old instance
we will get that one!)
also enable NotificationPropertiesTest to run both under maven and straight
from source thus speeding up testing during development.
Change-Id: Ia3488856323577e3db6c779d86c190e064e15c97
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationPropertiesTest.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3488856323577e3db6c779d86c190e064e15c97
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: utils: LocalConfig: add getProperty with an optionalSuffix S...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: utils: LocalConfig: add getProperty with an optionalSuffix String.
......................................................................
utils: LocalConfig: add getProperty with an optionalSuffix String.
public String getProperty(String key, String optionalSuffix, boolean allowMissing);
Returns the value associated with key_optionalSuffix if it is defined or the one
associated with key. If both are missing and allowMissing = false throws an
IllegalStateException.
Change-Id: Ic37b6aa5ce44600fc647915b9f71632c98bbbae3
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocalConfigTest.java
M backend/manager/modules/utils/src/test/resources/localconfig.conf
M backend/manager/modules/utils/src/test/resources/localconfig.conf.ref
4 files changed, 53 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic37b6aa5ce44600fc647915b9f71632c98bbbae3
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: update LUN device size using getVmStats
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: update LUN device size using getVmStats
......................................................................
core: update LUN device size using getVmStats
* Handling DirecLUN disks manual resize (user invoked)
by synchronizing LUNs device sizes upon powering up a VM.
* Similar to disk images, utilized VdsUpdateRunTimeInfo
in order to retrieve updated information from getVmStats.
* Added buildVmLunDisksData method to VdsBrokerObjectsBuilder
for de-serializing relevant LUNs data from getVmStats.
* For using batch update, LunDAODbFacadeImpl now extends
MassOperationsGenericDaoDbFacade.
Note: the functionality is depended on VDSM patch -
http://gerrit.ovirt.org/24235
Change-Id: Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8
Bug-Url: https://bugzilla.redhat.com/1026868
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
10 files changed, 249 insertions(+), 32 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: fix NPE when migration caused by maintenance fails
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix NPE when migration caused by maintenance fails
......................................................................
core: fix NPE when migration caused by maintenance fails
On failure to migrate VM from VDS which is going to maintenance, we got
NPE in ExecutionHandler while trying to end the job.
The solution is to pass the job from the MaintenanceVds command to the
InternalMigrateVm command it invokes as well.
Change-Id: If1bde265b078997507ad7f7e4b00fbd024cc3c39
Bug-Url: https://bugzilla.redhat.com/1053884
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1bde265b078997507ad7f7e4b00fbd024cc3c39
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: show hosted engine info in host>general tab
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: show hosted engine info in host>general tab
......................................................................
webadmin: show hosted engine info in host>general tab
Display a single entry in the host > general tab displaying hosted
engine status, if it is configured on the selected host.
Change-Id: I17f0eff120b2ab99b4badc53da1780c1e758299c
Bug-Url: https://bugzilla.redhat.com/1047649
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
6 files changed, 81 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Greg Padgett: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24606
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17f0eff120b2ab99b4badc53da1780c1e758299c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin, backend: control of hosted engine maintenance mode
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin, backend: control of hosted engine maintenance mode
......................................................................
webadmin, backend: control of hosted engine maintenance mode
Allow control of hosted engine local/global maintenance. Global
maintenance is performed via right-clicking on the host, while local
maintenance is tied into the existing host vds maintenance operation.
Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74
Bug-Url: https://bugzilla.redhat.com/1047649
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetHaMaintenanceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetHaMaintenanceParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HaMaintenanceMode.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetHaMaintenanceModeVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/03_05_0040_add_ha_maintenance_events.sql
26 files changed, 395 insertions(+), 7 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Greg Padgett: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Rephrase CDA message when removing a last copy of a te...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Rephrase CDA message when removing a last copy of a template disk
......................................................................
core: Rephrase CDA message when removing a last copy of a template disk
Change-Id: I42e2fefb8ba95bd7e83de75d1d90ff5eef2cb102
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/975040
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Liron Ar: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42e2fefb8ba95bd7e83de75d1d90ff5eef2cb102
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: backend, db: store additional hosted engine info
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: backend, db: store additional hosted engine info
......................................................................
backend, db: store additional hosted engine info
New fields for hosted engine, allowing UI display/control of maintenance
operations. Adds:
ha_configured - HA is installed on the host
ha_active - HA is currently running/updating on the host
ha_global_maintenance - HA global maintenance is enabled according to
the host
ha_local_maintenance - HA local maintenance is enabled on the host
Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210
Bug-Url: https://bugzilla.redhat.com/1047649
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_05_0030_add_ha_columns_to_vds_statistics.sql
M packaging/dbscripts/vds_sp.sql
10 files changed, 202 insertions(+), 23 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Greg Padgett: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Remove the general provider type
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Remove the general provider type
......................................................................
core: Remove the general provider type
The general provider type is redundant and is not used anymore.
It was used in the past as an attempt to perform auto detection
to learn about the ldap vendor, but this mechanism was already depracated.
Bug-Url: https://bugzilla.redhat.com/1058011
Change-Id: I3414673e2300d44a30ad00ac2acf6762bcdb0700
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RootDSEFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java
7 files changed, 8 insertions(+), 49 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3414673e2300d44a30ad00ac2acf6762bcdb0700
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months