February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddDiskCommand - added disk can never be a disk snapshot
by laravot＠redhat.com 19 Feb '14

19 Feb '14

Liron Ar has submitted this change and it was merged. Change subject: core: AddDiskCommand - added disk can never be a disk snapshot ...................................................................... core: AddDiskCommand - added disk can never be a disk snapshot When adding a disk the added disk can never be a disk snapshot, Currently when adding DiskImages the disk's Image object is "active" member has a default value of false, which leads to wrongly treat that disk as a disk snapshot through validations rather than a regular added disk. Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix duplicate db scripts
by ahadas＠redhat.com 19 Feb '14

19 Feb '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix duplicate db scripts ...................................................................... core: fix duplicate db scripts Change-Id: I64435078ef5ab21638a5b17a2f4b20df730715fa Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- R packaging/dbscripts/upgrade/03_05_0050_event_notification_methods.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64435078ef5ab21638a5b17a2f4b20df730715fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove userActionsGroup from ActionGroup enum
by derez＠redhat.com 19 Feb '14

19 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: remove userActionsGroup from ActionGroup enum ...................................................................... core: remove userActionsGroup from ActionGroup enum Remove unused userActionsGroup member and getter. Change-Id: Ifd2c3c2dfb2db8b8c07a1d9f505099b90667febc Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd2c3c2dfb2db8b8c07a1d9f505099b90667febc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove VdcObjectType from ActionGroup enum
by derez＠redhat.com 19 Feb '14

19 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: remove VdcObjectType from ActionGroup enum ...................................................................... core: remove VdcObjectType from ActionGroup enum VdcObjectType in ActionGroup enum is unused by any component. Hence, removing it from the enum along with unused 'entityToActionGroupsMapping'. Change-Id: Ib40e8aab37ea11c463f03e25e1e48495db17ca1e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 1 file changed, 79 insertions(+), 96 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Daniel Erez: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib40e8aab37ea11c463f03e25e1e48495db17ca1e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core : FullListVdsCommand log message appears wrong with jav...
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core : FullListVdsCommand log message appears wrong with java class ref ...................................................................... core : FullListVdsCommand log message appears wrong with java class ref FullListVdsCommand FINISH log message has unexpanded data and prints the class reference instead of the data. Change-Id: I0d6ff48e2c5a25dd659a8777b70fdcaaa9a3d840 Bug-Url: https://bugzilla.redhat.com/1054410 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d6ff48e2c5a25dd659a8777b70fdcaaa9a3d840 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: Support snmp trap as a notification method.
by emesika＠redhat.com 18 Feb '14

18 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: Support snmp trap as a notification method. ...................................................................... tools: notifier: Support snmp trap as a notification method. See feature pages[1] [1] http://www.ovirt.org/Features/engine-snmp Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032661 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/snmp4j/main/module.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java M backend/manager/tools/pom.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml M ovirt-engine.spec.in M packaging/dbscripts/upgrade/03_05_0030_event_notification_methods.sql M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M pom.xml 11 files changed, 266 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 41 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: implement and use transport.idle().
by emesika＠redhat.com 18 Feb '14

18 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: implement and use transport.idle(). ...................................................................... tools: notifier: implement and use transport.idle(). As part of transitioning to more then one Transport, It is no longer possible to let a transport sleep and retry for as long as it wants. that might starve other transports especially in a short notification interval. Retrying transports (those that can detect sending failures) Should implement a queue and attempt to send it on idle. This patch also fixes a bug where smtp loging is done only before the first send attempt. Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1051492 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/ShutdownHook.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 8 files changed, 209 insertions(+), 110 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: simple first match include/exclude.
by emesika＠redhat.com 18 Feb '14

18 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: simple first match include/exclude. ...................................................................... tools: notifier: simple first match include/exclude. See feature page[1] [1] http://www.ovirt.org/Features/configuration-event-subscribers Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLogEventSubscriber.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventFilter.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UpDownEventFilter.java D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationMethodsMapper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/DispatchResult.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/AuditLogEvent.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/AuditLogEventType.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/EventSenderResult.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Observable.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Observer.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/EventMessageContent.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/MessageHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java M backend/manager/tools/src/test/resources/conf/notifier-prop-test.conf M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 21 files changed, 988 insertions(+), 472 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: extract MAIL_RETRIES to configuration
by emesika＠redhat.com 18 Feb '14

18 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: extract MAIL_RETRIES to configuration ...................................................................... tools: notifier: extract MAIL_RETRIES to configuration Change-Id: I72d4f48c44d0dff70963394b2657a833449812bb Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved mooli tayer: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d4f48c44d0dff70963394b2657a833449812bb Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: remove sql link between notification_subscr...
by emesika＠redhat.com 18 Feb '14

18 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: remove sql link between notification_subscribers and users. ...................................................................... tools: notifier: remove sql link between notification_subscribers and users. This is done in preperation to snmp notifications which have no connections to engine users. This includes removing subscriber_id from event_notification_hist and not using a users email instead of a notification_subscriber email. Change-Id: Ibb91d064c5ecec5b335c32636ac432299c5f96f6 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java M packaging/dbscripts/event_sp.sql M packaging/dbscripts/upgrade/03_05_0030_event_notification_methods.sql 3 files changed, 18 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/24299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb91d064c5ecec5b335c32636ac432299c5f96f6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0