Change in ovirt-engine[ovirt-engine-3.4]: core, engine: Add more OSes for the ppc64 architecture
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core, engine: Add more OSes for the ppc64 architecture
......................................................................
core, engine: Add more OSes for the ppc64 architecture
This change includes more OSes which are compatible with the ppc64
architecture. Currently only SLES and RHEL are added in osinfo.
Change-Id: Ib0c0915e6ba803640d97a83e1d47b0541f19288c
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
M packaging/conf/osinfo-defaults.properties
2 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
Gustavo Frederico Temple Pedrosa: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0c0915e6ba803640d97a83e1d47b0541f19288c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: engine-backup: align db creation instructions wit...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: engine-backup: align db creation instructions with dwh
......................................................................
packaging: engine-backup: align db creation instructions with dwh
Replace 'create user' with 'create role'.
Also add a missing quote.
Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478
Bug-Url: https://bugzilla.redhat.com/1040572
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core: [Fix] NPE in GlusterSyncJob
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: [Fix] NPE in GlusterSyncJob
......................................................................
core: [Fix] NPE in GlusterSyncJob
Add validation for corrupt brick(s).
Change-Id: I0c0209683ab1fc4c837c23d4223278582fc0f920
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Gustavo Frederico Temple Pedrosa: Verified
Sahina Bose: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c0209683ab1fc4c837c23d4223278582fc0f920
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: restapi: Remove unnecessary code
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Remove unnecessary code
......................................................................
restapi: Remove unnecessary code
Change-Id: I69c64fa6e5da2fe68a65f200c04690e39fb831ae
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlIOManager.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69c64fa6e5da2fe68a65f200c04690e39fb831ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: restapi: Add ability to extract rsdl.xml from jar
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Add ability to extract rsdl.xml from jar
......................................................................
restapi: Add ability to extract rsdl.xml from jar
A previous patch moved RSDL generation to build time.
This patch adds a class with a main() method which
copies rsdl.xml, rsdl_gluster.xml and api.xsd to the
desired directory.
The idea behind this, is that sdk generation will be
done completely automatically by maven goals. To copy
the files mentioned above (to a directory named, for
example, '/service') - add the following configuration
to pom.xml of any project that depends on
restapi-definition:
<profile>
<id>build-rsdl</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<phase>compile</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<mainClass>org.ovirt.engine.api.rsdl.RsdlIOManager</mainClass>
<arguments>
<argument>/service</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
Change-Id: I11834dac081e17c702c614ae923575a3debba6eb
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/pom.xml
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlIOManager.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
4 files changed, 77 insertions(+), 11 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11834dac081e17c702c614ae923575a3debba6eb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Block cluster change if network labels not supported
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Block cluster change if network labels not supported
......................................................................
engine: Block cluster change if network labels not supported
Network labels are supported only if setup networks is
supported by the cluster level. Therefore a host which
has network labels shouldn't be moved to a cluster which
doesn't support it, without removing the labels from the
nics.
Change-Id: I918905e2e5ca01726a0a647109b11e1bbeb5596a
Bug-Url: https://bugzilla.redhat.com/1063285
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 36 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I918905e2e5ca01726a0a647109b11e1bbeb5596a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: Fix storage domain details in Edit VM Disk window
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Fix storage domain details in Edit VM Disk window
......................................................................
webadmin: Fix storage domain details in Edit VM Disk window
This window displayed storage domain based on volume type instead of the
storage domain of that disk.
Change-Id: I78c4cf073063b0f5cdd8d76423bd5ce18cd9e27e
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
3 files changed, 22 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Sergey Gotliv: Verified
--
To view, visit http://gerrit.ovirt.org/24559
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78c4cf073063b0f5cdd8d76423bd5ce18cd9e27e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: core: Prevent StopVm to interleave with other VM locked actions
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Prevent StopVm to interleave with other VM locked actions
......................................................................
core: Prevent StopVm to interleave with other VM locked actions
Stop and Shutdown VM commands are calling the DestoryVds command which is contending on
the VdsManager lock. The lock is implemented as synchronized (object) -
this means that order isn't kept and we're subjected to JVM's scheduling
descisions so other commands, like RunVm can take the lock and result the Vm to stop instead of start
Fix: take an exclusive engine lock on Stop and Shutdown commands
This will also prevent a situation where asyncRunningVms has an entry
although the VM is down.
Bug-Url: https://bugzilla.redhat.com/1064859
Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
3 files changed, 20 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24376
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Initialize MAC pool partially
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Initialize MAC pool partially
......................................................................
engine: Initialize MAC pool partially
If MAC pool exceeds the maximum then we will initialize it until its
full. An error is being written to the log in this case.
The partial initialization will prevent an OOM in case of a really big
range (not entirely though, this will be fixed in the future).
Change-Id: I0547509eb81a51599e2342503c9f108df1fa47c7
Bug-Url: https://bugzilla.redhat.com/1065011
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
(cherry picked from commit ee37b7289f9d1a6c2b803a3650995c4127876131)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
2 files changed, 14 insertions(+), 10 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0547509eb81a51599e2342503c9f108df1fa47c7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Update pending counters in two ommited cases
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: engine: Update pending counters in two ommited cases
......................................................................
engine: Update pending counters in two ommited cases
The code missed two code paths that resulted in a VM being scheduled
with no update to the pending counters.
- no or empty cluster policy
- preselected host (scheduling only verified the contraints)
Change-Id: I750dadcca53e402a91bd8b36e68ee730fe177278
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062996
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, approved
Arik Hadas: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I750dadcca53e402a91bd8b36e68ee730fe177278
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months