February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: removing a redundant function from common.sp
by emesika＠redhat.com 17 Feb '14

17 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: removing a redundant function from common.sp ...................................................................... core: removing a redundant function from common.sp The removed function is not used at any of db scripts or via the java code Change-Id: Iae83bcfeb2741bd4e8f0c2f82ba6f631e35fca75 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 0 insertions(+), 38 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/24529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae83bcfeb2741bd4e8f0c2f82ba6f631e35fca75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify EnableMACAntiSpoofing version to general
by masayag＠redhat.com 17 Feb '14

17 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify EnableMACAntiSpoofing version to general ...................................................................... engine: Modify EnableMACAntiSpoofing version to general There used to be a mix in the declaration and usage of MacAntiSpoofingFilterRulesSupported configuration value which allowed the user to determine in which cluster level the feature should be used. This should be determined by the engine itself and not by the user. Therefore the versioning is removed from this parameter which will define for the entire system if no-mac-spoofing filter should be applied to running vms or not. Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf Bug-Url: https://bugzilla.redhat.com/1063711 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 16 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: packaging: configuration cleanups
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: configuration cleanups ...................................................................... packaging: configuration cleanups - install isouploader.conf with 0640 access mode - avoid to install hidden empty files for creating an empty configuration directory Change-Id: I015e614821c21715c99af0abe398687bb2e39422 Bug-Url: https://bugzilla.redhat.com/1058807 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-iso-uploader.spec.in D src/.keep M src/Makefile.am 3 files changed, 4 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I015e614821c21715c99af0abe398687bb2e39422 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: packaging: configuration cleanups
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: configuration cleanups ...................................................................... packaging: configuration cleanups - install isouploader.conf with 0640 access mode - avoid to install hidden empty files for creating an empty configuration directory Change-Id: I015e614821c21715c99af0abe398687bb2e39422 Bug-Url: https://bugzilla.redhat.com/1058807 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-iso-uploader.spec.in D src/.keep M src/Makefile.am 3 files changed, 4 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I015e614821c21715c99af0abe398687bb2e39422 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: extending valid email addressed
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: extending valid email addressed ...................................................................... packaging: setup: extending valid email addressed Bug-Url: https://bugzilla.redhat.com/1065269 Change-Id: Id4e84e36080ea7dc49b8577fa2d431c3bb3b959c Signed-off-by: Giorgio Bersano <giorgio.bersano(a)patrimoniosettimo.it> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f3461647d317b243319a1b03c9338e6699a019f3) --- M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e84e36080ea7dc49b8577fa2d431c3bb3b959c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: extending valid email addressed
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: extending valid email addressed ...................................................................... packaging: setup: extending valid email addressed Bug-Url: https://bugzilla.redhat.com/1065269 Change-Id: Id4e84e36080ea7dc49b8577fa2d431c3bb3b959c Signed-off-by: Giorgio Bersano <giorgio.bersano(a)patrimoniosettimo.it> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e84e36080ea7dc49b8577fa2d431c3bb3b959c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Resolve hosts in --ldap-servers in engine-manage-domains
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Resolve hosts in --ldap-servers in engine-manage-domains ...................................................................... tools: Resolve hosts in --ldap-servers in engine-manage-domains Tries to resolve hosts specified in argument --ldap-servers during add/edit action in engine-manage-domains. If some host cannot be resolved, warning is logged and displayed in console. Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d Bug-URL: https://bugzilla.redhat.com/1001976 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 24 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix admin@internal permissions
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix admin@internal permissions ...................................................................... core: Fix admin@internal permissions Fix permissions for admin@internal user by setting last_admin_check_status to true. The same is done in AddPermissionCommand if admin role is assigned to user. Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43 Bug-Url: https://bugzilla.redhat.com/1057087 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0580_fix_admin_internal_permissions.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix permissions for users added by engine-manage-domains
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Fix permissions for users added by engine-manage-domains ...................................................................... tools: Fix permissions for users added by engine-manage-domains Fix permissions for users added by engine-manage-domains by setting last_admin_check_status to true. The same is done in AddPermissionCommand if admin role is assigned to user. Change-Id: Id7565f00d26cf641efd82aa5508deece9f4ee7cf Bug-Url: https://bugzilla.redhat.com/1057087 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7565f00d26cf641efd82aa5508deece9f4ee7cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Allow manual fence in connecting state
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Allow manual fence in connecting state ...................................................................... core: Allow manual fence in connecting state Allow to manually fence a Host that is in Connecting state. Up to now, when host had a network problem, it was switched to Connecting state for 3 attempts, after those attempts, if host was still unreachable, the host was turned to non-responding status. During the Connecting status, if you would try to manually fence the host, you would get an error saying: "Due to intermittent connectivity to this Host, fence operations are not allowed at this time. The system is trying to reconnect, please try again in 30 seconds." If an outage problem occurs, this limitation forces us to wait for all 3 network reconnect attempts before we can confirm that the host was rebooted and perform a manual fence (which can take several minutes) This patch removes this limitation and allow manually fencing a host that is in the Connecting state. Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1044089 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0