March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-3.4]: config: Fix typo in logcollector.conf
by sbonazzo＠redhat.com 12 Mar '14

12 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: Fix typo in logcollector.conf ...................................................................... config: Fix typo in logcollector.conf Change-Id: I10cff4cd69af163bf96a4333fdfde8ff6bac884e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> (cherry picked from commit 07f48d0d1b143b6e86b6e98f69ba286d208a6a81) --- M src/logcollector.conf 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10cff4cd69af163bf96a4333fdfde8ff6bac884e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: config: Fix typo in logcollector.conf
by sbonazzo＠redhat.com 12 Mar '14

12 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: Fix typo in logcollector.conf ...................................................................... config: Fix typo in logcollector.conf Change-Id: I10cff4cd69af163bf96a4333fdfde8ff6bac884e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M src/logcollector.conf 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10cff4cd69af163bf96a4333fdfde8ff6bac884e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: fix aaa animal sniffer
by yzaslavs＠redhat.com 12 Mar '14

12 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: build: fix aaa animal sniffer ...................................................................... packaging: build: fix aaa animal sniffer Topic: AAA Change-Id: I674e628f5dbc52184f139ba344631114e89f9224 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/pom.xml 1 file changed, 27 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I674e628f5dbc52184f139ba344631114e89f9224 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: VURTI - fix handle expection in GetVmStats
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: VURTI - fix handle expection in GetVmStats ...................................................................... core: VURTI - fix handle expection in GetVmStats after getting all vms with List command, VURTI loops through them to update internal structure data. BUT if the call fails, VURTI removes the VM from the internal running map - this leads to a split-brains for VURTI assumes the Vm is DOWN and if it HA, its runs it. the fix is to exclude this Vm from the list of the vms that have changed this is similar to a case where Vm didn't changed its status UNIT TEST added a unit test to make sure the VM is kept in the map although the call to GetVmStats didn't made it Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 177 insertions(+), 31 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: VURTI - use ResourceManager instead of commands
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: VURTI - use ResourceManager instead of commands ...................................................................... core: VURTI - use ResourceManager instead of commands Use ResourceManager instead of direct command invocation Add List, GetVmStats and GetAllVmsStats to the list of Command Types Clean-up the code expressions, format, indent etc Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 49 insertions(+), 49 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Change Vm status on destroy only for SRC VMs
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Change Vm status on destroy only for SRC VMs ...................................................................... core: Change Vm status on destroy only for SRC VMs when stopping a migrating VMs, do the state change only if the VM is really running on SRC host. StopVm shoots 2 destroy commands incase the vm is migrating - 1 for the DST and one for the SRC. after the DST is destroy the Vm must not be DOWN, otherwise an interleaving RunVm could start it while we're about to shoot the next stop. that solution is reverting change I6109ef0ea4869b59a93be6fef4b0c3cff50da62e which implemented that with an engine lock Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Bug-Url: https://bugzilla.redhat.com/1064859 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Change Vm status on destroy only for SRC VMs
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Change Vm status on destroy only for SRC VMs ...................................................................... core: Change Vm status on destroy only for SRC VMs when stopping a migrating VMs, do the state change only if the VM is really running on SRC host. StopVm shoots 2 destroy commands incase the vm is migrating - 1 for the DST and one for the SRC. after the DST is destroy the Vm must not be DOWN, otherwise an interleaving RunVm could start it while we're about to shoot the next stop. that solution is reverting change I6109ef0ea4869b59a93be6fef4b0c3cff50da62e which implemented that with an engine lock Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Bug-Url: https://bugzilla.redhat.com/1064859 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: Revert "core: Prevent StopVm to interleave with other VM loc...
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: Revert "core: Prevent StopVm to interleave with other VM locked actions" ...................................................................... Revert "core: Prevent StopVm to interleave with other VM locked actions" This reverts commit 37411acc82c03ba8e3150e5d9b4aad2e6d39a414. Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 3 files changed, 1 insertion(+), 20 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Revert "core: Prevent StopVm to interleave with other VM loc...
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: Revert "core: Prevent StopVm to interleave with other VM locked actions" ...................................................................... Revert "core: Prevent StopVm to interleave with other VM locked actions" This reverts commit 37411acc82c03ba8e3150e5d9b4aad2e6d39a414. in retrospective there is a much simpler and less intrusive solution[1] and it was noted this fix will cause restoreStatless to fail sense it will fail to take the vm lock on destory [1] the replacement fix - 42bdcd9 Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 3 files changed, 1 insertion(+), 20 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Relaxed slave interface validation
by iheim＠redhat.com 12 Mar '14

12 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Relaxed slave interface validation ...................................................................... engine: Relaxed slave interface validation Validation used to demand that no boot protocol, IP address etc. be defined on the slave interfaces, whereas this seems to be quite common when using Fedora 19 hosts. This is erased by VDSM anyway, so there's no real reason to block this on the engine side. Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711 Bug-Url: https://bugzilla.redhat.com/1051297 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit ddcfde17201e20901ba37ac1a4869fe8bc5a206c) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0