March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Removal of authenticator classes
by yzaslavs＠redhat.com 13 Mar '14

13 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Removal of authenticator classes ...................................................................... aaa: Removal of authenticator classes The methods are consolidated to the Authenticator class Topic: AAA Change-Id: If3a6f8586bdb14fcc6c09c77dc1b761b795fce07 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/NegotiatingAuthenticator.java D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/PasswordAuthenticator.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/header/HeaderAuthenticator.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticator.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Extension.java 10 files changed, 97 insertions(+), 87 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a6f8586bdb14fcc6c09c77dc1b761b795fce07 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Removal of old Internal broker
by yzaslavs＠redhat.com 13 Mar '14

13 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Removal of old Internal broker ...................................................................... aaa: Removal of old Internal broker Internal Authenticator and directory should be used. Instead, ProvisionalDirectory uses an InternalBroker for the "internal" domain. This is fixed in this patch. Topic: AAA Change-Id: I3fe72ff0fcdac425a28646d9850cc56cc0a7c058 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalAuthenticateUserCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalBrokerCommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalBrokerUtils.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdGroupByGroupIdCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserNameCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalSearchGroupsByQueryCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalSearchUserByQueryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapFactory.java 11 files changed, 29 insertions(+), 330 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fe72ff0fcdac425a28646d9850cc56cc0a7c058 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core : User is not able to see newly added permissions on ob...
by iheim＠redhat.com 13 Mar '14

13 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core : User is not able to see newly added permissions on object if he inherited this permission on that object. ...................................................................... core : User is not able to see newly added permissions on object if he inherited this permission on that object. If user inherit some permissions on some object, than if he try to add new permissions to object that he inherit permission from, he is not able to see this newly added permissions. Fixes the case where a single role TemplateAdmin can create multiple role_type entries in permissions_view Change-Id: I60d0c320453fa30554b6ac63e6652729dd0735d6 Bug-Url: https://bugzilla.redhat.com/877906 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/multi_level_administration_sp.sql 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/25698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d0c320453fa30554b6ac63e6652729dd0735d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: preserve custom db users permissions on...
by emesika＠redhat.com 12 Mar '14

12 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: core: preserve custom db users permissions on... ...................................................................... core: preserve custom db users permissions on... preserve custom db users permissions on upgrade Up to this patch if custom users were added and assign privileges on DB objects those privileges were removed when the db was updated or refreshed. This patch backups the privileges assigned to custom users and apply them after the database was upgraded or refreshed. Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073471 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-common.sh 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: add pg_dump wrapper
by emesika＠redhat.com 12 Mar '14

12 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: db: add pg_dump wrapper ...................................................................... db: add pg_dump wrapper Change-Id: I5dac42b5991f913ae5c1fccc4436eaffbb420195 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/dbfunc-base.sh M packaging/setup/dbutils/changedbowner.sh M packaging/setup/dbutils/dbfunc-base.sh 3 files changed, 31 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dac42b5991f913ae5c1fccc4436eaffbb420195 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: core: miniyum: fix provides in addition to packages
by Alon Bar-Lev 12 Mar '14

12 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: miniyum: fix provides in addition to packages ...................................................................... core: miniyum: fix provides in addition to packages 1. pull only native arch. 2. pull only latest version of package for each provides. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073172 Change-Id: I6b161c167ad410e2ad54dba2be5cda6cc8c6239e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 67 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b161c167ad410e2ad54dba2be5cda6cc8c6239e Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: post otopi-1.2.0_rc4
by Alon Bar-Lev 12 Mar '14

12 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post otopi-1.2.0_rc4 ...................................................................... packaging: post otopi-1.2.0_rc4 Change-Id: I6e39f6ec9f875b40ba70e6dd2b74babf9b90a0ab Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e39f6ec9f875b40ba70e6dd2b74babf9b90a0ab Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: otopi-1.2.0_rc4
by Alon Bar-Lev 12 Mar '14

12 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: otopi-1.2.0_rc4 ...................................................................... packaging: otopi-1.2.0_rc4 Change-Id: I5fce6ed171ded9f4856a1640b0f1f0adcc067fc5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fce6ed171ded9f4856a1640b0f1f0adcc067fc5 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [coverity] fix non used code
by rgolan＠redhat.com 12 Mar '14

12 Mar '14

Roy Golan has submitted this change and it was merged. Change subject: core: [coverity] fix non used code ...................................................................... core: [coverity] fix non used code Change-Id: I04a33c9f17e08e69a60cb607698a430b33213710 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04a33c9f17e08e69a60cb607698a430b33213710 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable hot plug for disk with IDE interface
by derez＠redhat.com 12 Mar '14

12 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disable hot plug for disk with IDE interface ...................................................................... webadmin: disable hot plug for disk with IDE interface New disk dialog: when the VM is running and IDE is selected, 'Activate' should be disabled. Change-Id: Iff166bfdae2e7bcdd56c5e4e5311f878138c260a Bug-Url: https://bugzilla.redhat.com/1055403 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff166bfdae2e7bcdd56c5e4e5311f878138c260a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0