March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Saving a dialog pressing ENTER inconsistent with c...
by alkaplan＠redhat.com 05 Mar '14

05 Mar '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK ...................................................................... webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK When clicking on OK button (or any other footer button) the view is flushed before the command is executed. Pressing "ESC" or "ENTER" should be consistent with clicking the footer button "CANCEL" or "OK". Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Bug-Url: https://bugzilla.redhat.com/1059578 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: dots in Setup Host Networks dialog
by alkaplan＠redhat.com 05 Mar '14

05 Mar '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: dots in Setup Host Networks dialog ...................................................................... webadmin: dots in Setup Host Networks dialog When opening a dialog in setup network the drag-dots on the nic/network icon should dissapear. Change-Id: Ice8fe82c0a52329c4b998c6e9e6201c3bd403cb0 Bug-Url: https://bugzilla.redhat.com/1064425 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice8fe82c0a52329c4b998c6e9e6201c3bd403cb0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Clearing float from AddRemoveRowPanel
by alkaplan＠redhat.com 05 Mar '14

05 Mar '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Clearing float from AddRemoveRowPanel ...................................................................... webadmin: Clearing float from AddRemoveRowPanel Adding <div style="clear: both;"/> after AddRemoveRowPanel to make sure next AddRemoveRowPanel will be in a new line. Change-Id: I88642c763c46c2fd62ebf95511f3f251b964c376 Related-To: https://bugzilla.redhat.com/1064749 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88642c763c46c2fd62ebf95511f3f251b964c376 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removing menu header from the menu in setup networ...
by alkaplan＠redhat.com 05 Mar '14

05 Mar '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: removing menu header from the menu in setup network dialog ...................................................................... webadmin: removing menu header from the menu in setup network dialog Removing the "menu for" header from the menu in setup network dialog. Bug-Url: https://bugzilla.redhat.com/1009774 Change-Id: I5634479c91046987591875954b3995fcd25c6d17 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5634479c91046987591875954b3995fcd25c6d17 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix coverity issue
by yzaslavs＠redhat.com 05 Mar '14

05 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix coverity issue ...................................................................... core: fix coverity issue InputStreamReader should be used with CTOR that accepts the charset encoding Change-Id: Id2557a58aa73f4be8b03f1357ecaa9668b725145 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2557a58aa73f4be8b03f1357ecaa9668b725145 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: add missing engine lock in run once
by iheim＠redhat.com 05 Mar '14

05 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: add missing engine lock in run once ...................................................................... core: add missing engine lock in run once RunVmOnce should take the engine lock that RunVm takes, but it didn't take locks at all because the LockIdNameAttribute annotation was missing. Thus, the LockIdNameAttribute annotation is added to RunVmOnce. Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Bug-Url: https://bugzilla.redhat.com/1071997 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: add missing engine lock in run once
by iheim＠redhat.com 05 Mar '14

05 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: add missing engine lock in run once ...................................................................... core: add missing engine lock in run once RunVmOnce should take the engine lock that RunVm takes, but it didn't take locks at all because the LockIdNameAttribute annotation was missing. Thus, the LockIdNameAttribute annotation is added to RunVmOnce. Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Bug-Url: https://bugzilla.redhat.com/1071997 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff7c176ad3741b501df4ce7fab08b89c11a33be2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: database: extend check empty
by iheim＠redhat.com 05 Mar '14

05 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: database: extend check empty ...................................................................... packaging: setup: database: extend check empty Also check tables for which the engine db user has no permission. Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Bug-Url: https://bugzilla.redhat.com/1056528 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix Default OS selection for PPC
by tjelinek＠redhat.com 05 Mar '14

05 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix Default OS selection for PPC ...................................................................... webadmin: Fix Default OS selection for PPC The change 23809 introduced a problem with the default OS for PPC64, since the id 0 was fixed in the AsyncDataProvider class. This change was supposed to fix a possible issue, that happens when the OS id added to a VM is missing in the OSInfo property file. I reverted the solution that was using the class MapWithDafults, because there are two default OSes (one for each architecture), not only one. I couldn't figure out how to fix this issue, maybe when starting the system and exit with an error or show error on event log. It deserves more discussion. Change-Id: I02843c1af1b3aecf2d3966bf836395550b0be554 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062344 Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/MapWithDefaults.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 3 files changed, 12 insertions(+), 54 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02843c1af1b3aecf2d3966bf836395550b0be554 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: extend check empty
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: extend check empty ...................................................................... packaging: setup: database: extend check empty Also check tables for which the engine db user has no permission. Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Bug-Url: https://bugzilla.redhat.com/1058013 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/dbfunc-common.sh M packaging/setup/ovirt_engine_setup/database.py 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0