March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: always create pgpassfile at misc
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: always create pgpassfile at misc ...................................................................... packaging: setup: always create pgpassfile at misc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072474 Change-Id: Ida3252b39e2da222ea022fcde639e3091260d8d7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/db/pgpass.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida3252b39e2da222ea022fcde639e3091260d8d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup - do not accept non-alphanumeric iso domain...
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup - do not accept non-alphanumeric iso domain name ...................................................................... packaging: setup - do not accept non-alphanumeric iso domain name ISO Domain name must contian only alphanumeric characters. Change-Id: If4caf14c80ebbabef6d565b832e725c7cf88c27c Bug-Url: https://bugzilla.redhat.com/1064373 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py 1 file changed, 27 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4caf14c80ebbabef6d565b832e725c7cf88c27c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: [Fix] Template changes do not update OS
by tjelinek＠redhat.com 05 Mar '14

05 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: [Fix] Template changes do not update OS ...................................................................... webadmin: [Fix] Template changes do not update OS This change forces an OS list update in the "New Pool" and the "Edit Pool" dialogs after the user selects a template. It was introduced in order to avoid a class of bugs where the OS list could show OSes for another architecture during the creation or edition of VM Pools. Change-Id: I959cdd6d133ead4f83cfb6cd68145519efb25489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067735 Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 31 insertions(+), 21 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Gustavo Frederico Temple Pedrosa: Verified -- To view, visit http://gerrit.ovirt.org/25040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959cdd6d133ead4f83cfb6cd68145519efb25489 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove API version field for Neutron
by mkolesni＠redhat.com 05 Mar '14

05 Mar '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Remove API version field for Neutron ...................................................................... webadmin: Remove API version field for Neutron Only API version 2.0 is curently supported, and since the user has a prefilled value in the URL field suggesting him the correct server URL to put, there is no need for him to be able to "select" the version. In the future should any other API version be available/supported, it should be solved in an appropriate manner (i.e. auto negotiate the version). Change-Id: Ic264c97b4acb82ffee298cee3f89340cda18ddc3 Bug-Url: https://bugzilla.redhat.com/987917 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 3 files changed, 0 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic264c97b4acb82ffee298cee3f89340cda18ddc3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Guide Me icon brandable
by awels＠redhat.com 04 Mar '14

04 Mar '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Guide Me icon brandable ...................................................................... webadmin: Guide Me icon brandable - Made the Guide Me popup window icon brandable Change-Id: I5e28d7ca3ade548e22a5d442107a12d095669ebd Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml R packaging/branding/ovirt.brand/images/dialog/guide.png M packaging/branding/ovirt.brand/web_admin.css 4 files changed, 12 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e28d7ca3ade548e22a5d442107a12d095669ebd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Host network interface subtab data
by awels＠redhat.com 04 Mar '14

04 Mar '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Host network interface subtab data ...................................................................... webadmin: Host network interface subtab data - Fixed issue where when pressing refresh on the main tab grid, and the network interface subtab was open the data for the subtab would disappear. Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066827 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb539f95353992f589d251629be76f02a0196d18 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event
by iheim＠redhat.com 04 Mar '14

04 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event ...................................................................... webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event DialogBoxWithKeyHandlers -> onPreviewNativeEvent: remove ONKEYPRESS event as onKeyPress might be called twice (due to ONKEYDOWN event). Which causes double execution of OK command when pressing enter key in Network dialog. Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Bug-Url: https://bugzilla.redhat.com/1058652 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/25287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Consolidate engine.version
by iheim＠redhat.com 04 Mar '14

04 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Consolidate engine.version ...................................................................... core: Consolidate engine.version Currently there are two properties that contain the version of the engine, and the value is assigned in multiple places. This patch changes the POM files so that this property is defined only once, in the root POM. Change-Id: I1b58568d9106eea0841653e9882f4b19b8aea4ee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/pom.xml M frontend/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M pom.xml 9 files changed, 14 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified Itamar Heim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b58568d9106eea0841653e9882f4b19b8aea4ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: fix missing version update
by iheim＠redhat.com 04 Mar '14

04 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: fix missing version update ...................................................................... packaging: fix missing version update adding version bump to other variables in pom files, missing in change Ic0133e74a4f4c6c42ee7a8da7eaf954c40443c5f Change-Id: Id2eeb2383502f9c06c3e26739cf49f94e24a0437 Bug-Url: https://bugzilla.redhat.com/1069193 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/modules/restapi/pom.xml M backend/pom.xml M frontend/pom.xml M pom.xml 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2eeb2383502f9c06c3e26739cf49f94e24a0437 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN
by derez＠redhat.com 04 Mar '14

04 Mar '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN ...................................................................... webadmin: EnterIgnoringFocusHandler catch ONKEYDOWN EnterIgnoringFocusHandler -> onPreviewNativeEvent: execute 'enterPressed' on ONKEYDOWN event instead of ONKEYPRESS to overcome an issue in newer Chrome/FF browsers, in which the textarea doesn't catch the ONKEYPRESS event. Consequently, pressing enter key in a textarea won't break to a new line (e.g. 'Custom Script' textarea). Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/25289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064f74e79dedb20ab305ef238c7ff2a6fed743fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0