Change in ovirt-engine[ovirt-engine-3.4]: core: populate groups when getting users by ids
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: populate groups when getting users by ids
......................................................................
core: populate groups when getting users by ids
This patch uses group population when getting users by ids. That's needed in order
to get a clear knowledge of the groups (both direct and parent) that a user belongs to.
Also, it makes sure to set proper name and id for these parent groups, in case they …
[View More]don't exist in the DB.
Change-Id: Ief6d9295382fa2b5485e3098589cc20bf9ff61be
Bug-Url: http://bugzilla.redhat.com/1069562
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalDirectory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/26350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief6d9295382fa2b5485e3098589cc20bf9ff61be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Relaxed slave interface validation
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Relaxed slave interface validation
......................................................................
engine: Relaxed slave interface validation
Validation used to demand that no boot protocol, IP address etc. be
defined on the slave interfaces, whereas this seems to be quite common
when using Fedora 19 hosts. This is erased by VDSM anyway, so there's
no real reason to block this on the engine side.
…
[View More]Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711
Bug-Url: https://bugzilla.redhat.com/1082296
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I564325fd0ac0cf54d2bff7c155a7a67f32507711
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-hosted-engine-setup[master]: packaging: cleaning spec and configure
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: cleaning spec and configure
......................................................................
packaging: cleaning spec and configure
Fixed source url, updated dependencies.
Change-Id: Ied0e61fbb902ee977535d57d4fc2e6cdf20d3e6f
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 5 insertions(+), 27 deletions(-)
…
[View More]Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied0e61fbb902ee977535d57d4fc2e6cdf20d3e6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[master]: core: add helper method for template version
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add helper method for template version
......................................................................
core: add helper method for template version
some places in addVmTemplate command are checking for
baseTemplateId==null to understand if we add base template or template
version.
this patch encapsulate this logic into a method with a clear name.
Change-Id: I25229303fcee443191be1f2a1de84be345f96aff
…
[View More]Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25229303fcee443191be1f2a1de84be345f96aff
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Fix NPE when scanning for non-existent domain.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix NPE when scanning for non-existent domain.
......................................................................
core: Fix NPE when scanning for non-existent domain.
Adding a validation in GetUnregisteredDiskQuery for existence of storage domain
by storage domain id, transferred in the parameters.
Change-Id: I7c722ca3b003efd89ae5207bc941d6926b5f052c
Bug-Url: https://bugzilla.redhat.com/954344
Signed-off-…
[View More]by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 32 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/26247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c722ca3b003efd89ae5207bc941d6926b5f052c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-node-plugin-vdsm[master]: engine_page: network is required to register tab
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: network is required to register tab
......................................................................
engine_page: network is required to register tab
oVirt Engine tab will only show the options for register
once the oVirt Node has the network setup.
Change-Id: Ic2563804673954234f3c29fed80ca54fe195d35a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064206
Signed-off-by: Douglas …
[View More]Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 45 insertions(+), 18 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2563804673954234f3c29fed80ca54fe195d35a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[master]: core: move static herlper methods out of VURTI
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: move static herlper methods out of VURTI
......................................................................
core: move static herlper methods out of VURTI
Change-Id: Ifb4b7e15ac346853008f79769be102404b8cc0eb
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
A backend/manager/modules/vdsbroker/src/main/java/org/…
[View More]ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
3 files changed, 222 insertions(+), 210 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26012
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb4b7e15ac346853008f79769be102404b8cc0eb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[master]: core: removed unused methods from VURTI
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: removed unused methods from VURTI
......................................................................
core: removed unused methods from VURTI
1. unsed code
2. needless static method
Change-Id: I0b028de953d76e25ad73bda76a6727bdc32b1b8e
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed,…
[View More] 1 insertion(+), 18 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b028de953d76e25ad73bda76a6727bdc32b1b8e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd
by dougsland@redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: spec: start/enable glusterd
......................................................................
spec: start/enable glusterd
This patch will enable/disable glusterd service after install/remove
of ovirt-node-plugin-vdsm
Change-Id: Ica02b068914a8ae9aaf8c452175db969badc4e6e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073531
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&…
[View More]gt;
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 37 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica02b068914a8ae9aaf8c452175db969badc4e6e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months
Change in ovirt-engine[master]: core: Replace validation for Storage Domain existence
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Replace validation for Storage Domain existence
......................................................................
core: Replace validation for Storage Domain existence
Changing the validation of Storage Domain with Storage Pool for
unregistered disks, since the Storage Domain can be without Storage
Pool.
Change-Id: I26b031709faae5234a26c864f3d80ff9e6d19f28
Bug-Url: https://bugzilla.redhat.com/954344
…
[View More]Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/26301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26b031709faae5234a26c864f3d80ff9e6d19f28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 9 months