Change in ovirt-engine[master]: webadmin: Only allow bridge_opts for VM networks
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Only allow bridge_opts for VM networks
......................................................................
webadmin: Only allow bridge_opts for VM networks
This option for custom properties shouldn't appear for non-VM
networks, as it's meaningless.
Change-Id: I5758c85388f8f5d3ac5d1a057e8a4c8ae730df5e
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5758c85388f8f5d3ac5d1a057e8a4c8ae730df5e
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: webadmin: Add network custom properties in Setup Networks
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Add network custom properties in Setup Networks
......................................................................
webadmin: Add network custom properties in Setup Networks
Added a custom properties widget to the edit network dialog inside
Setup Networks in case the host is in a cluster that supports the
feature, applied validation and made sure changes are flushed to the
backend entity.
Change-Id: I1bc9f38f48fcf1bd9998228d316093db2db69782
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java
10 files changed, 113 insertions(+), 20 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bc9f38f48fcf1bd9998228d316093db2db69782
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: core: Fix UpdateVmDiskCommand resize validation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix UpdateVmDiskCommand resize validation
......................................................................
core: Fix UpdateVmDiskCommand resize validation
validateCanResizeDisk() is called from UpdateVmDiskCommand CDA and is
faulty. In it the first two verifications were called whether there was an
attempt to resize the image or not. These two verifications now take
place only if there is indeed an attempt to resize the image.
Need to add a mock in the test.
Change-Id: I760bb3b72d872a1ba5c7af2a9607c7249583652a
Bug-Url: https://bugzilla.redhat.com/1092087
Bug-Url: https://bugzilla.redhat.com/1092371
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 18 insertions(+), 16 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/27269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I760bb3b72d872a1ba5c7af2a9607c7249583652a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 12 months
Change in ovirt-engine[master]: engine: Enable subscribing to change display network warnings.
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Enable subscribing to change display network warnings.
......................................................................
engine: Enable subscribing to change display network warnings.
Change-Id: I2b0ac48a6fffc7b0cfa4c971f9e038b2b696c0e6
Bug-Url: https://bugzilla.redhat.com/1078836
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
A packaging/dbscripts/upgrade/03_05_0350_add_display_network_change_events.sql
4 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b0ac48a6fffc7b0cfa4c971f9e038b2b696c0e6
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: engine: Audit log warning about display network connectivity...
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Audit log warning about display network connectivity change. (CollectVdsNetworkDataVDSCommand)
......................................................................
engine: Audit log warning about display network connectivity change. (CollectVdsNetworkDataVDSCommand)
The warning that let the user to understand that the changes in
display network will be applied not instantly, but on the next
VM restart. The change is done in CollectVdsNetworkDataVDSCommand.
Change-Id: I9949fc6ed52871ccfb1a15397e2cc722ad231b8f
Bug-Url: https://bugzilla.redhat.com/1078836
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/DisplayInterfaceEqualityPredicate.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/IsNetworkOnInterfacePredicate.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/DisplayInterfaceEqualityPredicateTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/IsNetworkOnInterfacePredicateTest.java
7 files changed, 212 insertions(+), 4 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27168
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9949fc6ed52871ccfb1a15397e2cc722ad231b8f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: engine: add audit log warning when display network is set an...
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: add audit log warning when display network is set and a running VM is attached to the cluster (for AttachNetworksToCluster command).
......................................................................
engine: add audit log warning when display network is set and a running
VM is attached to the cluster (for AttachNetworksToCluster command).
Move warning treating code to
AttachNetworkToVdsGroupCommand.attachNetwork method which is
called from both commands.
Change-Id: I674f7f7a905e3007e9857dd817e125e52d02c448
Bug-Url: https://bugzilla.redhat.com/1078836
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
1 file changed, 15 insertions(+), 9 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/26504
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I674f7f7a905e3007e9857dd817e125e52d02c448
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: engine: Audit log warning about display network change.
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Audit log warning about display network change.
......................................................................
engine: Audit log warning about display network change.
The warning that let the user to understand that the changes in
display network will be applied not instantly, but on the next
VM restart.
Change-Id: Ib9df4cd96fe71b3a44132004f17a7889dbe912b2
Bug-Url: https://bugzilla.redhat.com/1078836
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/ActiveVmAttachedToClusterPredicate.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicate.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicateTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
9 files changed, 330 insertions(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9df4cd96fe71b3a44132004f17a7889dbe912b2
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-engine[master]: engine: Added port for Nrpe operations.
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: Added port for Nrpe operations.
......................................................................
engine: Added port for Nrpe operations.
Opened port 5666 which is used by Nrpe, An
agent used by Nagios for monitoring remote
Machine.
Change-Id: If8ccfa9bb5b5fdcd8d89c5baacf5af04b413f384
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Darshan N: Verified
--
To view, visit http://gerrit.ovirt.org/26786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8ccfa9bb5b5fdcd8d89c5baacf5af04b413f384
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 12 months
Change in ovirt-reports[master]: reports: br6 report - added comments to queries
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br6 report - added comments to queries
......................................................................
reports: br6 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I3c7f8127ad7fca24446776427b2eb6bce843b1cb
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full details br13.jrxml.data
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/header cluster name.jrxml.data
3 files changed, 1,132 insertions(+), 894 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c7f8127ad7fca24446776427b2eb6bce843b1cb
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 12 months
Change in ovirt-reports[master]: reports: br22 report - added comments to queries
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br22 report - added comments to queries
......................................................................
reports: br22 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I377ed12395c144d814af6c86212bf4755f0bb3aa
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/full details.jrxml.data
M packaging/ovirt-reports/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data
2 files changed, 669 insertions(+), 505 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I377ed12395c144d814af6c86212bf4755f0bb3aa
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 12 months