April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: remove unused imports
by alkaplan＠redhat.com 30 Apr '14

30 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove unused imports ...................................................................... engine: remove unused imports Change-Id: Id2c7dc0e2143acc947ebcc2e61658c3088dc3955 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2c7dc0e2143acc947ebcc2e61658c3088dc3955 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Replace the call to deprecated UpdateDispla...
by masayag＠redhat.com 30 Apr '14

30 Apr '14

Moti Asayag has submitted this change and it was merged. Change subject: engine,webadmin: Replace the call to deprecated UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one ...................................................................... engine,webadmin: Replace the call to deprecated UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one 1. Replace call to UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one in ClusterNetworkListModel.setDisplay() method. 2. Remove deprecated UpdateDisplayToVdsGroup and the related command class as those aren't in use anymore. Change-Id: I9f103f0db10a06b0b2689298d3bfa505f4615577 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateDisplayToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java 4 files changed, 7 insertions(+), 75 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/26505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f103f0db10a06b0b2689298d3bfa505f4615577 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.4]: codegen: Sort subcollection fields
by juan.hernandez＠redhat.com 29 Apr '14

29 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Sort subcollection fields ...................................................................... codegen: Sort subcollection fields The code generator doesn't sort the fields containing references to subcollections. This means that the generated code may be different depending on the default order of dictionaries, or the order of collections in the XML schema and RSDL files. To avoid potential uncessary changes this patch changes the code generator so that the fields are generated in alphabetical order. Change-Id: Ib4d9af8282d7e7fc0b9fb06e85c1dad1b62355ff Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e76524ba08ca5c860773829bdbb0266c6ec23cdc) --- M src/codegen/resource/resource.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d9af8282d7e7fc0b9fb06e85c1dad1b62355ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Sort subcollection fields
by juan.hernandez＠redhat.com 29 Apr '14

29 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Sort subcollection fields ...................................................................... codegen: Sort subcollection fields The code generator doesn't sort the fields containing references to subcollections. This means that the generated code may be different depending on the default order of dictionaries, or the order of collections in the XML schema and RSDL files. To avoid potential uncessary changes this patch changes the code generator so that the fields are generated in alphabetical order. Change-Id: Ib4d9af8282d7e7fc0b9fb06e85c1dad1b62355ff Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/resource/resource.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/26976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d9af8282d7e7fc0b9fb06e85c1dad1b62355ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: added release notes
by ydary＠redhat.com 29 Apr '14

29 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: Iaeee782d56f6471e86516d75275b990789dd41cc Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeee782d56f6471e86516d75275b990789dd41cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: fixed exception when trying to access dict item
by msivak＠redhat.com 29 Apr '14

29 Apr '14

Martin Sivák has submitted this change and it was merged. Change subject: fixed exception when trying to access dict item ...................................................................... fixed exception when trying to access dict item Change-Id: I9faa898efa9e54844f1816c75d51d3cb94c1c50a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092075 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/state_machine.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/27177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9faa898efa9e54844f1816c75d51d3cb94c1c50a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: coverity: Fix DLS warnings in StoragePoolDAOTest
by tnisan＠redhat.com 29 Apr '14

29 Apr '14

Tal Nisan has submitted this change and it was merged. Change subject: coverity: Fix DLS warnings in StoragePoolDAOTest ...................................................................... coverity: Fix DLS warnings in StoragePoolDAOTest Change-Id: I5b46c473cc344e7152cc7ecb18a583a60f32cc2a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b46c473cc344e7152cc7ecb18a583a60f32cc2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: rework jar/poms installation
by sbonazzo＠redhat.com 29 Apr '14

29 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: rework jar/poms installation ...................................................................... packaging: spec: rework jar/poms installation there is no reason to install poms that are not part of interface of product, however I leave this for now. the timing is due to the fact that we are to expose interface of extension api and we need to sort out the artifact installation. the installation of poms was incorrect as the update_maven_depmap at each subpackage should have been run for subset of files, same for the pom fragments. new implementation uses fedora-19 maven integration correctly, while emulating the minimum required for rhel host, using %files -f syntax. also add missing jars and poms from build. Change-Id: I0a0afe8d9c8d85e56fefdb06f155f6459c4ec650 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in 2 files changed, 66 insertions(+), 91 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0afe8d9c8d85e56fefdb06f155f6459c4ec650 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add auto-startup parameters to engine-config
by ahadas＠redhat.com 29 Apr '14

29 Apr '14

Arik Hadas has submitted this change and it was merged. Change subject: core: add auto-startup parameters to engine-config ...................................................................... core: add auto-startup parameters to engine-config Add two parameters which are related to restart of highly-available VM to engine-config: 1. For setting the maximum number of attempts that will be made in order to restart highly-available VM that crashed 2. For setting the interval (in seconds) between those restart attempts Change-Id: I9bf0953b5808020cbfa39a79385faf442b5e13a0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bf0953b5808020cbfa39a79385faf442b5e13a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-3.4]: packaging: added release notes
by ydary＠redhat.com 29 Apr '14

29 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added release notes ...................................................................... packaging: added release notes Change-Id: I4944452424f5d425a1e55baf0f7918fedc3d87a2 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4944452424f5d425a1e55baf0f7918fedc3d87a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0