Change in ovirt-reports[master]: reports: added a condition vms / hosts are active
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: added a condition vms / hosts are active
......................................................................
reports: added a condition vms / hosts are active
added a condition to the report query,
taht the vms or hosts must be active.
Change-Id: If078b29e2eb9a48018ab9035e9880fc320fdbe3e
Bug-Url: https://bugzilla.redhat.com/1085874
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/five_least_utilized_vms_Over_Time_BR12_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data
17 files changed, 387 insertions(+), 253 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If078b29e2eb9a48018ab9035e9880fc320fdbe3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: core: block preview of active vm snapshot
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: block preview of active vm snapshot
......................................................................
core: block preview of active vm snapshot
* TryBackToAllSnapshotsOfVmCommand -> canDo:
- Active VM snapshot validation.
* DiskSnapshotsValidator:
- Added canDiskSnapshotsBePreviewed validation.
- Allow custom preview of active VM configuration only
when selecting a subset of snapshot disks.
Change-Id: Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384
Bug-Url: https://bugzilla.redhat.com/1096884
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 88 insertions(+), 17 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: aaa: Adding findbugs-general profile to pom.xml
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Adding findbugs-general profile to pom.xml
......................................................................
aaa: Adding findbugs-general profile to pom.xml
Change-Id: I4ac1305b12346fcf4bd55c4c1fa628d7a53d353c
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/aaa/pom.xml
1 file changed, 43 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ac1305b12346fcf4bd55c4c1fa628d7a53d353c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: CompensationContext - add support for updated entity o...
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: CompensationContext - add support for updated entity only.
......................................................................
core: CompensationContext - add support for updated entity only.
In some cases when we update an entity we would like to use the
compensation context to attempt to only update the entity to it's
previous state rather than possibly re-insert it as we perform only
updates and there might be operations that removed it intentionally
without consideration of other running operations.
Change-Id: I527d8b95b82f76fb4ce0db7e6ec967c23b759524
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java
5 files changed, 27 insertions(+), 5 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I527d8b95b82f76fb4ce0db7e6ec967c23b759524
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: proceedStorageDomainTreatmentByDomainType - proper com...
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: proceedStorageDomainTreatmentByDomainType - proper compensation
......................................................................
core: proceedStorageDomainTreatmentByDomainType - proper compensation
proceedStorageDomainTreatmentByDomainType() method updates different
properties of the storage domain, to use the compensation mechanisam in
case of failure the storage domain's static data before the updates was
saved in the compensation context.
The snapshotEntity() method used for saving the static in the
compensation context has documentation stating the in case that the
entity was deleted/updated it would be restored to it's state as saved,
which means that if it was deleted, the entity would be re-inserted.
ForceRemoveStorageDomainCommand is an engine command to remove a domain
from the database forcibly at the user risk, this command can run
parallely to the ReconstructMasterDomainCommand (wether it's right or
wrong is another discussion) which executes the
proceedStorageDomainTreatmentByDomainType() method.
This can cause to an issue - if the domain is removed by the removal
command, the compensation used in the reconstruct command might
re-insert domain related records to the db.
In this patch i handle this issue by using the snapshotEntityUpdated()
method which is more correct in that case (as we only update the entity)
and will remove the possibility of mistkenly re-inserting the data.
Further on we should inspect why and if we should allow those commands
to run in parallel.
Change-Id: I9ec99cf5e567fe9820e4028a886372d73d5c1d6f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969026
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ec99cf5e567fe9820e4028a886372d73d5c1d6f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core : Domain of group is not shown in sub tab of users tab
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Domain of group is not shown in sub tab of users tab
......................................................................
core : Domain of group is not shown in sub tab of users tab
Domain of groups added is not shown in general sub tab
of users tab
Change-Id: Id9aee2ad6491c6f9feee3fd3a92d68a20e8192da
Bug-Url: https://bugzilla.redhat.com/1087498
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9aee2ad6491c6f9feee3fd3a92d68a20e8192da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Group 'user name' should be empty value In column ...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Group 'user name' should be empty value In column 'user name' in user tab.
......................................................................
webadmin: Group 'user name' should be empty value In column 'user name' in user tab.
For groups the user name should be empty
in the User main tab
Change-Id: I56bcdc0615da3e423412b236f5164f7dc0a436ce
Bug-Url: https://bugzilla.redhat.com/1087498
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FormatUtils.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Alona Kaplan: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56bcdc0615da3e423412b236f5164f7dc0a436ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: support distro without jboss-as 7
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: spec: support distro without jboss-as 7
......................................................................
packaging: spec: support distro without jboss-as 7
A new package providing jboss-as 7 for distro that
don't ship it has been created as ovirt-engine-jboss-as.
The package can be installed side-by-side with wildfly on
Fedora 20 and doesn't conflict with jboss-as manual installations
on /usr/share/jboss-as using its own directory.
The package is built by
http://jenkins.ovirt.org/job/ovirt-engine-jboss-as_master_create-rpms_merged
The spec file has been updated for EL6 and F20 in order to require
the new package and provide the environment keys for automatically
set jboss home directory.
Change-Id: Icef92a1f22e6f88458d1624429dff57a9817192f
Bug-Url: https://bugzilla.redhat.com/1055604
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 0ad8c8c652ae2a7c8dfa810d150841a32926cf6e)
---
M ovirt-engine.spec.in
1 file changed, 21 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef92a1f22e6f88458d1624429dff57a9817192f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-node-plugin-vdsm[node-3.0]: ovirt-node-plugin-vdsm: Bump release to 0.1.2-2
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-2
......................................................................
ovirt-node-plugin-vdsm: Bump release to 0.1.2-2
- engine_page: catch exception from vdscli.connect()
Change-Id: Id5c72fd38c902d2015d66343378c3a7dd5e46f9f
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5c72fd38c902d2015d66343378c3a7dd5e46f9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: catch exception from vdscli.connect()
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: engine_page: catch exception from vdscli.connect()
......................................................................
engine_page: catch exception from vdscli.connect()
After the node installation and before the registration
there are no .pem files in /etc/pki/vdsm/certs so
vdscli.connect() will raise an exception when users
login as admin to TUI access. This patch catches and log
the exception.
Change-Id: I5a0333837a3aec2364362728951b1623b46065a0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1100226
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a0333837a3aec2364362728951b1623b46065a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months