Change in ovirt-engine[ovirt-engine-3.4]: core: refactor failure to run vm flow - part 3
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: refactor failure to run vm flow - part 3
......................................................................
core: refactor failure to run vm flow - part 3
Rename RunVmCommandBase#failToRunVm with runningFailed, and put other
things that should always be executed when the async command fails so
this method will be equivalent of RunVmCommandBase#runningSucceeded in
case of a failure.
Change-Id: I1e24011ea31e504439614bf2876cf81a47d3d3c1
Bug-Url: https://bugzilla.redhat.com/1049321
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
3 files changed, 10 insertions(+), 12 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e24011ea31e504439614bf2876cf81a47d3d3c1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: fix duplicate smartcards on template update
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix duplicate smartcards on template update
......................................................................
core: fix duplicate smartcards on template update
When updating template, if smart card is enabled,
a new device was created and there was no check for existing device.
fixed to check if device already exist before add.
also added a script to eliminate any existing duplicates.
Change-Id: I14e6779c5c85b514cb953b771c68c5ac1acaafcb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098638
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
A packaging/dbscripts/upgrade/03_05_0490_remove_duplicate_smartcards.sql
2 files changed, 13 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28084
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14e6779c5c85b514cb953b771c68c5ac1acaafcb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: refactor failure to run vm flow - part 2
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: refactor failure to run vm flow - part 2
......................................................................
core: refactor failure to run vm flow - part 2
When migration fails and the VM get back to UP state in the source host,
we do not want to treat the VM as VM that failed to run. Thus,
MigrateVmCommand overrides RunVmCommandBase#failedToRunVm method and do
not do anything in that case.
Instead of override the whole RunVmCommandBase#failedToRunVm method, it
is better to override just the RunVmCommandBase#processVmPoolOnStopVm
method so the rest of the things that failedToRunVm do would be
executed.
In addition, the code in RunVmCommandBase#reportCompleted was
simplified a bit.
Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69
Bug-Url: https://bugzilla.redhat.com/1049321
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
2 files changed, 16 insertions(+), 19 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: refactor failure to run vm flow - part 1
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: refactor failure to run vm flow - part 1
......................................................................
core: refactor failure to run vm flow - part 1
In most of the case when we fail to run VM we want to have proper audit
message for it to be logged. That's why on almost every call to
RunVmCommandBase#failedToRunVm method we log an audit message right
before or after the call.
One exception though is on the execution phase of RunVm - if the VM
fails to run we do not need to log it, because it would be logged
automatically by the infrastructure when the execution phase ends.
This patch moves the call to log audit message to be within the
failedToRunVm method. As for the case where the failedToRunVm method is
called within the execution phase of RunVm, we'll also log it inside the
failedToRunVm method, but set commandShouldBeLogged to false so the
infrastructure will not log it again.
This patch contains two additional minor refactoring changes.
Change-Id: I74bd39fd5a4dc95694e9a059c40f7797b5e97623
Bug-Url: https://bugzilla.redhat.com/1049321
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
3 files changed, 15 insertions(+), 16 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74bd39fd5a4dc95694e9a059c40f7797b5e97623
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: Control virtio rng device
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: restapi: Control virtio rng device
......................................................................
restapi: Control virtio rng device
Change-Id: I585ae1088bbe18af42bf374e3207d053ae71f166
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/977079
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/RngSource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/RngDeviceValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/TemplateValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RngDeviceMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/RngDeviceMapperTest.java
20 files changed, 408 insertions(+), 3 deletions(-)
Approvals:
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I585ae1088bbe18af42bf374e3207d053ae71f166
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-guest-agent[ovirt-3.4]: Implement default configuration values
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Implement default configuration values
......................................................................
Implement default configuration values
When adding new config values to the configuration files, it's possible
that due to the installation the configuration files won't get updated,
when they are modified by an user/administrator on that given system.
By using defaults, we can override this problem and ensure a proper
application start, when config values are missing which are mandatory,
to the functionality.
Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1100249
---
M Makefile.am
A configurations/Makefile.am
A configurations/default-logger.conf
R configurations/default-logger.ini
A configurations/default.conf
A configurations/default.ini
A configurations/ovirt-guest-agent.conf
A configurations/ovirt-guest-agent.ini
M configure.ac
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
M ovirt-guest-agent/Makefile.am
M ovirt-guest-agent/Makefile.el5
M ovirt-guest-agent/OVirtGuestService.py
A ovirt-guest-agent/bytesio.py
D ovirt-guest-agent/ovirt-guest-agent.conf
M ovirt-guest-agent/ovirt-guest-agent.py
M ovirt-guest-agent/win-guest-agent-build-exe.bat
18 files changed, 304 insertions(+), 90 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-guest-agent[master]: Implement default configuration values
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Implement default configuration values
......................................................................
Implement default configuration values
When adding new config values to the configuration files, it's possible
that due to the installation the configuration files won't get updated,
when they are modified by an user/administrator on that given system.
By using defaults, we can override this problem and ensure a proper
application start, when config values are missing which are mandatory,
to the functionality.
Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1100249
---
M Makefile.am
A configurations/Makefile.am
C configurations/default-logger.conf
R configurations/default-logger.ini
A configurations/default.conf
A configurations/default.ini
A configurations/ovirt-guest-agent.conf
A configurations/ovirt-guest-agent.ini
M configure.ac
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
M ovirt-guest-agent/Makefile.am
M ovirt-guest-agent/Makefile.el5
M ovirt-guest-agent/OVirtGuestService.py
A ovirt-guest-agent/bytesio.py
D ovirt-guest-agent/ovirt-guest-agent.conf
M ovirt-guest-agent/ovirt-guest-agent.py
M ovirt-guest-agent/win-guest-agent-build-exe.bat
18 files changed, 272 insertions(+), 110 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce9d457e826448aad205ce4abda5dc4b0210804
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: do not save state VMs state on RunOnce
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: do not save state VMs state on RunOnce
......................................................................
core: do not save state VMs state on RunOnce
Change-Id: I440cf3fa898137732b7fafa0ca9a731e86fe7650
Bug-Url: https://bugzilla.redhat.com/1095635
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I440cf3fa898137732b7fafa0ca9a731e86fe7650
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin:Set highest compatibility version by default in new...
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin:Set highest compatibility version by default in new cluster pop-up
......................................................................
webadmin:Set highest compatibility version by default in new cluster pop-up
while creating new cluster in Gluster only mode,
the latest version will be selected as Compatibility Version by default
Bug-Url: https://bugzilla.redhat.com/1096646
Change-Id: Iaa76e316b536bedf1b24ce21493716a4b08c9878
Signed-off-by: Karnan <kchidamb(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Karnan t c: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa76e316b536bedf1b24ce21493716a4b08c9878
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-log-collector[master]: Avoid hitting performance issues with api listing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Avoid hitting performance issues with api listing
......................................................................
Avoid hitting performance issues with api listing
After BZ1025320 default is provide all results
this limits results on each iteration to page_size
Related-To: http://bugzilla.redhat.com/1025320
Change-Id: I2c3cf488df334b5dcf43904a4c67f9abcbe38f87
Signed-off-by: Pablo <Pablo.Iranzo(a)gmail.com>
---
M src/helper/hypervisors.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Pablo Iranzo Gómez: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c3cf488df334b5dcf43904a4c67f9abcbe38f87
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months