Change in ovirt-engine[master]: Makefile: locale ulimit message
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Makefile: locale ulimit message
......................................................................
Makefile: locale ulimit message
- Fixed locale ulimit message giving wrong current ulimit
Change-Id: I8d5d3beac4a29f2f057dffbe3543865e382aa558
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Alexander Wels: Verified
--
To view, visit http://gerrit.ovirt.org/27879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d5d3beac4a29f2f057dffbe3543865e382aa558
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: dr28 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr28 report - added comments to queries
......................................................................
reports: dr28 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I2876cf26aeadb8f9275ab467a189135d12d41cec
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data
1 file changed, 42 insertions(+), 22 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2876cf26aeadb8f9275ab467a189135d12d41cec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Ran formatter over Frontend.runMultipleActions()
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Ran formatter over Frontend.runMultipleActions()
......................................................................
webadmin: Ran formatter over Frontend.runMultipleActions()
Pushed as separate patch to make succeeding patches easier to review.
Change-Id: I5f3de243f27c22235daee1e2cb5069edc3238169
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 17 insertions(+), 17 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f3de243f27c22235daee1e2cb5069edc3238169
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: Simplified failure handling code in Frontend
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Simplified failure handling code in Frontend
......................................................................
webadmin: Simplified failure handling code in Frontend
Changed the name of a variable to better represent what it means, and
extracted some common code out of conditional clauses.
This also exposed some dead code - there was some logic setting an
alternative error message in case the failure isn't on canDoAction(),
but it was located in a conditional clause where it had already been
established that the failure had been on canDoAction().
Also took the chance to remove a redundant event flow, where a single
error message was being passed around instead of a list, but which in
the end would perform the same logic.
Change-Id: I19a0fc10841c9d400ad381f5f9f5fbaaf55fe871
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/FrontendFailureEventArgs.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ErrorMessageFormatter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
7 files changed, 25 insertions(+), 83 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a0fc10841c9d400ad381f5f9f5fbaaf55fe871
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-reports[master]: reports: dr6 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr6 report - added comments to queries
......................................................................
reports: dr6 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I07931fd634d7fed474faf4744bae3a70601b74c5
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_host_uptime_status_dr6_jrxml.data
1 file changed, 39 insertions(+), 12 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27859
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07931fd634d7fed474faf4744bae3a70601b74c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in samples-uiplugins[master]: docker: include jquery from secured link
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: docker: include jquery from secured link
......................................................................
docker: include jquery from secured link
Previous version included jquery from a non-secured URL (http), which is
problematic in case the engine is working with a secured URL (https), so
making https the default, and adding an installation note to change that
in case needed.
Change-Id: I06bd1665ab6c3217c101e6b517ea2bd3b397c052
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M docker-plugin/docker-resources/launch-docker-dialog.html
M docker-plugin/docker-resources/plugin.html
M docker-plugin/docker.json
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06bd1665ab6c3217c101e6b517ea2bd3b397c052
Gerrit-PatchSet: 5
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
10 years, 7 months
Change in ovirt-reports[master]: reports: br12 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br12 report - added comments to queries
......................................................................
reports: br12 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I3b8b92e5eb2568e562221f00462c5d65c3545cb7
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_host_resources_status_dr12_jrxml.data
1 file changed, 40 insertions(+), 15 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b8b92e5eb2568e562221f00462c5d65c3545cb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: dr3 report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: dr3 report - added comments to queries
......................................................................
reports: dr3 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I9ccc5f6ab9e86b1ebd464ed7cad93f5b012105f9
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_entities_counts_list_dr3_jrxml.data
1 file changed, 29 insertions(+), 15 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ccc5f6ab9e86b1ebd464ed7cad93f5b012105f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: br18a report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br18a report - added comments to queries
......................................................................
reports: br18a report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I5bbb94ff6caa6658d2d4ab3ca666be83de1a307f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data
1 file changed, 346 insertions(+), 229 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bbb94ff6caa6658d2d4ab3ca666be83de1a307f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-reports[master]: reports: br10a report - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br10a report - added comments to queries
......................................................................
reports: br10a report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: If9ecd9aa298916a914d10c3774ce597b26466ecf
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/br10 full details.jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data
2 files changed, 1,491 insertions(+), 1,017 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ecd9aa298916a914d10c3774ce597b26466ecf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months