May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: br22b report - added comments to queries
by ydary＠redhat.com 19 May '14

19 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br22b report - added comments to queries ...................................................................... reports: br22b report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I714da9cffbd626865deb0bcbf503afd1fe88cfcb Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/Inventory_Dashboard/Host_OS_Break_Down_BR22B_for_inventory_files/Host_OS_Break_Down_BR22B_for_inventory_jrxml.data 1 file changed, 213 insertions(+), 157 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I714da9cffbd626865deb0bcbf503afd1fe88cfcb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin : Existing gluster cluster import iptables config
by kmayilsa＠redhat.com 19 May '14

19 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Existing gluster cluster import iptables config ...................................................................... webadmin : Existing gluster cluster import iptables config This patch enables iptables rules configuration, when importing existing gluster cluster configurations Change-Id: Ib4a391cb1f912c4c052ff183de6463edcad4e0a9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1051019 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MultipleHostsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/MultipleHostsPopupView.ui.xml 6 files changed, 34 insertions(+), 3 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4a391cb1f912c4c052ff183de6463edcad4e0a9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: gluster: check gluster daemon status in sync-job
by oourfali＠redhat.com 19 May '14

19 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: gluster: check gluster daemon status in sync-job ...................................................................... gluster: check gluster daemon status in sync-job In sync-job, peer list will be retrieved always from the first UP server. There are chances that gluster daemon in other servers may be down. In this case, peer status for those servers will DISCONNECTED. When a host is found in UP state in Database and peer status is 'DISCONNECTED', that host will be moved to Non-Operational status. 'peer status' command will be executed on that server to make sure the gluster daemon is actually down before moving to Non-Operational. Change-Id: I3e0f661cb496e741f7c06df42ce3b55037a87e28 Bug-Url: https://bugzilla.redhat.com/1056997 Bug-Url: https://bugzilla.redhat.com/1097736 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 34 insertions(+), 20 deletions(-) Approvals: Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e0f661cb496e741f7c06df42ce3b55037a87e28 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: VdsNotRespondingTreatment Job is not marked as finished.
by oourfali＠redhat.com 19 May '14

19 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: VdsNotRespondingTreatment Job is not marked as finished. ...................................................................... core: VdsNotRespondingTreatment Job is not marked as finished. When a hypervisor gets into non responding state and it is fenced the job VdsNotRespondingTreatment is not marked as finished and get stuck in the tasks list. Change-Id: I956c8f8d51e8c9569013973044494a8c95a58454 Bug-Url: https://bugzilla.redhat.com/1075500 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I956c8f8d51e8c9569013973044494a8c95a58454 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: changed network_name column
by ydary＠redhat.com 19 May '14

19 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: changed network_name column ...................................................................... history: changed network_name column Changed network_name column to logical_network_name in the database tables, views and ETL process. Change-Id: Ic3d2f8815a7dbb48552c1c7b4162c570ea3f43b1 Bug-Url: https://bugzilla.redhat.com/891073 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_5/ConfigurationSync.java M packaging/dbscripts/create_views_3_0.sql M packaging/dbscripts/create_views_3_1.sql M packaging/dbscripts/create_views_3_2.sql M packaging/dbscripts/create_views_3_3.sql M packaging/dbscripts/create_views_3_4.sql M packaging/dbscripts/create_views_3_5.sql A packaging/dbscripts/upgrade/03_05_0040_change_network_name_column.sql M tos_project/process/ConfigurationSync_3.5.item M tos_project/process/ConfigurationSync_3.5.properties 10 files changed, 180 insertions(+), 176 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3d2f8815a7dbb48552c1c7b4162c570ea3f43b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Batch updates might create a database deadlock
by oourfali＠redhat.com 19 May '14

19 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Batch updates might create a database deadlock ...................................................................... core: Batch updates might create a database deadlock Batch updates might create a database deadlock in systems under load Sorting the batch collection by id should solve this problem Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098962 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add network name to "network used" error message
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Add network name to "network used" error message ...................................................................... engine: Add network name to "network used" error message This to assist users to identify which networks were not created as part of a batch import operation. Change-Id: I238d57ac3ae943aed312f45a2e6b7b4978b8f95b Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 10 insertions(+), 5 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I238d57ac3ae943aed312f45a2e6b7b4978b8f95b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Remove unused error NETWORK_NAME_IN_USE
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: userportal: Remove unused error NETWORK_NAME_IN_USE ...................................................................... userportal: Remove unused error NETWORK_NAME_IN_USE This error is only used in the webadmin console. Change-Id: I61263b74720bea33d326e6ff7a25f3a1baadc41e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61263b74720bea33d326e6ff7a25f3a1baadc41e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Save network configuration by default
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Save network configuration by default ...................................................................... webadmin: Save network configuration by default The default used to be to not persist the network configuration, but a user complained that his configuration unexpectedly got wiped. Now the default is to persist the configuration. Change-Id: Ie855130f05291e33df1609878c76e5023527b27c Bug-Url: https://bugzilla.redhat.com/1079691 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/27837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie855130f05291e33df1609878c76e5023527b27c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Allow default profile to turn into ghost entry
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Allow default profile to turn into ghost entry ...................................................................... webadmin: Allow default profile to turn into ghost entry Previously this was blocked, seemingly because generally ghost toggling events weren't being triggered for the default profile (when it was being update via the network name). This is hopefully fixed by registering for the model event itself. Change-Id: I0330a07a4af5b911aaa5c3214d56ae381771c0cc Bug-Url: https://bugzilla.redhat.com/1064396 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NetworkProfilesModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 3 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0330a07a4af5b911aaa5c3214d56ae381771c0cc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0