June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: refactor RestoreStatelessVmCommand
by ofrenkel＠redhat.com 01 Jun '14

01 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor RestoreStatelessVmCommand ...................................................................... core: refactor RestoreStatelessVmCommand Minor refactoring in RestoreStatelessVmCommand Change-Id: I8758f8d1f56b059ccde34889c3f56ea2d1c2d069 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 33 insertions(+), 23 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8758f8d1f56b059ccde34889c3f56ea2d1c2d069 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:entity rename log missing initiating user...
by emesika＠redhat.com 01 Jun '14

01 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core:entity rename log missing initiating user... ...................................................................... core:entity rename log missing initiating user... entity rename log missing initiating user name When you rename an entity, the initiating user who had renamed the entity is missing from the audit log message. this patch adds the current user name to the rename log message when an entity is renamed. Change-Id: If86bf6def2bce231c0acf4290cacd526ba074eae Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1082110 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If86bf6def2bce231c0acf4290cacd526ba074eae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UploadImageVDSCommand - read task id from header
by laravot＠redhat.com 01 Jun '14

01 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: UploadImageVDSCommand - read task id from header ...................................................................... core: UploadImageVDSCommand - read task id from header In the following patch [1] there's a behavior change, in case of a succesfull execution the task id will be returned within a header instead of the body. This patch just alignes the engine behavior to read the task id from it. [1] - http://gerrit.ovirt.org/#/c/27997/ Change-Id: I9d9d18fcefdc7862517d7d59aff18ba500e22c63 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UploadStreamVDSCommand.java 1 file changed, 9 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9d18fcefdc7862517d7d59aff18ba500e22c63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: aaa: add missing final to constants
by yzaslavs＠redhat.com 01 Jun '14

01 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: aaa: add missing final to constants ...................................................................... extapi: aaa: add missing final to constants Topic: AAA Change-Id: I1a352a876c2236aecdb13dc7c06b48edb8ed3e8d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a352a876c2236aecdb13dc7c06b48edb8ed3e8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0