Change in ovirt-live[master]: build: ovirt-live-3.5.0-beta2
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live-3.5.0-beta2
......................................................................
build: ovirt-live-3.5.0-beta2
Change-Id: Ibf525a46434382b316e8949f679041647efd950c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-base.ks.in
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf525a46434382b316e8949f679041647efd950c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Wrong vnics when creating vm from blank template
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Wrong vnics when creating vm from blank template
......................................................................
webadmin: Wrong vnics when creating vm from blank template
The 'Blank' template belongs to the 'Default' dc/cluster.
If the 'Blank' template has vnics with profiles, when creating a vm in
different cluster than 'Default' the vnic profiles (which don't exist in
the vm's cluster) should be overridden by 'Empty' profile.
This override happens in EditProfileBehavior->initSelectedProfile, but
since it is called before the registration of ProfileInstanceTypeEditor
to SelectedItemChangedEvent of VnicInstanceType the new selection of
'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface.
This patch fixes it by calling syncSelectedItemWithNetworkInterface(..)
also before the registration and not just from the eventRaised(..).
Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Bug-Url: https://bugzilla.redhat.com/1103058
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit c57055367478087dbdb3602671f8331b747bd9df)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: wrong log severity for interface up/down event logs
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: wrong log severity for interface up/down event logs
......................................................................
engine: wrong log severity for interface up/down event logs
Interface down events' log severity should be warning.
Interface up events' log severity should be normal.
Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff
Bug-Url: https://bugzilla.redhat.com/1113160
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ff6b663a141f75241ff27f8df12922c42de04ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-live[ovirt-live-3.4]: build: post ovirt-live-3.4.3-1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-live-3.4.3-1
......................................................................
build: post ovirt-live-3.4.3-1
Change-Id: I1320fcb66ad5abd562529e119059a321d185d371
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-base.ks.in
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1320fcb66ad5abd562529e119059a321d185d371
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-live[ovirt-live-3.4]: build: ovirt-live-3.4.3-1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live-3.4.3-1
......................................................................
build: ovirt-live-3.4.3-1
Respin including vdsm-4.14.11-2
Change-Id: I005a2c607fcae09a7a2b6f2816b57278b04c8973
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-base.ks.in
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I005a2c607fcae09a7a2b6f2816b57278b04c8973
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[master]: core: GetRngDeviceQuery should be a user query
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: GetRngDeviceQuery should be a user query
......................................................................
core: GetRngDeviceQuery should be a user query
Change-Id: I5589c7185a61c076123aee962c8ea2c097920617
Bug-Url: https://bugzilla.redhat.com/1122427
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRngDeviceQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5589c7185a61c076123aee962c8ea2c097920617
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Create new VM | Not all selected nics are created ...
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Create new VM | Not all selected nics are created on the VM
......................................................................
webadmin: Create new VM | Not all selected nics are created on the VM
Opening and closing ghost profile instance type editor without selecting a
value causes the first acceptable value to be displayed at the header text
box (just to be displayed, not really be selected-> the real value is
still null).
It is caused because ListModelTypeAheadListBox->adjustSelectedValue()
calls in the described case-
'setValue(acceptableValues.iterator().next())' without firing valueChange
event. The displayed value is changed, but the model.selectedValue is
still null.
Calling setValue with 'true' for 'fireValueChangeEvent' fixes the issue.
But, as I understand, if the the selected value ('getValue()') was 'null'
and wasn't changed manually to another value.
There is no reason to override it here by the first item in the list.
Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Bug-Url: https://bugzilla.redhat.com/1115788
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit 27b97db8ba54239eb7a01477fea4e499df1ba395)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
1 file changed, 13 insertions(+), 14 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8ec33db813f334f07baadac38f27c5544f0791
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix css on Firefox 24.5
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: frontend: Fix css on Firefox 24.5
......................................................................
frontend: Fix css on Firefox 24.5
Fixed the positioning of the checkbox label in the
SerialNumberPolicyWidget.
Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115326
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/30672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: webadmin: improve the console tab UI
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: improve the console tab UI
......................................................................
webadmin: improve the console tab UI
This patch fix the UI brokeness in the console TAB of the VM popup introduced
by the new spice tuning options.
Change-Id: Ifd7820ebcd6732eb3bba4e4a462d10653dbf10d5
Bug-Url: https://bugzilla.redhat.com/1115327
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit http://gerrit.ovirt.org/29577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd7820ebcd6732eb3bba4e4a462d10653dbf10d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: frontend: Fix issues with VmRngDevice.Source enum
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix issues with VmRngDevice.Source enum
......................................................................
frontend: Fix issues with VmRngDevice.Source enum
this patch fixes problems with ^ enum parsing in ClusterModel. This enum
is represented as lower-case string in the engine config. When matching
this enum to its string representation, toLowerCase() must be called
firstly.
Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/977079
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/28924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months