July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Hide vlan information of imported network
by masayag＠redhat.com 24 Jul '14

24 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Hide vlan information of imported network ...................................................................... engine: Hide vlan information of imported network The vlan id of an imported network should not be exposed to the engine, so it won't be persisted when the network is saved. Change-Id: I972ff166c4cdefe5b84b28aead245a3fed2b10ba Bug-Url: https://bugzilla.redhat.com/1031382 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I972ff166c4cdefe5b84b28aead245a3fed2b10ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Report event for external port removal failure
by masayag＠redhat.com 24 Jul '14

24 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Report event for external port removal failure ...................................................................... engine: Report event for external port removal failure If an external network provider is inaccessible, the engine command should not be failed. Instead, the port removal failure will be logged to the events log for a future reference for the admin to handle it on the neutron server. Change-Id: I57d42da98ff1c86f242f53204520fd4e219b3205 Bug-Url: https://bugzilla.redhat.com/1102542 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 22 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57d42da98ff1c86f242f53204520fd4e219b3205 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Wrong vnic profiles on vm based on template from ano...
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Wrong vnic profiles on vm based on template from another cluster ...................................................................... engine: Wrong vnic profiles on vm based on template from another cluster If- 1. New vm is based on template from different cluster (or even dc in case of 'Blank' template). And 2. The template has nics which's profile's network is not attached to the vm's cluster. Then- The profiles on the vm's nics should be overridden by 'Empty' profiles. Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Throw canDo on addVmCommand if template is not in cl...
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Throw canDo on addVmCommand if template is not in cluster ...................................................................... engine: Throw canDo on addVmCommand if template is not in cluster added a canDo- 'VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_NOT_EXISTS_IN_CURRENT_DC' to- AddVmCommand- if the templates is not in the vm's dc. AddVmFromScratchCommand- if the templates is not in the vm's dc and not 'Blank'. Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 22 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Wrong vnics when creating vm from blank template
by alkaplan＠redhat.com 24 Jul '14

24 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Wrong vnics when creating vm from blank template ...................................................................... webadmin: Wrong vnics when creating vm from blank template The 'Blank' template belongs to the 'Default' dc/cluster. If the 'Blank' template has vnics with profiles, when creating a vm in different cluster than 'Default' the vnic profiles (which don't exist in the vm's cluster) should be overridden by 'Empty' profile. This override happens in EditProfileBehavior->initSelectedProfile, but since it is called before the registration of ProfileInstanceTypeEditor to SelectedItemChangedEvent of VnicInstanceType the new selection of 'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface. This patch fixes it by calling syncSelectedItemWithNetworkInterface(..) also before the registration and not just from the eventRaised(..). Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Bug-Url: https://bugzilla.redhat.com/1103058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix css on Firefox 24.5
by tjelinek＠redhat.com 24 Jul '14

24 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix css on Firefox 24.5 ...................................................................... frontend: Fix css on Firefox 24.5 Fixed the positioning of the checkbox label in the SerialNumberPolicyWidget. Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115326 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/30019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cba6e0e4fe165f99e7638652e6f1286f68318c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update blank template origin type
by ofrenkel＠redhat.com 24 Jul '14

24 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: update blank template origin type ...................................................................... core: update blank template origin type currently the origin type for blank template is always RHEV there is a config in the db for the default origin type of vms so this patch uses this config to update blank template to the current configuration, should be OVIRT in most cases. Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057211 --- A packaging/dbscripts/upgrade/03_06_0050_update_blank_template_origin_type.sql 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: custom fencing settings are not save to DB
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: custom fencing settings are not save to DB ...................................................................... core: custom fencing settings are not save to DB 3.5 version introduced a new way to define custom fencing agents. However, there is a bug that caused custom PM agent settings not to be saved in DB. The UpdateVdsCommand canDoAction checks for validity of the agent and it comapres the selected agent against all of agents supported natively by the agent. The code was changed to take into account custom PM agents as well in the canDoAction validation Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122473 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: unlock_entity.sh fails on authentication
by piotr.kliczewski＠gmail.com 24 Jul '14

24 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: unlock_entity.sh fails on authentication ...................................................................... core: unlock_entity.sh fails on authentication The DB was configured in pg_hba.conf with md5 This means that in order to run this utility properly you should set the PGPASSWORD or PGPASSFILE environment variable. Example: \$ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q I had added this information to the utility help Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1118191 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit ea90fe17b2e6e0c839a54ced0407d99059146fc4) --- M packaging/dbscripts/unlock_entity.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Fix sporadic failure of BackwardCompatibilityTaskCr...
by yzaslavs＠redhat.com 24 Jul '14

24 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : Fix sporadic failure of BackwardCompatibilityTaskCreationTest ...................................................................... engine : Fix sporadic failure of BackwardCompatibilityTaskCreationTest testConcreateCreateTaskBackwardsComaptibility test in BackwardCompatibilityTaskCreationTest has sporadic failures due the changes in AsyncTaskFactory.construct method. Change-Id: I8d3b24582ed27384e0e46aad454a3c6fafb5130b Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d3b24582ed27384e0e46aad454a3c6fafb5130b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0