July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix ReconstructMasterDomainCommand constructor
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix ReconstructMasterDomainCommand constructor ...................................................................... core: fix ReconstructMasterDomainCommand constructor In change: 8255f44 aaa: more fixes to command context propgation a new constructor has been added modifying the existing one to call the base class (super). Instead to maintain the previous behavior the old constructor should have called the new one (in order to initialize the class). Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e54cccc9ebe7829a88c1ca296c1dfbf8542256 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: sync VM config after Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: sync VM config after Live Merge ...................................................................... core: sync VM config after Live Merge After a backwards merge, the child of a deleted snapshot will now have a different image associated with it. This needs to be reflected in the VM configuration for the snapshot, else the disks will be marked illegal in the UI and won't function properly when the snapshot is previewed/reverted. Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set active image after Live Merge of active layer
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: set active image after Live Merge of active layer ...................................................................... core: set active image after Live Merge of active layer Live Merging the active layer should mark the new active image. Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: allow successful retries of Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: allow successful retries of Live Merge ...................................................................... core: allow successful retries of Live Merge Change RemoveSnapshotSingleDiskLiveCommand and related commands to allow for successful retries after deletion or merge fails. Upon merge failure, images are marked illegal but remain in the volume chain. Retries will start over and attempt to merge the images again. Upon deletion failure (but after a successful merge), the volume chain is updated to reflect the new chain; however, the orphaned images are re-associated with the snapshot to be deleted, marked illegal, and set to have no parents or children. Upon retry, the command will detect this state and skip to the DESTROY_IMAGE execution step. Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 3 files changed, 161 insertions(+), 26 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix race when removing memory volumes during Live Merge
by amureini＠redhat.com 18 Jul '14

18 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix race when removing memory volumes during Live Merge ...................................................................... core: fix race when removing memory volumes during Live Merge Memory volume removal was not tracked as a child command, and its completion would trigger endAction of RemoveSnapshotCommand before the tasks run by ExecutionHandler were complete. Instead, use the newer RemoveMemoryVolumesCommand during Live Merge, which Executionhandler can coordinate. Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Avoiding collisions when running in parallel
by dcaroest＠redhat.com 18 Jul '14

18 Jul '14

David Caro has submitted this change and it was merged. Change subject: Avoiding collisions when running in parallel ...................................................................... Avoiding collisions when running in parallel It seems that it's not enough to use different temporary dirs, but using different names for the repos seems to work well. Change-Id: Id7370a80bc4022fb0d27c1495f30eaab1e5582a6 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 101 insertions(+), 99 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7370a80bc4022fb0d27c1495f30eaab1e5582a6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in mom[master]: Fixing vcpuCount periodic error.
by alitke＠redhat.com 18 Jul '14

18 Jul '14

Adam Litke has submitted this change and it was merged. Change subject: Fixing vcpuCount periodic error. ...................................................................... Fixing vcpuCount periodic error. When vcpu count is not available via the cpu tune, mom will display an error message every 10 sec. Change-Id: Ie913a68b95f0384dbd573275cd9e70cb6c740ee6 Bug-Url: https://bugzilla.redhat.com/1119775 Signed-off-by: Kobi Ianko <kianku(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/30181 Reviewed-by: Jiří Moskovčák <jmoskovc(a)redhat.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> Tested-by: Kobi Ianko <kobi(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/HypervisorInterfaces/vdsmInterface.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Looks good to me, but someone else must approve Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/30181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie913a68b95f0384dbd573275cd9e70cb6c740ee6 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: jobs: ovirt-hosted-engine-ha
by dcaroest＠redhat.com 18 Jul '14

18 Jul '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-hosted-engine-ha ...................................................................... jobs: ovirt-hosted-engine-ha Added job for ovirt-hosted-engine-ha, including master, 3.5 and 3.4 oVirt target releases. Change-Id: I5fb910852710db71de7a30c8f6866b7ed19db01b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb910852710db71de7a30c8f6866b7ed19db01b Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: changed a bit addCanDoActionMessage"
by yzaslavs＠redhat.com 18 Jul '14

18 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "core: changed a bit addCanDoActionMessage" ...................................................................... Revert "core: changed a bit addCanDoActionMessage" This reverts commit a066164feac9dcf278b5018b1a735920ed5ff766. Change-Id: I2fc735ba7cb75317c9239fdcd7ee21c7091edc4b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fc735ba7cb75317c9239fdcd7ee21c7091edc4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi : Facilitate accept-type specification as query param
by piotr.kliczewski＠gmail.com 18 Jul '14

18 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi : Facilitate accept-type specification as query param ...................................................................... restapi : Facilitate accept-type specification as query param Facilitate accept-type specification as query param Change-Id: I54a2d8d57b09df126f1d7b1b3824fa41cda7e64d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121055 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved anmolbabu: Verified -- To view, visit http://gerrit.ovirt.org/30264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a2d8d57b09df126f1d7b1b3824fa41cda7e64d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0