July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Remove leading / from RSDL action names
by piotr.kliczewski＠gmail.com 18 Jul '14

18 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Remove leading / from RSDL action names ...................................................................... restapi: Remove leading / from RSDL action names The action names in the RSDL metadata files contain leading slashes. Durign generation of the RSDL document these are compared to the generated links, which are relative, they don't have slashes. As a result the generated RSDL document doesn't contain the information extracted from the metadata file. Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Bug-Url: https://bugzilla.redhat.com/1102772 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5723ef221dd9f3ea4dc2e10eecf1ae8576cd7e08) --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Regenerate agains the latest API
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate agains the latest API ...................................................................... sdk: Regenerate agains the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 5723ef2. Change-Id: I228148e5316260c10c77f963f0895f17e16989da Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 4 files changed, 129 insertions(+), 24 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I228148e5316260c10c77f963f0895f17e16989da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove leading / from RSDL action names
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove leading / from RSDL action names ...................................................................... restapi: Remove leading / from RSDL action names The action names in the RSDL metadata files contain leading slashes. Durign generation of the RSDL document these are compared to the generated links, which are relative, they don't have slashes. As a result the generated RSDL document doesn't contain the information extracted from the metadata file. Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Bug-Url: https://bugzilla.redhat.com/1102772 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix access to current user
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix access to current user ...................................................................... restapi: Fix access to current user The code that extracts the current user from the backend stores VdcQueryReturnValue instead of the DbUser it contains. As a result several places where the user is needed fail with a NPE, as no object is found assciated to the DbUser class. Change-Id: I2dae86a0ab152df2971f55d663cf44f4d239f5e9 Bug-Url: https://bugzilla.redhat.com/1119862 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/SessionProcessor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dae86a0ab152df2971f55d663cf44f4d239f5e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Add support for virt-viewer
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add support for virt-viewer ...................................................................... cli: Add support for virt-viewer Currently the CLI supports opening a console using the "vncviewer" and "spicec" commands. This patch adds support for using the "remote-viewer" command as well. If the "remote-viewer" command is available it will be preferred. Change-Id: I036c8f4578c876cf012017b4d3ea19754e41d9c1 Bug-Url: https://bugzilla.redhat.com/807696 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/console.py M src/ovirtcli/platform/posix/spice.py M src/ovirtcli/platform/posix/vnc.py 3 files changed, 184 insertions(+), 36 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I036c8f4578c876cf012017b4d3ea19754e41d9c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Fix naming conflict
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Fix naming conflict ...................................................................... codegen: Fix naming conflict Currently the code generator generates conflicting classes when the calculated name of a entity is the same of a collection. For example, for the following collection: /hosts/{host:id}/storage Note that the name of the collection doesn't end in "s". As a result the code generator produces a HostStorage class for the collection and a HostStorage (same name) class for the entity. Due to the order they are generated the collection class overwrites the entity class. To avoid this issue this patch changes the code generator so that it will automaticall add the "s" to the collection class name when there is a conflict like this. Change-Id: Ia408b8e16234595b4454c2d252f5fec16414ca49 Bug-Url: https://bugzilla.redhat.com/1120502 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6bc4526a9f5fa761cd9f64cc7b311fd57e1c3628) --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia408b8e16234595b4454c2d252f5fec16414ca49 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Fix naming conflict
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Fix naming conflict ...................................................................... codegen: Fix naming conflict Currently the code generator generates conflicting classes when the calculated name of a entity is the same of a collection. For example, for the following collection: /hosts/{host:id}/storage Note that the name of the collection doesn't end in "s". As a result the code generator produces a HostStorage class for the collection and a HostStorage (same name) class for the entity. Due to the order they are generated the collection class overwrites the entity class. To avoid this issue this patch changes the code generator so that it will automaticall add the "s" to the collection class name when there is a conflict like this. Change-Id: Ia408b8e16234595b4454c2d252f5fec16414ca49 Bug-Url: https://bugzilla.redhat.com/1120502 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia408b8e16234595b4454c2d252f5fec16414ca49 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[cli_3.5]: cli: Don't fail when there is no tty
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't fail when there is no tty ...................................................................... cli: Don't fail when there is no tty Currently we always try to open the /dev/tty device, but this will fail in environments where there isn't a terminal available, like when running from a cron script. This patch changes the CLI so that it won't crash in these situations. Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3 Bug-Url: https://bugzilla.redhat.com/1119412 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a2e573477e38bdc2ba4b3c778f4b69b3928d57cc) --- M src/cli/platform/posix/terminal.py 1 file changed, 26 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Don't fail when there is no tty
by juan.hernandez＠redhat.com 18 Jul '14

18 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't fail when there is no tty ...................................................................... cli: Don't fail when there is no tty Currently we always try to open the /dev/tty device, but this will fail in environments where there isn't a terminal available, like when running from a cron script. This patch changes the CLI so that it won't crash in these situations. Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3 Bug-Url: https://bugzilla.redhat.com/1119412 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/platform/posix/terminal.py 1 file changed, 26 insertions(+), 14 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: change code of AddUser and AddGroup
by piotr.kliczewski＠gmail.com 18 Jul '14

18 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: change code of AddUser and AddGroup ...................................................................... aaa: change code of AddUser and AddGroup removing the check from canDoAction to check if entity exists in directory as these checks are done both by rest-api and gui. Bug-Url: https://bugzilla.redhat.com/1120609 Topic: AAA Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddGroupParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUserParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java 13 files changed, 127 insertions(+), 190 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0