July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add VdcActionType tests
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add VdcActionType tests ...................................................................... core: Add VdcActionType tests Added tests to: - Validate that every command values is unique - Validate that every command type in VdcActionType corresponds to an existing command class Change-Id: I53b51b359e14e2f1ebb6e518846f1cf00c8bbe6b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java 1 file changed, 46 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53b51b359e14e2f1ebb6e518846f1cf00c8bbe6b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused query types in VdcQueryType
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused query types in VdcQueryType ...................................................................... core: Remove unused query types in VdcQueryType Removed query types that does not correspond with an existing query class in VdcQueryType as they are useless Change-Id: Ibffaf330c738e01680edf21b5ecd099e9be173a0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibffaf330c738e01680edf21b5ecd099e9be173a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove static member initialization from a config value
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove static member initialization from a config value ...................................................................... core: Remove static member initialization from a config value Removed static member initialization from a config value in InitVdsOnUpCommand, initialization of static member from config, database and such prevent the possibility to initialize a class instance without mocking the corresponding environments and is considered bad practice Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused action types in VdcActionType
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused action types in VdcActionType ...................................................................... core: Remove unused action types in VdcActionType Removed action types that does not correspond with an existing command class in VdcActionType as they are useless Change-Id: Ic0e7d92edb85a0fb1f8994cf5d46a28dae97b5da Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0e7d92edb85a0fb1f8994cf5d46a28dae97b5da Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change duplicate action type values to unique ones
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Change duplicate action type values to unique ones ...................................................................... core: Change duplicate action type values to unique ones Since the action type value is supposed to be unique, a test will be added to enforce uniqueness of the action type values prior to that, since we have duplicate values in the VdcActionType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: Remove redundant change password code
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core, webadmin: Remove redundant change password code ...................................................................... core, webadmin: Remove redundant change password code Since we do not support change password via the user portal, the code there is redundant and can be removed Change-Id: Ia576ffdf192bd37ecd22e123bd427cdf5d8bff41 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeUserPasswordParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 0 insertions(+), 147 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia576ffdf192bd37ecd22e123bd427cdf5d8bff41 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Don't show fence_kdump listener in summary
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Don't show fence_kdump listener in summary ...................................................................... packaging: Don't show fence_kdump listener in summary Don't show "Configuring fence_kdump listener" message in summary of engine-setup, because listener is part of ovirt-engine setup (cannot be enabled/disabled by user). Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Bug-Url: https://bugzilla.redhat.com/1114040 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py 2 files changed, 3 insertions(+), 40 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: command: making default log file location generic in help text
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: command: making default log file location generic in help text ...................................................................... command: making default log file location generic in help text The default name of log file contains an execution timestamp; the command help text prints it evaluating it at command execution time so that file will not really exist. Making it generic using a placeholder. Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633 Bug-Url: https://bugzilla.redhat.com/1061636 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 73da03974029086ead9747d69c023c91939aa6d2) --- M src/__main__.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add uniqueness test to AuditLogValue
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add uniqueness test to AuditLogValue ...................................................................... core: Add uniqueness test to AuditLogValue Since the audit log value is supposed to be unique, this test will enforce the uniqueness of the audit log values Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/AuditLogTypeTest.java 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: command: making default log file location generic in help text
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: command: making default log file location generic in help text ...................................................................... command: making default log file location generic in help text The default name of log file contains an execution timestamp; the command help text prints it evaluating it at command execution time so that file will not really exist. Making it generic using a placeholder. Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633 Bug-Url: https://bugzilla.redhat.com/1061636 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/30116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Petr Benas <pbenas(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0